OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Re-enable error logging associated with assembly and script loading failure in ScriptInstance. 

Swallowing exceptions just leads to more mysterious failures later on.
iar_mods
Justin Clark-Casey (justincc) 2012-01-26 00:28:51 +00:00
parent 55c6cbabfd
commit 13d9b64b1d
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
OpenSim/Region/ScriptEngine/Shared/Instance/ScriptInstance.cs
View File

@ -55,7 +55,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
{ {
public class ScriptInstance : MarshalByRefObject, IScriptInstance public class ScriptInstance : MarshalByRefObject, IScriptInstance
{ {
// private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType); private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);
private IScriptEngine m_Engine; private IScriptEngine m_Engine;
private IScriptWorkItem m_CurrentResult = null; private IScriptWorkItem m_CurrentResult = null;
@ -127,6 +127,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
m_minEventDelay = value; m_minEventDelay = value;
else else
m_minEventDelay = 0.0; m_minEventDelay = 0.0;
m_eventDelayTicks = (long)(m_minEventDelay * 10000000L); m_eventDelayTicks = (long)(m_minEventDelay * 10000000L);
m_nextEventTimeTicks = DateTime.Now.Ticks; m_nextEventTimeTicks = DateTime.Now.Ticks;
} }
@ -296,9 +297,11 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
//RemotingServices.GetLifetimeService(m_Script as ScriptBaseClass); //RemotingServices.GetLifetimeService(m_Script as ScriptBaseClass);
// lease.Register(this); // lease.Register(this);
} }
catch (Exception) catch (Exception e)
{ {
// m_log.ErrorFormat("[Script] Error loading assembly {0}\n"+e.ToString(), assembly); m_log.ErrorFormat(
"[SCRIPT INSTANCE]: Error loading assembly {0}. Exception {1}{2}",
assembly, e.Message, e.StackTrace);
} }
try try
@ -313,9 +316,12 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
part.SetScriptEvents(m_ItemID, part.SetScriptEvents(m_ItemID,
(int)m_Script.GetStateEventFlags(State)); (int)m_Script.GetStateEventFlags(State));
} }
catch (Exception) catch (Exception e)
{ {
// m_log.Error("[Script] Error loading script instance\n"+e.ToString()); m_log.ErrorFormat(
"[SCRIPT INSTANCE]: Error loading script instance from assembly {0}. Exception {1}{2}",
assembly, e.Message, e.StackTrace);
return; return;
} }
@ -377,12 +383,16 @@ namespace OpenSim.Region.ScriptEngine.Shared.Instance
} }
else else
{ {
// m_log.Error("[Script] Unable to load script state: Memory limit exceeded"); m_log.ErrorFormat(
"[SCRIPT INSTANCE]: Unable to load script state from assembly {0}: Memory limit exceeded",
assembly);
} }
} }
catch (Exception) catch (Exception e)
{ {
// m_log.ErrorFormat("[Script] Unable to load script state from xml: {0}\n"+e.ToString(), xml); m_log.ErrorFormat(
"[SCRIPT INSTANCE]: Unable to load script state from assembly {0}. XML is {1}. Exception {2}{3}",
assembly, xml, e.Message, e.StackTrace);
} }
} }
// else // else