From 172e2f4e7609c278d02ad83ca207fd79624db587 Mon Sep 17 00:00:00 2001
From: CasperW <tom@streamsense.net>
Date: Sun, 6 Dec 2009 17:23:07 +0100
Subject: [PATCH] Fix to existing ReaderWriterLockSlim implementations

---
 OpenSim/Framework/TaskInventoryDictionary.cs           | 10 ++++++++--
 OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs    | 10 ++++++++--
 .../Framework/Scenes/SceneObjectPartInventory.cs       |  3 ++-
 OpenSim/Region/ScriptEngine/XEngine/XEngine.cs         | 10 ++++++++--
 4 files changed, 26 insertions(+), 7 deletions(-)

diff --git a/OpenSim/Framework/TaskInventoryDictionary.cs b/OpenSim/Framework/TaskInventoryDictionary.cs
index efe5f0cb47..4b9a509e6b 100644
--- a/OpenSim/Framework/TaskInventoryDictionary.cs
+++ b/OpenSim/Framework/TaskInventoryDictionary.cs
@@ -109,7 +109,10 @@ namespace OpenSim.Framework
             }
             else
             {
-                m_itemLock.ExitReadLock();
+                if (m_itemLock.RecursiveReadCount>0)
+                {
+                    m_itemLock.ExitReadLock();
+                }
             }
         }
 
@@ -144,7 +147,10 @@ namespace OpenSim.Framework
             }
             else
             {
-                m_itemLock.ExitWriteLock();
+                if (m_itemLock.RecursiveWriteCount > 0)
+                {
+                    m_itemLock.ExitWriteLock();
+                }
             }
         }
 
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
index 93888f1e37..eacd21977d 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
@@ -126,7 +126,10 @@ namespace OpenSim.Region.Framework.Scenes
             }
             else
             {
-                m_partsLock.ExitReadLock();
+                if (m_partsLock.RecursiveReadCount > 0)
+                {
+                    m_partsLock.ExitReadLock();
+                }
             }
         }
         public void lockPartsForWrite(bool locked)
@@ -155,7 +158,10 @@ namespace OpenSim.Region.Framework.Scenes
             }
             else
             {
-                m_partsLock.ExitWriteLock();
+                if (m_partsLock.RecursiveWriteCount > 0)
+                {
+                    m_partsLock.ExitWriteLock();
+                }
             }
         }
 
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs b/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
index 4780ff2036..b57d91218b 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs
@@ -320,17 +320,18 @@ namespace OpenSim.Region.Framework.Scenes
             {
                 if (m_items.ContainsKey(itemId))
                 {
+                    m_items.LockItemsForRead(false);
                     CreateScriptInstance(m_items[itemId], startParam, postOnRez, engine, stateSource);
                 }
                 else
                 {
+                    m_items.LockItemsForRead(false);
                     m_log.ErrorFormat(
                         "[PRIM INVENTORY]: " +
                         "Couldn't start script with ID {0} since it couldn't be found for prim {1}, {2} at {3} in {4}",
                         itemId, m_part.Name, m_part.UUID, 
                         m_part.AbsolutePosition, m_part.ParentGroup.Scene.RegionInfo.RegionName);
                 }
-                m_items.LockItemsForRead(false);
             }
             else
             {
diff --git a/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs b/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs
index 49c69ab9e4..184af19ebf 100644
--- a/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs
+++ b/OpenSim/Region/ScriptEngine/XEngine/XEngine.cs
@@ -150,7 +150,10 @@ namespace OpenSim.Region.ScriptEngine.XEngine
             }
             else
             {
-                m_scriptsLock.ExitReadLock();
+                if (m_scriptsLock.RecursiveReadCount > 0)
+                {
+                    m_scriptsLock.ExitReadLock();
+                }
             }
         }
         private void lockScriptsForWrite(bool locked)
@@ -179,7 +182,10 @@ namespace OpenSim.Region.ScriptEngine.XEngine
             }
             else
             {
-                m_scriptsLock.ExitWriteLock();
+                if (m_scriptsLock.RecursiveWriteCount > 0)
+                {
+                    m_scriptsLock.ExitWriteLock();
+                }
             }
         }