From 233c872d24c8cc9d0b883ff8f816f67e57638042 Mon Sep 17 00:00:00 2001
From: Melanie Thielker <melanie@t-data.com>
Date: Fri, 2 Jul 2010 09:40:58 +0200
Subject: [PATCH] Call client.Start() sunchronously. Calling thos async avoids
 some stuttering when people log in, but fatally screws up money.

---
 OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs b/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
index cda461c4b8..f2bcc0b48f 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
@@ -900,7 +900,16 @@ namespace OpenSim.Region.ClientStack.LindenUDP
 
                 // Start the IClientAPI
                 // Spin it off so that it doesn't clog up the LLUDPServer
-                Util.FireAndForget(delegate(object o) { client.Start(); });
+                //Util.FireAndForget(delegate(object o) { client.Start(); });
+
+                // NOTE: DO NOT CALL THIS ASYNCHRONOUSLY!!!!!
+                // This method will ultimately cause the modules to hook
+                // client events in OnNewClient. If they can't do this
+                // before further packets are processed, packets WILL BE LOST.
+                // This includes the all-important EconomyDataRequest!
+                // So using FireAndForget here WILL screw up money. Badly.
+                // You have been warned!
+                client.Start();
             }
             else
             {