get rid of vestigal move to parameters

OpenSim/ApplicationPlugins/Rest/Inventory/tests/Remote.cs

@@ -169,7 +169,7 @@ namespace OpenSim.ApplicationPlugins.Rest.Inventory.Tests
                         float y = Convert.ToSingle(rdata.Parameters[PARM_MOVE_Y]);
                         float z = Convert.ToSingle(rdata.Parameters[PARM_MOVE_Z]);
                         Vector3 vector = new Vector3(x, y, z);
-                        presence.DoMoveToPosition(0, vector, presence.ControllingClient);
+                        presence.DoMoveToPosition(vector);
                     }
                     catch (Exception e)
                     {

OpenSim/Framework/IClientAPI.cs

@@ -935,7 +935,7 @@ namespace OpenSim.Framework
         event ScriptReset OnScriptReset;
         event GetScriptRunning OnGetScriptRunning;
         event SetScriptRunning OnSetScriptRunning;
-        event UpdateVector OnAutoPilotGo;
+        event Action<Vector3> OnAutoPilotGo;
 
         event TerrainUnacked OnUnackedTerrain;
         event ActivateGesture OnActivateGesture;

OpenSim/Region/ClientStack/Linden/UDP/LLClientView.cs

@@ -231,7 +231,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP
         public event ScriptReset OnScriptReset;
         public event GetScriptRunning OnGetScriptRunning;
         public event SetScriptRunning OnSetScriptRunning;
-        public event UpdateVector OnAutoPilotGo;
+        public event Action<Vector3> OnAutoPilotGo;
         public event TerrainUnacked OnUnackedTerrain;
         public event ActivateGesture OnActivateGesture;
         public event DeactivateGesture OnDeactivateGesture;
@@ -11617,36 +11617,20 @@ namespace OpenSim.Region.ClientStack.LindenUDP
 
         protected void HandleAutopilot(Object sender, string method, List<String> args)
         {
-            try
+            float locx = 0;
-            {
+            float locy = 0;
-                float locx = 0f;
+            float locz = 0;
-                float locy = 0f;
-                float locz = 0f;
             uint regionX = 0;
             uint regionY = 0;
-                try
+
-                {
             Utils.LongToUInts(m_scene.RegionInfo.RegionHandle, out regionX, out regionY);
             locx = Convert.ToSingle(args[0]) - (float)regionX;
             locy = Convert.ToSingle(args[1]) - (float)regionY;
             locz = Convert.ToSingle(args[2]);
-                }
-                catch (InvalidCastException)
-                {
-                    m_log.Error("[CLIENT]: Invalid autopilot request");
-                    return;
-                }
 
-                UpdateVector handlerAutoPilotGo = OnAutoPilotGo;
+            Action<Vector3> handlerAutoPilotGo = OnAutoPilotGo;
             if (handlerAutoPilotGo != null)
-                {
+                handlerAutoPilotGo(new Vector3(locx, locy, locz));
-                    handlerAutoPilotGo(0, new Vector3(locx, locy, locz), this);
-                }
-            }
-            catch (Exception e)
-            {
-                m_log.ErrorFormat("[LLCLIENTVIEW]: HandleAutopilot exception {0} {1}", e.Message, e.StackTrace);
-            }
         }
 
         /// <summary>

OpenSim/Region/Examples/SimpleModule/MyNpcCharacter.cs

@@ -222,7 +222,7 @@ namespace OpenSim.Region.Examples.SimpleModule
         public event ScriptReset OnScriptReset;
         public event GetScriptRunning OnGetScriptRunning;
         public event SetScriptRunning OnSetScriptRunning;
-        public event UpdateVector OnAutoPilotGo;
+        public event Action<Vector3> OnAutoPilotGo;
 
         public event TerrainUnacked OnUnackedTerrain;
 

OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs

@@ -1650,7 +1650,7 @@ namespace OpenSim.Region.Framework.Scenes
                     ScenePresence avatar = m_scene.GetScenePresence(rootpart.AttachedAvatar);
                     if (avatar != null)
                     {
-                        avatar.DoMoveToPosition(0, target, null);
+                        avatar.DoMoveToPosition(target);
                     }
                 }
                 else

OpenSim/Region/Framework/Scenes/ScenePresence.cs

@@ -1537,8 +1537,11 @@ namespace OpenSim.Region.Framework.Scenes
         }
 
         /// <summary>
-        /// Process moving the avatar if a position has been set.
+        /// Process move to update for an avatar.
         /// </summary>
+        /// <remarks>
+        /// This doesn't actually perform the movement.  Instead, it adds its vector to agent_control_v3
+        /// </remarks>
         /// <param value="agent_control_v3">Cumulative agent movement that this method will update.</param>
         /// <param value="bodyRotation">New body rotation of the avatar.</param>
         /// <param value="reset">If true, clear the move to position</param>
@@ -1698,7 +1701,7 @@ namespace OpenSim.Region.Framework.Scenes
         /// Move this presence to the given position over time.
         /// </summary>
         /// <param name="pos"></param>
-        public void DoMoveToPosition(uint not_used, Vector3 pos, IClientAPI remote_client)
+        public void DoMoveToPosition(Vector3 pos)
         {
 //            m_log.DebugFormat(
 //                "[SCENE PRESENCE]: Avatar {0} received request to move to position {1} in {2}",

OpenSim/Region/OptionalModules/Agent/InternetRelayClientView/Server/IRCClientView.cs

@@ -806,7 +806,7 @@ namespace OpenSim.Region.OptionalModules.Agent.InternetRelayClientView.Server
         public event ScriptReset OnScriptReset;
         public event GetScriptRunning OnGetScriptRunning;
         public event SetScriptRunning OnSetScriptRunning;
-        public event UpdateVector OnAutoPilotGo;
+        public event Action<Vector3> OnAutoPilotGo;
         public event TerrainUnacked OnUnackedTerrain;
         public event ActivateGesture OnActivateGesture;
         public event DeactivateGesture OnDeactivateGesture;

OpenSim/Region/OptionalModules/World/NPC/NPCAvatar.cs

@@ -328,7 +328,7 @@ namespace OpenSim.Region.OptionalModules.World.NPC
         public event ScriptReset OnScriptReset;
         public event GetScriptRunning OnGetScriptRunning;
         public event SetScriptRunning OnSetScriptRunning;
-        public event UpdateVector OnAutoPilotGo;
+        public event Action<Vector3> OnAutoPilotGo;
 
         public event TerrainUnacked OnUnackedTerrain;
 

OpenSim/Region/OptionalModules/World/NPC/NPCModule.cs

@@ -189,7 +189,7 @@ namespace OpenSim.Region.OptionalModules.World.NPC
                     m_log.DebugFormat(
                         "[NPC MODULE]: Moving {0} to {1} in {2}", sp.Name, pos, scene.RegionInfo.RegionName);
 
-                    sp.DoMoveToPosition(0, pos, m_avatars[agentID]);
+                    sp.DoMoveToPosition(pos);
                 }
             }
         }

OpenSim/Tests/Common/Mock/TestClient.cs

@@ -234,7 +234,7 @@ namespace OpenSim.Tests.Common.Mock
         public event ScriptReset OnScriptReset;
         public event GetScriptRunning OnGetScriptRunning;
         public event SetScriptRunning OnSetScriptRunning;
-        public event UpdateVector OnAutoPilotGo;
+        public event Action<Vector3> OnAutoPilotGo;
 
         public event TerrainUnacked OnUnackedTerrain;