OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactor scene presence list for lockless iteration. Lock contention will now only be for simultaneous add/removes of scene presences from the scene.

slimupdates2
Dan Lake 2010-05-04 16:49:46 -07:00 committed by unknown
parent 231cc64709
commit 36bcab5f07
1 changed files with 53 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

114
OpenSim/Region/Framework/Scenes/SceneGraph.cs
View File

@ -68,8 +68,9 @@ namespace OpenSim.Region.Framework.Scenes
#region Fields #region Fields
protected Dictionary<UUID, ScenePresence> m_scenePresences = new Dictionary<UUID, ScenePresence>(); protected object m_presenceLock = new object();
protected ScenePresence[] m_scenePresenceArray = new ScenePresence[0]; protected Dictionary<UUID, ScenePresence> m_scenePresenceMap = new Dictionary<UUID, ScenePresence>();
protected List<ScenePresence> m_scenePresenceArray = new List<ScenePresence>();
// SceneObjects is not currently populated or used. // SceneObjects is not currently populated or used.
//public Dictionary<UUID, SceneObjectGroup> SceneObjects; //public Dictionary<UUID, SceneObjectGroup> SceneObjects;
@ -132,10 +133,12 @@ namespace OpenSim.Region.Framework.Scenes
protected internal void Close() protected internal void Close()
{ {
lock (m_scenePresences) lock (m_presenceLock)
{ {
m_scenePresences.Clear(); Dictionary<UUID, ScenePresence> newmap = new Dictionary<UUID, ScenePresence>();
m_scenePresenceArray = new ScenePresence[0]; List<ScenePresence> newlist = new List<ScenePresence>();
m_scenePresenceMap = newmap;
m_scenePresenceArray = newlist;
} }
lock (m_dictionary_lock) lock (m_dictionary_lock)
@ -518,34 +521,29 @@ namespace OpenSim.Region.Framework.Scenes
Entities[presence.UUID] = presence; Entities[presence.UUID] = presence;
lock (m_scenePresences) lock (m_presenceLock)
{ {
if (!m_scenePresences.ContainsKey(presence.UUID)) Dictionary<UUID, ScenePresence> newmap = new Dictionary<UUID, ScenePresence>(m_scenePresenceMap);
{ List<ScenePresence> newlist = new List<ScenePresence>(m_scenePresenceArray);
m_scenePresences.Add(presence.UUID, presence);
// Create a new array of ScenePresence references if (!newmap.ContainsKey(presence.UUID))
int oldLength = m_scenePresenceArray.Length; {
ScenePresence[] newArray = new ScenePresence[oldLength + 1]; newmap.Add(presence.UUID, presence);
Array.Copy(m_scenePresenceArray, newArray, oldLength); newlist.Add(presence);
newArray[oldLength] = presence;
m_scenePresenceArray = newArray;
} }
else else
{ {
m_scenePresences[presence.UUID] = presence; // Remember the old presene reference from the dictionary
ScenePresence oldref = newmap[presence.UUID];
// Do a linear search through the array of ScenePresence references // Replace the presence reference in the dictionary with the new value
// and update the modified entry newmap[presence.UUID] = presence;
for (int i = 0; i < m_scenePresenceArray.Length; i++) // Find the index in the list where the old ref was stored and update the reference
{ newlist[newlist.IndexOf(oldref)] = presence;
if (m_scenePresenceArray[i].UUID == presence.UUID)
{
m_scenePresenceArray[i] = presence;
break;
}
}
} }
// Swap out the dictionary and list with new references
m_scenePresenceMap = newmap;
m_scenePresenceArray = newlist;
} }
} }
@ -561,25 +559,21 @@ namespace OpenSim.Region.Framework.Scenes
agentID); agentID);
} }
lock (m_scenePresences) lock (m_presenceLock)
{ {
if (m_scenePresences.Remove(agentID)) Dictionary<UUID, ScenePresence> newmap = new Dictionary<UUID, ScenePresence>(m_scenePresenceMap);
List<ScenePresence> newlist = new List<ScenePresence>(m_scenePresenceArray);
// Remember the old presene reference from the dictionary
ScenePresence oldref = newmap[agentID];
// Remove the presence reference from the dictionary
if (newmap.Remove(agentID))
{ {
// Copy all of the elements from the previous array // Find the index in the list where the old ref was stored and remove the reference
// into the new array except the removed element newlist.RemoveAt(newlist.IndexOf(oldref));
int oldLength = m_scenePresenceArray.Length; // Swap out the dictionary and list with new references
ScenePresence[] newArray = new ScenePresence[oldLength - 1]; m_scenePresenceMap = newmap;
int j = 0; m_scenePresenceArray = newlist;
for (int i = 0; i < m_scenePresenceArray.Length; i++)
{
ScenePresence presence = m_scenePresenceArray[i];
if (presence.UUID != agentID)
{
newArray[j] = presence;
++j;
}
}
m_scenePresenceArray = newArray;
} }
else else
{ {
@ -698,7 +692,7 @@ namespace OpenSim.Region.Framework.Scenes
} }
/// <summary> /// <summary>
/// Request a copy of m_scenePresences in this World /// Get a reference to the scene presence list. Changes to the list will be done in a copy
/// There is no guarantee that presences will remain in the scene after the list is returned. /// There is no guarantee that presences will remain in the scene after the list is returned.
/// This list should remain private to SceneGraph. Callers wishing to iterate should instead /// This list should remain private to SceneGraph. Callers wishing to iterate should instead
/// pass a delegate to ForEachScenePresence. /// pass a delegate to ForEachScenePresence.
@ -706,8 +700,7 @@ namespace OpenSim.Region.Framework.Scenes
/// <returns></returns> /// <returns></returns>
private List<ScenePresence> GetScenePresences() private List<ScenePresence> GetScenePresences()
{ {
lock (m_scenePresences) return m_scenePresenceArray;
return new List<ScenePresence>(m_scenePresenceArray);
} }
/// <summary> /// <summary>
@ -717,12 +710,10 @@ namespace OpenSim.Region.Framework.Scenes
/// <returns>null if the presence was not found</returns> /// <returns>null if the presence was not found</returns>
protected internal ScenePresence GetScenePresence(UUID agentID) protected internal ScenePresence GetScenePresence(UUID agentID)
{ {
ScenePresence sp; Dictionary<UUID, ScenePresence> presences = m_scenePresenceMap;
lock (m_scenePresences) ScenePresence presence;
{ presences.TryGetValue(agentID, out presence);
m_scenePresences.TryGetValue(agentID, out sp); return presence;
}
return sp;
} }
/// <summary> /// <summary>
@ -733,7 +724,8 @@ namespace OpenSim.Region.Framework.Scenes
/// <returns>null if the presence was not found</returns> /// <returns>null if the presence was not found</returns>
protected internal ScenePresence GetScenePresence(string firstName, string lastName) protected internal ScenePresence GetScenePresence(string firstName, string lastName)
{ {
foreach (ScenePresence presence in GetScenePresences()) List<ScenePresence> presences = GetScenePresences();
foreach (ScenePresence presence in presences)
{ {
if (presence.Firstname == firstName && presence.Lastname == lastName) if (presence.Firstname == firstName && presence.Lastname == lastName)
return presence; return presence;
@ -748,7 +740,8 @@ namespace OpenSim.Region.Framework.Scenes
/// <returns>null if the presence was not found</returns> /// <returns>null if the presence was not found</returns>
protected internal ScenePresence GetScenePresence(uint localID) protected internal ScenePresence GetScenePresence(uint localID)
{ {
foreach (ScenePresence presence in GetScenePresences()) List<ScenePresence> presences = GetScenePresences();
foreach (ScenePresence presence in presences)
if (presence.LocalId == localID) if (presence.LocalId == localID)
return presence; return presence;
return null; return null;
@ -756,10 +749,8 @@ namespace OpenSim.Region.Framework.Scenes
protected internal bool TryGetScenePresence(UUID agentID, out ScenePresence avatar) protected internal bool TryGetScenePresence(UUID agentID, out ScenePresence avatar)
{ {
lock (m_scenePresences) Dictionary<UUID, ScenePresence> presences = m_scenePresenceMap;
{ presences.TryGetValue(agentID, out avatar);
m_scenePresences.TryGetValue(agentID, out avatar);
}
return (avatar != null); return (avatar != null);
} }
@ -1036,8 +1027,9 @@ namespace OpenSim.Region.Framework.Scenes
}); });
Parallel.ForEach<ScenePresence>(GetScenePresences(), protectedAction); Parallel.ForEach<ScenePresence>(GetScenePresences(), protectedAction);
*/ */
// For now, perform actiona serially // For now, perform actions serially
foreach (ScenePresence sp in GetScenePresences()) List<ScenePresence> presences = GetScenePresences();
foreach (ScenePresence sp in presences)
{ {
try try
{ {