OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Drop some unnecessary ContainsKey() checking before Remove() in BaseHttpServer() 

Remove() presumably does this check anyway since it just returns false if the key is not in the collection.
0.7.2-post-fixes
Justin Clark-Casey (justincc) 2011-10-24 23:26:41 +01:00
parent e5286b7b7c
commit 435aefe1bf
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs
View File

@ -1814,12 +1814,7 @@ namespace OpenSim.Framework.Servers.HttpServer
public void RemovePollServiceHTTPHandler(string httpMethod, string path) public void RemovePollServiceHTTPHandler(string httpMethod, string path)
{ {
lock (m_pollHandlers) lock (m_pollHandlers)
{
if (m_pollHandlers.ContainsKey(path))
{
m_pollHandlers.Remove(path); m_pollHandlers.Remove(path);
}
}
RemoveHTTPHandler(httpMethod, path); RemoveHTTPHandler(httpMethod, path);
} }
@ -1843,13 +1838,8 @@ namespace OpenSim.Framework.Servers.HttpServer
public void RemoveXmlRPCHandler(string method) public void RemoveXmlRPCHandler(string method)
{ {
lock (m_rpcHandlers) lock (m_rpcHandlers)
{
if (m_rpcHandlers.ContainsKey(method))
{
m_rpcHandlers.Remove(method); m_rpcHandlers.Remove(method);
} }
}
}
public bool RemoveLLSDHandler(string path, LLSDMethod handler) public bool RemoveLLSDHandler(string path, LLSDMethod handler)
{ {