OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Thank you kindly, MCortez for a patch that solves: 

Different people using Hippo 0.5.1 report that trying 
to send group instant messages crashes the viewer 
(Hippo 0.5.1). This is the case even for empty groups 
or if all group members are online.
0.6.5-rc1
Charles Krinke 2009-05-02 16:16:27 +00:00
parent 070cd35f00
commit 47640aca22
2 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
OpenSim/Region/OptionalModules/Avatar/XmlRpcGroups/XmlRpcGroupsModule.cs
View File

@ -1089,6 +1089,11 @@ namespace OpenSim.Region.OptionalModules.Avatar.XmlRpcGroups
private GroupRequestID GetClientGroupRequestID(IClientAPI client)
{
if (client == null)
{
return new GroupRequestID();
}
lock (m_clientRequestIDInfo)
{
if (!m_clientRequestIDInfo.ContainsKey(client.AgentId))
@ -1098,7 +1103,19 @@ namespace OpenSim.Region.OptionalModules.Avatar.XmlRpcGroups
info.RequestID.SessionID = client.SessionId;
UserProfileData userProfile = m_sceneList[0].CommsManager.UserService.GetUserProfile(client.AgentId);
if (userProfile is ForeignUserProfileData)
if (userProfile == null)
{
// This should be impossible. If I've been passed a reference to a client
// that client should be registered with the UserService. So something
// is horribly wrong somewhere.
m_log.WarnFormat("[GROUPS]: Could not find a user profile for {0} / {1}", client.Name, client.AgentId);
// Default to local user service and hope for the best?
info.RequestID.UserServiceURL = m_sceneList[0].CommsManager.NetworkServersInfo.UserURL;
}
else if (userProfile is ForeignUserProfileData)
{
// They aren't from around here
ForeignUserProfileData fupd = (ForeignUserProfileData)userProfile;

7
bin/OpenSim.ini.example
View File

@ -1245,15 +1245,12 @@
Module = Default
; The XmlRpcGroups implementation can be used against the publically available service
; that I have made available for testing. Your group data is not guarenteed safe
; or available if you use this service, but it's available now and seems to work.
; The PHP code for the service is available from the Flotsam project for you to deploy
; The PHP code for the server is available from the Flotsam project for you to deploy
; to your own server. The Flotsam project is located at http://code.google.com/p/flotsam/
;
;Module = XmlRpcGroups
;XmlRpcServiceURL = http://osflotsam.org/xmlrpc.php
;XmlRpcServiceURL = http://yourxmlrpcserver.com/xmlrpc.php
;XmlRpcServiceReadKey = 1234
;XmlRpcServiceWriteKey = 1234