From 57c325540c33af1c46d2af13c326548ead5878e9 Mon Sep 17 00:00:00 2001 From: Sean Dague Date: Mon, 20 Jul 2009 15:12:50 +0000 Subject: [PATCH] From: Rick Alther This patch fixes a problem in the RestXmlWriter where an exception may be thrown when ToString() is called. ToString() is closing the last tag prior to returning the string object, which it shouldn't do. People should be closing the XML tags and document properly and not rely on the ToString() side effect to do it for them. This is most noticeable if you hit the /regions/ and /regioninfo/ REST calls. If you are running r9579 or later, these calls will result in an error. --- OpenSim/ApplicationPlugins/Rest/RestXmlWriter.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/OpenSim/ApplicationPlugins/Rest/RestXmlWriter.cs b/OpenSim/ApplicationPlugins/Rest/RestXmlWriter.cs index f27fd64ac3..9abb0c882e 100644 --- a/OpenSim/ApplicationPlugins/Rest/RestXmlWriter.cs +++ b/OpenSim/ApplicationPlugins/Rest/RestXmlWriter.cs @@ -63,7 +63,6 @@ namespace OpenSim.ApplicationPlugins.Rest public override string ToString() { - WriteEndElement(); Flush(); Close(); return m_sw.ToString();