Backup is now optional on classes

* Removed unused BackUp method on EntityBase
* Added overridable InSceneBackup property on SceneObjectGroup
* Refactored out AttachToBackup and DetachFromBackup
* Normalized namespace OpenSim.DataStore.MonoSqliteStorage to OpenSim.DataStore.MonoSqlite

OpenSim/Region/Environment/Scenes/EntityBase.cs

@@ -108,13 +108,6 @@ namespace OpenSim.Region.Environment.Scenes
             }
         }
 
-        /// <summary>
-        /// Called at a set interval to inform entities that they should back themsleves up to the DB 
-        /// </summary>
-        public virtual void BackUp()
-        {
-        }
-
         /// <summary>
         /// Copies the entity
         /// </summary>

OpenSim/Region/Environment/Scenes/SceneObjectGroup.cs

@@ -149,6 +149,15 @@ namespace OpenSim.Region.Environment.Scenes
         /// saying what prim(s) that user has selected. 
         /// </summary>
         protected bool m_isSelected = false;
+
+        protected virtual bool InSceneBackup
+        {
+            get
+            {
+                return true;
+            }
+        }
+
         public bool IsSelected
         {
             get { return m_isSelected; }
@@ -218,10 +227,20 @@ namespace OpenSim.Region.Environment.Scenes
             this.m_rootPart.ParentID = 0;
             this.m_rootPart.RegionHandle = m_regionHandle;
             this.UpdateParentIDs();
-            m_scene.EventManager.OnBackup += this.ProcessBackup;
+
+            AttachToBackup();
+
             this.ScheduleGroupForFullUpdate();
         }
 
+        private void AttachToBackup()
+        {
+            if (InSceneBackup)
+            {
+                m_scene.EventManager.OnBackup += this.ProcessBackup;
+            }
+        }
+
         /// <summary>
         /// 
         /// </summary>
@@ -243,7 +262,8 @@ namespace OpenSim.Region.Environment.Scenes
             SceneObjectPart newPart = new SceneObjectPart(m_regionHandle, this, ownerID, localID, shape, pos, rootOffset);
             this.m_parts.Add(newPart.UUID, newPart);
             this.SetPartAsRoot(newPart);
-            m_scene.EventManager.OnBackup += this.ProcessBackup;
+
+            AttachToBackup();
         }
         #endregion
 
@@ -307,7 +327,8 @@ namespace OpenSim.Region.Environment.Scenes
             }
             dupe.UpdateParentIDs();
 
-            m_scene.EventManager.OnBackup += dupe.ProcessBackup;
+            dupe.AttachToBackup();
+            
             return dupe;
         }
 
@@ -523,13 +544,19 @@ namespace OpenSim.Region.Environment.Scenes
                 }
             }
 
-            m_scene.EventManager.OnBackup -= objectGroup.ProcessBackup;
+            DetachFromBackup(objectGroup);
+
             m_scene.DeleteEntity(objectGroup.UUID);
 
             objectGroup.DeleteParts();
             this.ScheduleGroupForFullUpdate();
         }
 
+        private void DetachFromBackup(SceneObjectGroup objectGroup)
+        {
+            m_scene.EventManager.OnBackup -= objectGroup.ProcessBackup;
+        }
+
 
         private void LinkNonRootPart(SceneObjectPart part, Vector3 oldGroupPosition, Quaternion oldGroupRotation)
         {
@@ -583,7 +610,7 @@ namespace OpenSim.Region.Environment.Scenes
             proper.ObjectData[0].FolderID = LLUUID.Zero;
             proper.ObjectData[0].FromTaskID = LLUUID.Zero;
             proper.ObjectData[0].GroupID = LLUUID.Zero;
-            proper.ObjectData[0].InventorySerial = (short) this.m_rootPart.InventorySerial;
+            proper.ObjectData[0].InventorySerial = (short)this.m_rootPart.InventorySerial;
             proper.ObjectData[0].LastOwnerID = this.m_rootPart.LastOwnerID;
             proper.ObjectData[0].ObjectID = this.UUID;
             proper.ObjectData[0].OwnerID = this.m_rootPart.OwnerID;
@@ -1077,7 +1104,7 @@ namespace OpenSim.Region.Environment.Scenes
         public void SetScene(Scene scene)
         {
             m_scene = scene;
-            m_scene.EventManager.OnBackup += this.ProcessBackup;
+            AttachToBackup();
         }
 
         /// <summary>
@@ -1153,7 +1180,7 @@ namespace OpenSim.Region.Environment.Scenes
 
         public void DeleteGroup()
         {
-            m_scene.EventManager.OnBackup -= this.ProcessBackup;
+            DetachFromBackup( this );
             foreach (SceneObjectPart part in this.m_parts.Values)
             {
                 List<ScenePresence> avatars = this.RequestSceneAvatars();

OpenSim/Region/Storage/OpenSim.DataStore.MonoSqlite/MonoSqliteDataStore.cs

@@ -1,25 +1,15 @@
 using System;
 using System.Collections.Generic;
-using System.Text;
+using System.Data;
-using System.Xml;
+using libsecondlife;
-using System.Xml.Serialization;
+using Mono.Data.SqliteClient;
-using System.IO;
-
-using OpenSim.Region.Environment.Scenes;
-using OpenSim.Region.Environment.LandManagement;
-using OpenSim.Region.Environment;
-using OpenSim.Region.Environment.Interfaces;
 using OpenSim.Framework.Console;
 using OpenSim.Framework.Types;
-using OpenSim.Framework.Utilities;
+using OpenSim.Region.Environment.Interfaces;
-using libsecondlife;
+using OpenSim.Region.Environment.LandManagement;
+using OpenSim.Region.Environment.Scenes;
 
-using System.Data;
+namespace OpenSim.DataStore.MonoSqlite
-using System.Data.SqlTypes;
-
-using Mono.Data.SqliteClient;
-
-namespace OpenSim.DataStore.MonoSqliteStorage
 {
     public class MonoSqliteDataStore : IRegionDataStore
     {