* refactor: make startup a template method

OpenSim/Framework/Servers/BaseOpenSimServer.cs

@@ -95,6 +95,11 @@ namespace OpenSim.Framework.Servers
             ThreadTracker.Add(Thread.CurrentThread);
         }
         
+        /// <summary>
+        /// Must be overriden by child classes for their own server specific startup behaviour.
+        /// </summary>
+        protected abstract void StartupSpecific();
+
         /// <summary>
         /// Print statistics to the logfile, if they are active
         /// </summary>
@@ -207,6 +212,8 @@ namespace OpenSim.Framework.Servers
             EnhanceVersionInformation();
             
             m_log.Info("[STARTUP]: Version: " + m_version + "\n");
+            
+            StartupSpecific();
         }
 
         /// <summary>

OpenSim/Grid/AssetServer/Main.cs

@@ -80,10 +80,8 @@ namespace OpenSim.Grid.AssetServer
             MainConsole.Instance = m_console;
         }
 
-        public override void Startup()
+        protected override void StartupSpecific()
         {
-            base.Startup();
-
             AssetConfig config = new AssetConfig("ASSET SERVER", (Path.Combine(Util.configDir(), "AssetServer_Config.xml")));
 
             m_log.Info("[ASSET]: Setting up asset DB");

OpenSim/Grid/GridServer/GridServerBase.cs

@@ -73,10 +73,8 @@ namespace OpenSim.Grid.GridServer
             }
         }
 
-        public override void Startup()
+        protected override void StartupSpecific()
         {
-            base.Startup();
-
             m_config = new GridConfig("GRID SERVER", (Path.Combine(Util.configDir(), "GridServer_Config.xml")));
 
             SetupGridManager();

OpenSim/Grid/InventoryServer/Main.cs

@@ -62,10 +62,8 @@ namespace OpenSim.Grid.InventoryServer
             MainConsole.Instance = m_console;
         }
 
-        public override void Startup()
+        protected override void StartupSpecific()
         {
-            base.Startup();
-
             InventoryConfig config = new InventoryConfig(LogName, (Path.Combine(Util.configDir(), "InventoryServer_Config.xml")));
 
             m_inventoryService = new GridInventoryService(config.UserServerURL);

OpenSim/Grid/MessagingServer/Main.cs

@@ -56,8 +56,6 @@ namespace OpenSim.Grid.MessagingServer
 
             m_log.Info("Launching MessagingServer...");
 
-
-
             OpenMessage_Main messageserver = new OpenMessage_Main();
 
             messageserver.Startup();
@@ -80,10 +78,8 @@ namespace OpenSim.Grid.MessagingServer
             }
         }
 
-        public override void Startup()
+        protected override void StartupSpecific()
         {
-            base.Startup();
-
             Cfg = new MessageServerConfig("MESSAGING SERVER", (Path.Combine(Util.configDir(), "MessagingServer_Config.xml")));
 
             m_log.Info("[REGION]: Starting HTTP process");

OpenSim/Grid/UserServer/Main.cs

@@ -88,10 +88,8 @@ namespace OpenSim.Grid.UserServer
             }
         }
 
-        public override void Startup()
+        protected override void StartupSpecific()
         {
-            base.Startup();
-
             Cfg = new UserConfig("USER SERVER", (Path.Combine(Util.configDir(), "UserServer_Config.xml")));
 
             m_stats = StatsManager.StartCollectingUserStats();

OpenSim/Region/Application/OpenSimBase.cs

@@ -363,9 +363,9 @@ namespace OpenSim
         /// <summary>
         /// Performs initialisation of the scene, such as loading configuration from disk.
         /// </summary>
-        public override void Startup()
+        protected override void StartupSpecific()
         {
-            base.Startup();
+            base.StartupSpecific();
             
             m_stats = StatsManager.StartCollectingSimExtraStats();
             

OpenSim/Region/ClientStack/LindenUDP/LLPacketQueue.cs

@@ -44,6 +44,9 @@ namespace OpenSim.Region.ClientStack.LindenUDP
         private static readonly log4net.ILog m_log
             = log4net.LogManager.GetLogger(System.Reflection.MethodBase.GetCurrentMethod().DeclaringType);
 
+        /// <summary>
+        /// Is throttling enabled at all?
+        /// </summary>
         private bool m_enabled = true;
 
         private OpenSim.Framework.BlockingQueue<LLQueItem> SendQueue;

OpenSim/Region/ClientStack/RegionApplicationBase.cs

@@ -71,10 +71,8 @@ namespace OpenSim.Region.ClientStack
             get { return m_sceneManager; }
         }
 
-        public override void Startup()
+        protected override void StartupSpecific()
         {
-            base.Startup();
-
             m_storageManager = CreateStorageManager(m_storageConnectionString, m_estateConnectionString);
 
             m_clientStackManager = CreateClientStackManager();