From 72db6f76b5dc373d3178fbf09d04d385d63bc52d Mon Sep 17 00:00:00 2001
From: UbitUmarov <ajlduarte@sapo.pt>
Date: Sat, 24 Jun 2017 05:22:02 +0100
Subject: [PATCH] remove a DynamicTexture leak, make it actually return the new
 texture ID to ossl, do delete previus texture from local cache if
 temporary,at least on same cases...  but still very broken..

---
 .../DynamicTexture/DynamicTextureModule.cs    | 25 ++++++++++++-------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/OpenSim/Region/CoreModules/Scripting/DynamicTexture/DynamicTextureModule.cs b/OpenSim/Region/CoreModules/Scripting/DynamicTexture/DynamicTextureModule.cs
index c369d87b05..82596ca4ae 100644
--- a/OpenSim/Region/CoreModules/Scripting/DynamicTexture/DynamicTextureModule.cs
+++ b/OpenSim/Region/CoreModules/Scripting/DynamicTexture/DynamicTextureModule.cs
@@ -135,16 +135,15 @@ namespace OpenSim.Region.CoreModules.Scripting.DynamicTexture
                         m_reuseableDynamicTextures.Store(
                             GenerateReusableTextureKey(texture.InputCommands, texture.InputParams), newTextureID);
                     }
+                    updater.newTextureID = newTextureID;
                 }
-            }
 
-            if (updater.UpdateTimer == 0)
-            {
-                lock (Updaters)
+                if (updater.UpdateTimer == 0)
                 {
-                    if (!Updaters.ContainsKey(updater.UpdaterID))
+                    lock (Updaters)
                     {
-                        Updaters.Remove(updater.UpdaterID);
+                        if (Updaters.ContainsKey(updater.UpdaterID))
+                            Updaters.Remove(updater.UpdaterID);
                     }
                 }
             }
@@ -213,7 +212,7 @@ namespace OpenSim.Region.CoreModules.Scripting.DynamicTexture
                 }
 
                 RenderPlugins[contentType].AsyncConvertUrl(updater.UpdaterID, url, extraParams);
-                return updater.UpdaterID;
+                return updater.newTextureID;
             }
             return UUID.Zero;
         }
@@ -314,7 +313,7 @@ namespace OpenSim.Region.CoreModules.Scripting.DynamicTexture
                 updater.UpdatePart(part, (UUID)objReusableTextureUUID);
             }
 
-            return updater.UpdaterID;
+            return updater.newTextureID;
         }
 
         private string GenerateReusableTextureKey(string data, string extraParams)
@@ -411,6 +410,7 @@ namespace OpenSim.Region.CoreModules.Scripting.DynamicTexture
             public int Face;
             public int Disp;
             public string Url;
+            public UUID newTextureID;
 
             public DynamicTextureUpdater()
             {
@@ -445,7 +445,14 @@ namespace OpenSim.Region.CoreModules.Scripting.DynamicTexture
                     {
                         try
                         {
-                            Primitive.TextureEntryFace texface = tmptex.CreateFace((uint)Face);
+                            Primitive.TextureEntryFace texface = tmptex.GetFace((uint)Face);
+                            if(texface == null)
+                                tmptex.GetFace((uint)Face);
+                            else
+                            {
+                                if(texface.TextureID != null && texface.TextureID != UUID.Zero)
+                                    oldID = texface.TextureID;
+                            }
                             texface.TextureID = textureID;
                             tmptex.FaceTextures[Face] = texface;
                         }