From 786fd3534dc169b3936bf3d8fd7cade41d28db96 Mon Sep 17 00:00:00 2001 From: Charles Krinke Date: Thu, 19 Jun 2008 21:00:09 +0000 Subject: [PATCH] Mantis#1572. Thank you kindly, Lulurun for a patch that addresses: In function "ReadInExtraParamsBytes", parameter "data" is used without a boundary check. if data.Length==0, an "out of index" exception will be thrown. --- OpenSim/Framework/PrimitiveBaseShape.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/OpenSim/Framework/PrimitiveBaseShape.cs b/OpenSim/Framework/PrimitiveBaseShape.cs index aa88717515..1f5428b382 100644 --- a/OpenSim/Framework/PrimitiveBaseShape.cs +++ b/OpenSim/Framework/PrimitiveBaseShape.cs @@ -450,7 +450,11 @@ namespace OpenSim.Framework bool lGotSculpt = false; int i = 0; - byte extraParamCount = data[i++]; + byte extraParamCount = 0; + if (data.Length > 0) + { + extraParamCount = data[i++]; + } for (int k = 0; k < extraParamCount; k++) @@ -625,4 +629,4 @@ namespace OpenSim.Framework return data; } } -} \ No newline at end of file +}