From 8026608621cca5d07bf19db1d2024153c99aae0c Mon Sep 17 00:00:00 2001 From: justincc Date: Wed, 23 Dec 2009 15:15:06 +0000 Subject: [PATCH] Disabling logging of xmlrpc request parsing failures, since this currently results in false positivies --- .../Servers/HttpServer/BaseHttpServer.cs | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs b/OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs index 66d6b0cc57..1e203f3617 100644 --- a/OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs +++ b/OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs @@ -704,9 +704,20 @@ namespace OpenSim.Framework.Servers.HttpServer } catch (XmlException e) { - m_log.WarnFormat( - "[BASE HTTP SERVER]: Ignoring XMLRPC request from {0} due to deserialization exception {1} {2}", - request.RemoteIPEndPoint, e.Message, e.StackTrace); +// Don't log this for now since HandleXmlRpcRequests() acts as the final processing catch all for all requests +// that aren't dealt with by another method. Enabling can result in false positives, for instance +// +// 14:59:12 - [BASE HTTP SERVER]: Ignoring XMLRPC request from 80.175.122.121:20478 +// due to deserialization exception Data at the root level is invalid. Line 1, pos +// ition 1. at System.Xml.XmlTextReaderImpl.Throw(Exception e) +// 14:59:12 - [BASE HTTP SERVER]: Request body auth_token=x3EA9wjAwTjuJwawE6PGqhQ%3 +// D%3D%3A0%3A9303959503950%3A%3A +// +// on the region simulator when the client makes a request that we don't deal with +// +// m_log.WarnFormat( +// "[BASE HTTP SERVER]: Ignoring XMLRPC request from {0} due to deserialization exception {1} {2}", +// request.RemoteIPEndPoint, e.Message, e.StackTrace); } if (xmlRprcRequest != null)