Convert SendKillObject to take a list of uint rather than sending one

packet per prim. More to come as we change to make use of this.

OpenSim/Framework/IClientAPI.cs

@@ -1046,7 +1046,7 @@ namespace OpenSim.Framework
         /// </summary>
         /// <param name="regionHandle"></param>
         /// <param name="localID"></param>
-        void SendKillObject(ulong regionHandle, uint localID);
+        void SendKillObject(ulong regionHandle, List<uint> localID);
 
         void SendAnimations(UUID[] animID, int[] seqs, UUID sourceAgentId, UUID[] objectIDs);
         void SendRegionHandshake(RegionInfo regionInfo, RegionHandshakeArgs args);

OpenSim/Region/ClientStack/Linden/UDP/LLClientView.cs

@@ -1531,38 +1531,49 @@ namespace OpenSim.Region.ClientStack.LindenUDP
             OutPacket(pc, ThrottleOutPacketType.Unknown);
         }
 
-        public void SendKillObject(ulong regionHandle, uint localID)
+        public void SendKillObject(ulong regionHandle, List<uint> localIDs)
         {
 //            m_log.DebugFormat("[CLIENT]: Sending KillObjectPacket to {0} for {1} in {2}", Name, localID, regionHandle);
 
             KillObjectPacket kill = (KillObjectPacket)PacketPool.Instance.GetPacket(PacketType.KillObject);
             // TODO: don't create new blocks if recycling an old packet
-            kill.ObjectData = new KillObjectPacket.ObjectDataBlock[1];
+            kill.ObjectData = new KillObjectPacket.ObjectDataBlock[localIDs.Count];
-            kill.ObjectData[0] = new KillObjectPacket.ObjectDataBlock();
+            for (int i = 0 ; i < localIDs.Count ; i++ )
-            kill.ObjectData[0].ID = localID;
+            {
+                kill.ObjectData[i] = new KillObjectPacket.ObjectDataBlock();
+                kill.ObjectData[i].ID = localIDs[i];
+            }
             kill.Header.Reliable = true;
             kill.Header.Zerocoded = true;
 
-            if (m_scene.GetScenePresence(localID) == null)
+            lock (m_killRecord)
             {
-                // We must lock for both manipulating the kill record and sending the packet, in order to avoid a race
+                if (localIDs.Count == 1)
-                // condition where a kill can be processed before an out-of-date update for the same object.
-                lock (m_killRecord)
                 {
-                    m_killRecord.Add(localID);
+                    if (m_scene.GetScenePresence(localIDs[0]) != null)
-                    
+                    {
-                    // The throttle queue used here must match that being used for updates.  Otherwise, there is a 
+                        OutPacket(kill, ThrottleOutPacketType.State);
-                    // chance that a kill packet put on a separate queue will be sent to the client before an existing
+                        return;
-                    // update packet on another queue.  Receiving updates after kills results in unowned and undeletable
+                    }
-                    // scene objects in a viewer until that viewer is relogged in.
+                    m_killRecord.Add(localIDs[0]);
-                    OutPacket(kill, ThrottleOutPacketType.Task);
+                }
+                else
+                {
+                    lock (m_entityUpdates.SyncRoot)
+                    {
+                        foreach (uint localID in localIDs)
+                            m_killRecord.Add(localID);
+                    }
                 }
             }
-            else
+
-            {
+            // The throttle queue used here must match that being used for
-                // OutPacket(kill, ThrottleOutPacketType.State);
+            // updates. Otherwise, there is a chance that a kill packet put
-                OutPacket(kill, ThrottleOutPacketType.Task);
+            // on a separate queue will be sent to the client before an
-            }
+            // existing update packet on another queue. Receiving updates
+            // after kills results in unowned and undeletable
+            // scene objects in a viewer until that viewer is relogged in.
+            OutPacket(kill, ThrottleOutPacketType.Task);
         }
 
         /// <summary>
@@ -11265,7 +11276,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP
                     {
                         // It's a ghost! tell the client to delete it from view.
                         simClient.SendKillObject(Scene.RegionInfo.RegionHandle,
-                                                 localId);
+                                                 new List<uint> { localId });
                     }
                     else
                     {

OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs

@@ -548,7 +548,7 @@ namespace OpenSim.Region.CoreModules.Avatar.Attachments
                 //
                 if (so.IsSelected)
                 {
-                    m_scene.SendKillObject(so.RootPart.LocalId);
+                    m_scene.SendKillObject(new List<uint> { so.RootPart.LocalId });
                 }
 
                 so.IsSelected = false; // fudge....

OpenSim/Region/CoreModules/Framework/EntityTransfer/EntityTransferModule.cs

@@ -570,7 +570,7 @@ namespace OpenSim.Region.CoreModules.Framework.EntityTransfer
 
         protected void KillEntity(Scene scene, uint localID)
         {
-            scene.SendKillObject(localID);
+            scene.SendKillObject(new List<uint> { localID });
         }
 
         protected virtual GridRegion GetFinalDestination(GridRegion region)

OpenSim/Region/Framework/Scenes/Scene.cs

@@ -3102,7 +3102,7 @@ namespace OpenSim.Region.Framework.Scenes
                     delegate(IClientAPI client)
                     {
                         //We can safely ignore null reference exceptions.  It means the avatar is dead and cleaned up anyway
-                        try { client.SendKillObject(avatar.RegionHandle, avatar.LocalId); }
+                        try { client.SendKillObject(avatar.RegionHandle, new List<uint> { avatar.LocalId }); }
                         catch (NullReferenceException) { }
                     });
 
@@ -3161,28 +3161,24 @@ namespace OpenSim.Region.Framework.Scenes
 
         #region Entities
 
-        public void SendKillObject(uint localID)
+        public void SendKillObject(List<uint> localIDs)
         {
-            SceneObjectPart part = GetSceneObjectPart(localID);
+            List<uint> deleteIDs = new List<uint>();
-            UUID attachedAvatar = UUID.Zero;
 
-            if (part != null) // It is a prim
+            foreach (uint localID in localIDs)
             {
-                if (!part.ParentGroup.IsDeleted) // Valid
+                SceneObjectPart part = GetSceneObjectPart(localID);
+                if (part != null) // It is a prim
                 {
-                    if (part.ParentGroup.RootPart != part) // Child part
+                    if (part.ParentGroup != null && !part.ParentGroup.IsDeleted) // Valid
-                        return;
+                    {
-
+                        if (part.ParentGroup.RootPart != part) // Child part
-                    if (part.ParentGroup.IsAttachment && part.ParentGroup.AttachmentPoint >= 31 && part.ParentGroup.AttachmentPoint <= 38)
+                            continue;
-                        attachedAvatar = part.ParentGroup.AttachedAvatar;
+                    }
                 }
+                deleteIDs.Add(localID);
             }
-
+            ForEachClient(delegate(IClientAPI client) { client.SendKillObject(m_regionHandle, deleteIDs); });
-            ForEachClient(delegate(IClientAPI client)
-            {
-                if (attachedAvatar == UUID.Zero || attachedAvatar == client.AgentId)
-                    client.SendKillObject(m_regionHandle, localID);
-            });
         }
 
         #endregion
@@ -3200,7 +3196,6 @@ namespace OpenSim.Region.Framework.Scenes
             //m_sceneGridService.OnChildAgentUpdate += IncomingChildAgentDataUpdate;
             //m_sceneGridService.OnRemoveKnownRegionFromAvatar += HandleRemoveKnownRegionsFromAvatar;
             m_sceneGridService.OnLogOffUser += HandleLogOffUserFromGrid;
-            m_sceneGridService.KiPrimitive += SendKillObject;
             m_sceneGridService.OnGetLandData += GetLandData;
         }
 
@@ -3209,7 +3204,6 @@ namespace OpenSim.Region.Framework.Scenes
         /// </summary>
         public void UnRegisterRegionWithComms()
         {
-            m_sceneGridService.KiPrimitive -= SendKillObject;
             m_sceneGridService.OnLogOffUser -= HandleLogOffUserFromGrid;
             //m_sceneGridService.OnRemoveKnownRegionFromAvatar -= HandleRemoveKnownRegionsFromAvatar;
             //m_sceneGridService.OnChildAgentUpdate -= IncomingChildAgentDataUpdate;

OpenSim/Region/Framework/Scenes/SceneCommunicationService.cs

@@ -44,8 +44,6 @@ using GridRegion = OpenSim.Services.Interfaces.GridRegion;
 
 namespace OpenSim.Region.Framework.Scenes
 {
-    public delegate void KiPrimitiveDelegate(uint localID);
-
     public delegate void RemoveKnownRegionsFromAvatarList(UUID avatarID, List<ulong> regionlst);
 
     /// <summary>
@@ -113,8 +111,6 @@ namespace OpenSim.Region.Framework.Scenes
 //        private LogOffUser handlerLogOffUser = null;
 //        private GetLandData handlerGetLandData = null; // OnGetLandData
 
-        public KiPrimitiveDelegate KiPrimitive;
-
         public SceneCommunicationService()
         {
         }

OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs

@@ -1162,7 +1162,7 @@ namespace OpenSim.Region.Framework.Scenes
                         {
                             if (!IsAttachment || (AttachedAvatar == avatar.ControllingClient.AgentId) || 
                                 (AttachmentPoint < 31) || (AttachmentPoint > 38))
-                                avatar.ControllingClient.SendKillObject(m_regionHandle, part.LocalId);
+                                avatar.ControllingClient.SendKillObject(m_regionHandle, new List<uint> { part.LocalId });
                         }
                     }
                 });

OpenSim/Region/OptionalModules/Agent/InternetRelayClientView/Server/IRCClientView.cs

@@ -934,7 +934,7 @@ namespace OpenSim.Region.OptionalModules.Agent.InternetRelayClientView.Server
             
         }
 
-        public void SendKillObject(ulong regionHandle, uint localID)
+        public void SendKillObject(ulong regionHandle, List<uint> localID)
         {
             
         }

OpenSim/Region/OptionalModules/World/NPC/NPCAvatar.cs

@@ -520,7 +520,7 @@ namespace OpenSim.Region.OptionalModules.World.NPC
 
         }
 
-        public virtual void SendKillObject(ulong regionHandle, uint localID)
+        public virtual void SendKillObject(ulong regionHandle, List<uint> localID)
         {
         }
 

OpenSim/Tests/Common/Mock/TestClient.cs

@@ -487,7 +487,7 @@ namespace OpenSim.Tests.Common.Mock
 
         }
 
-        public virtual void SendKillObject(ulong regionHandle, uint localID)
+        public virtual void SendKillObject(ulong regionHandle, List<uint> localID)
         {
         }