OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improved line map heuristics. 

If the C# column can't be found in the positionMap (but the line can),
use the map immediately after it while correcting for the offset,
unless that results in an LSL position before the previous LSL position
in the positionMap.

The idea behind this heuristic is that in most, if not all cases C#
consumes more characters than LSL (for example LSL_Types.LSLInteger
instead of just 'integer').

Thus if the distance between the columns of two markers differ in
the C# and LSL file, the distance in the C# file will be larger.
Moreover, we can assume that every time this happens we will have
a marker at the beginning of the longer 'keyword', because those
keywords were generated by us in the first place.

For example:

C#:     LSL_Types.LSLInteger f2(LSL_Types.LSLString s)
        ^                       ^
        1                       2

will always have markers at the beginning of the long keywords
'LSL_Types.LSLInteger' and 'LSL_Types.LSLString'.
If an error is generated in between (for example at the beginning
of the function name 'f2') then the correct position is found
by using an offset relative to 2 rather than 1.

Note that a case where this isn't working correctly is
when the user adds extra spaces. For example:

LSL:   integer f2(    string s)

would still use the start of 'string' as reference and
then go backwards 3 characters only because the corresponding
C# still looks like

C#:     LSL_Types.LSLInteger f2(LSL_Types.LSLString s)
                             ^  ^
			     only 3 chars difference

and the reported error at 'f2' would be here:

LSL:   integer f2(    string s)
                   ^

This can only be fixed by generating a mapping for 'f2' itself, or
generating a mapping whenever the amount of spaces is changed.
bullet-2.82
Aleric Inglewood 2014-05-28 18:51:17 +02:00 committed by Justin Clark-Casey (justincc)
parent 3fe9c7c49d
commit c90b986d8b
2 changed files with 80 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
OpenSim/Region/ScriptEngine/Shared/CodeTools/Compiler.cs
View File

@ -724,13 +724,13 @@ namespace SecondLife
return assembly; return assembly;
} }
private class kvpSorter : IComparer<KeyValuePair<int, int>> private class kvpSorter : IComparer<KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>>>
{ {
public int Compare(KeyValuePair<int, int> a, public int Compare(KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>> a,
KeyValuePair<int, int> b) KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>> b)
{ {
int kc = a.Key.CompareTo(b.Key); int kc = a.Key.Key.CompareTo(b.Key.Key);
return (kc != 0) ? kc : a.Value.CompareTo(b.Value); return (kc != 0) ? kc : a.Key.Value.CompareTo(b.Key.Value);
} }
} }
@ -747,24 +747,48 @@ namespace SecondLife
out ret)) out ret))
return ret; return ret;
List<KeyValuePair<int, int>> sorted = var sorted = new List<KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>>>(positionMap);
new List<KeyValuePair<int, int>>(positionMap.Keys);
sorted.Sort(new kvpSorter()); sorted.Sort(new kvpSorter());
int l = sorted[0].Key; int l = 1;
int c = sorted[0].Value; int c = 1;
int pl = 1;
foreach (KeyValuePair<int, int> cspos in sorted) foreach (KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>> posmap in sorted)
{ {
if (cspos.Key >= line && //m_log.DebugFormat("[Compiler]: Scanning line map {0},{1} --> {2},{3}", posmap.Key.Key, posmap.Key.Value, posmap.Value.Key, posmap.Value.Value);
!(cspos.Key == line && cspos.Value <= col)) int nl = posmap.Value.Key + line - posmap.Key.Key; // New, translated LSL line and column.
break; int nc = posmap.Value.Value + col - posmap.Key.Value;
l = cspos.Key; // Keep going until we find the first point passed line,col.
c = cspos.Value; if (posmap.Key.Key > line)
{
//m_log.DebugFormat("[Compiler]: Line is larger than requested {0},{1}, returning {2},{3}", line, col, l, c);
if (pl < line)
{
//m_log.DebugFormat("[Compiler]: Previous line ({0}) is less than requested line ({1}), setting column to 1.", pl, line);
c = 1;
} }
positionMap.TryGetValue(new KeyValuePair<int, int>(l, c), out ret); break;
return ret; }
if (posmap.Key.Key == line && posmap.Key.Value > col)
{
// Never move l,c backwards.
if (nl > l || (nl == l && nc > c))
{
//m_log.DebugFormat("[Compiler]: Using offset relative to this: {0} + {1} - {2}, {3} + {4} - {5} = {6}, {7}",
// posmap.Value.Key, line, posmap.Key.Key, posmap.Value.Value, col, posmap.Key.Value, nl, nc);
l = nl;
c = nc;
}
//m_log.DebugFormat("[Compiler]: Column is larger than requested {0},{1}, returning {2},{3}", line, col, l, c);
break;
}
pl = posmap.Key.Key;
l = posmap.Value.Key;
c = posmap.Value.Value;
}
return new KeyValuePair<int, int>(l, c);
} }
string ReplaceTypes(string message) string ReplaceTypes(string message)

58
OpenSim/Tools/Compiler/Program.cs
View File

@ -255,13 +255,13 @@ namespace OpenSim.Tools.LSL.Compiler
return FindErrorPosition(line, col, null); return FindErrorPosition(line, col, null);
} }
private class kvpSorter : IComparer<KeyValuePair<int, int>> private class kvpSorter : IComparer<KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>>>
{ {
public int Compare(KeyValuePair<int, int> a, public int Compare(KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>> a,
KeyValuePair<int, int> b) KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>> b)
{ {
int kc = a.Key.CompareTo(b.Key); int kc = a.Key.Key.CompareTo(b.Key.Key);
return (kc != 0) ? kc : a.Value.CompareTo(b.Value); return (kc != 0) ? kc : a.Key.Value.CompareTo(b.Key.Value);
} }
} }
@ -278,24 +278,48 @@ namespace OpenSim.Tools.LSL.Compiler
out ret)) out ret))
return ret; return ret;
List<KeyValuePair<int, int>> sorted = var sorted = new List<KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>>>(positionMap);
new List<KeyValuePair<int, int>>(positionMap.Keys);
sorted.Sort(new kvpSorter()); sorted.Sort(new kvpSorter());
int l = sorted[0].Key; int l = 1;
int c = sorted[0].Value; int c = 1;
int pl = 1;
foreach (KeyValuePair<int, int> cspos in sorted) foreach (KeyValuePair<KeyValuePair<int, int>, KeyValuePair<int, int>> posmap in sorted)
{ {
if (cspos.Key >= line && //m_log.DebugFormat("[Compiler]: Scanning line map {0},{1} --> {2},{3}", posmap.Key.Key, posmap.Key.Value, posmap.Value.Key, posmap.Value.Value);
!(cspos.Key == line && cspos.Value <= col)) int nl = posmap.Value.Key + line - posmap.Key.Key; // New, translated LSL line and column.
break; int nc = posmap.Value.Value + col - posmap.Key.Value;
l = cspos.Key; // Keep going until we find the first point passed line,col.
c = cspos.Value; if (posmap.Key.Key > line)
{
//m_log.DebugFormat("[Compiler]: Line is larger than requested {0},{1}, returning {2},{3}", line, col, l, c);
if (pl < line)
{
//m_log.DebugFormat("[Compiler]: Previous line ({0}) is less than requested line ({1}), setting column to 1.", pl, line);
c = 1;
} }
positionMap.TryGetValue(new KeyValuePair<int, int>(l, c), out ret); break;
return ret; }
if (posmap.Key.Key == line && posmap.Key.Value > col)
{
// Never move l,c backwards.
if (nl > l || (nl == l && nc > c))
{
//m_log.DebugFormat("[Compiler]: Using offset relative to this: {0} + {1} - {2}, {3} + {4} - {5} = {6}, {7}",
// posmap.Value.Key, line, posmap.Key.Key, posmap.Value.Value, col, posmap.Key.Value, nl, nc);
l = nl;
c = nc;
}
//m_log.DebugFormat("[Compiler]: Column is larger than requested {0},{1}, returning {2},{3}", line, col, l, c);
break;
}
pl = posmap.Key.Key;
l = posmap.Value.Key;
c = posmap.Value.Value;
}
return new KeyValuePair<int, int>(l, c);
} }
} }
} }