Remove unused and broken OffsetRotation from ScenePresence

OpenSim/Region/Framework/Scenes/ScenePresence.cs

@@ -199,7 +199,6 @@ namespace OpenSim.Region.Framework.Scenes
         //PauPaw:Proper PID Controler for autopilot************
         public bool MovingToTarget { get; private set; }
         public Vector3 MoveToPositionTarget { get; private set; }
-        private Quaternion m_offsetRotation = new Quaternion(0.0f, 0.0f, 0.0f, 1.0f);
 
         /// <summary>
         /// Controls whether an avatar automatically moving to a target will land when it gets there (if flying).
@@ -612,39 +611,15 @@ namespace OpenSim.Region.Framework.Scenes
             }
         }
 
-        public Quaternion OffsetRotation
-        {
-            get { return m_offsetRotation; }
-            set { m_offsetRotation = value; }
-        }
         private Quaternion m_bodyRot = Quaternion.Identity;
 
         public Quaternion Rotation
         {
-            get {
+            get { return m_bodyRot; }
-                if (m_parentID != 0)
+            set
             {
-                    if (m_offsetRotation != null)
-                    {
-                        return m_offsetRotation;
-                    }
-                    else
-                    {
-                        return new Quaternion(0.0f, 0.0f, 0.0f, 1.0f);
-                    }
-                    
-                }
-                else
-                {
-                    return m_bodyRot;
-                }
-            }
-            set { 
                 m_bodyRot = value;
-                if (m_parentID != 0)
+//                m_log.DebugFormat("[SCENE PRESENCE]: Body rot for {0} set to {1}", Name, m_bodyRot);
-                {
-                    m_offsetRotation = new Quaternion(0.0f, 0.0f, 0.0f, 1.0f);
-                }
             }
         }
 

OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs

@@ -7564,7 +7564,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                             return;
                         LSL_Rotation r;
                         r = rules.GetQuaternionItem(idx++);
-                        av.OffsetRotation = new Quaternion((float)r.x, (float)r.y, (float)r.z, (float)r.s);
+                        av.Rotation = new Quaternion((float)r.x, (float)r.y, (float)r.z, (float)r.s);
                         av.SendAvatarDataToAllAgents();
                         break;
                 }