OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable the "show threadpool calls active" console command for now. 

Whilst this can be very useful to identify threads held too long by incoming packet processing,
it can also be very misleading as the count updates are not atomic (race conditions lead to growth in numbers over time).
This could be solved by making the counts volatile but I don't currently have time to assess the performance impact, though it's almost certainly negligible.
If anybody else wants to do that and re-enable this command then please feel free.
fsassets
Justin Clark-Casey (justincc) 2015-05-12 19:54:25 +01:00
parent aefed57158
commit d52f58a733
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
OpenSim/Framework/Servers/ServerBase.cs
View File

@ -292,11 +292,11 @@ namespace OpenSim.Framework.Servers
+ " 3 = full stack trace, including common threads\n", + " 3 = full stack trace, including common threads\n",
HandleDebugThreadpoolLevel); HandleDebugThreadpoolLevel);
m_console.Commands.AddCommand( // m_console.Commands.AddCommand(
"Debug", false, "show threadpool calls active", // "Debug", false, "show threadpool calls active",
"show threadpool calls active", // "show threadpool calls active",
"Show details about threadpool calls that are still active (currently waiting or in progress)", // "Show details about threadpool calls that are still active (currently waiting or in progress)",
HandleShowThreadpoolCallsActive); // HandleShowThreadpoolCallsActive);
m_console.Commands.AddCommand( m_console.Commands.AddCommand(
"Debug", false, "show threadpool calls complete", "Debug", false, "show threadpool calls complete",