OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ubMeshmerizer: add a few more try{} guards in file operations, etc

LSLKeyTest
UbitUmarov 2016-09-05 15:59:33 +01:00
parent 02ecff255d
commit d5dbcc8ad7
2 changed files with 50 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
OpenSim/Region/PhysicsModules/ubOdeMeshing/Mesh.cs
View File

@ -588,9 +588,9 @@ namespace OpenSim.Region.PhysicsModule.ubODEMeshing
Mesh mesh = new Mesh();
mesh.releaseBuildingMeshData();
BinaryReader br = new BinaryReader(st);
bool ok = true;
using(BinaryReader br = new BinaryReader(st))
{
try
{
mesh.m_vertexCount = br.ReadInt32();
@ -617,8 +617,7 @@ namespace OpenSim.Region.PhysicsModule.ubODEMeshing
{
ok = false;
}
br.Close();
}
if (ok)
{

39
OpenSim/Region/PhysicsModules/ubOdeMeshing/Meshmerizer.cs
View File

@ -60,7 +60,7 @@ namespace OpenSim.Region.PhysicsModule.ubODEMeshing
private bool m_Enabled = false;
public object diskLock = new object();
public static object diskLock = new object();
public bool doMeshFileCache = true;
@ -1426,13 +1426,13 @@ namespace OpenSim.Region.PhysicsModule.ubODEMeshing
{
if (File.Exists(filename))
{
FileStream stream = null;
try
{
stream = File.Open(filename, FileMode.Open, FileAccess.Read, FileShare.Read);
BinaryFormatter bformatter = new BinaryFormatter();
using(FileStream stream = File.Open(filename, FileMode.Open, FileAccess.Read, FileShare.Read))
{
// BinaryFormatter bformatter = new BinaryFormatter();
mesh = Mesh.FromStream(stream,key);
}
}
catch (Exception e)
@ -1443,14 +1443,18 @@ namespace OpenSim.Region.PhysicsModule.ubODEMeshing
filename, e.Message, e.StackTrace);
}
if (stream != null)
stream.Close();
try
{
if (mesh == null || !ok)
File.Delete(filename);
else
File.SetLastAccessTimeUtc(filename, DateTime.UtcNow);
}
catch
{
}
}
}
return mesh;
@ -1458,7 +1462,6 @@ namespace OpenSim.Region.PhysicsModule.ubODEMeshing
private void StoreToFileCache(AMeshKey key, Mesh mesh)
{
Stream stream = null;
bool ok = false;
// Make sure the target cache directory exists
@ -1476,7 +1479,7 @@ namespace OpenSim.Region.PhysicsModule.ubODEMeshing
Directory.CreateDirectory(dir);
}
stream = File.Open(filename, FileMode.Create);
using(Stream stream = File.Open(filename, FileMode.Create))
ok = mesh.ToStream(stream);
}
catch (IOException e)
@ -1487,16 +1490,18 @@ namespace OpenSim.Region.PhysicsModule.ubODEMeshing
ok = false;
}
if (stream != null)
stream.Close();
if (File.Exists(filename))
if (!ok && File.Exists(filename))
{
try
{
if (ok)
File.SetLastAccessTimeUtc(filename, DateTime.UtcNow);
else
File.Delete(filename);
}
catch (IOException e)
{
m_log.ErrorFormat(
"[MESH CACHE]: Failed to delete file {0}",filename);
}
}
}
}