From e515467c5e9a03de8d0df8e24d1ca70636f6e099 Mon Sep 17 00:00:00 2001
From: Melanie Thielker <melanie@t-data.com>
Date: Mon, 31 May 2010 19:00:02 +0200
Subject: [PATCH] Fix create selection getting overwritten by multiple updates
 for the same prim.

---
 OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs     | 4 ++--
 OpenSim/Region/Framework/Scenes/SceneGraph.cs            | 2 +-
 OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs      | 2 +-
 OpenSim/Region/Framework/Scenes/SceneObjectPart.cs       | 9 ++++++++-
 .../ScriptEngine/Shared/Api/Implementation/LSL_Api.cs    | 2 +-
 5 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs b/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
index 0945bce5ae..a516a54ca4 100644
--- a/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
+++ b/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs
@@ -4558,11 +4558,11 @@ namespace OpenSim.Region.ClientStack.LindenUDP
 
             if (recipientID == data.OwnerID)
             {
-                if ((data.Flags & PrimFlags.CreateSelected) != 0)
+                if (data.CreateSelected)
                 {
                     // Only send this flag once, then unset it
                     flags |= PrimFlags.CreateSelected;
-                    data.Flags &= ~PrimFlags.CreateSelected;
+                    data.CreateSelected = false;
                 }
             }
 
diff --git a/OpenSim/Region/Framework/Scenes/SceneGraph.cs b/OpenSim/Region/Framework/Scenes/SceneGraph.cs
index e923a92566..a02f614387 100644
--- a/OpenSim/Region/Framework/Scenes/SceneGraph.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneGraph.cs
@@ -1500,7 +1500,7 @@ namespace OpenSim.Region.Framework.Scenes
 
                 // We need to explicitly resend the newly link prim's object properties since no other actions
                 // occur on link to invoke this elsewhere (such as object selection)
-                parentGroup.RootPart.AddFlag(PrimFlags.CreateSelected);
+                parentGroup.RootPart.CreateSelected = true;
                 parentGroup.TriggerScriptChangedEvent(Changed.LINK);
                 parentGroup.HasGroupChanged = true;
                 parentGroup.ScheduleGroupForFullUpdate();
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
index 4453bebec8..ab7e3e99f6 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectGroup.cs
@@ -2254,7 +2254,7 @@ namespace OpenSim.Region.Framework.Scenes
                 linkPart.LinkNum = 2;
 
                 linkPart.SetParent(this);
-                linkPart.AddFlag(PrimFlags.CreateSelected);
+                linkPart.CreateSelected = true;
 
                 //if (linkPart.PhysActor != null)
                 //{
diff --git a/OpenSim/Region/Framework/Scenes/SceneObjectPart.cs b/OpenSim/Region/Framework/Scenes/SceneObjectPart.cs
index b36b9bfff2..ce1972fd91 100644
--- a/OpenSim/Region/Framework/Scenes/SceneObjectPart.cs
+++ b/OpenSim/Region/Framework/Scenes/SceneObjectPart.cs
@@ -387,7 +387,6 @@ namespace OpenSim.Region.Framework.Scenes
             // the prim into an agent inventory (Linden client reports that the "Object not found for drop" in its log
 
             _flags = 0;
-            _flags |= PrimFlags.CreateSelected;
 
             TrimPermissions();
             //m_undo = new UndoStack<UndoState>(ParentGroup.GetSceneMaxUndo());
@@ -417,6 +416,7 @@ namespace OpenSim.Region.Framework.Scenes
         private PrimFlags _flags = 0;
         private DateTime m_expires;
         private DateTime m_rezzed;
+        private bool m_createSelected = true;
 
         public UUID CreatorID 
         {
@@ -967,6 +967,13 @@ namespace OpenSim.Region.Framework.Scenes
             set { m_updateFlag = value; }
         }
 
+        [XmlIgnore]
+        public bool CreateSelected
+        {
+            get { return m_createSelected; }
+            set { m_createSelected = value; }
+        }
+
         #endregion
 
 //---------------
diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index 7a9a92d175..6e9a823c87 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -3506,7 +3506,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
             }
 
             parentPrim.TriggerScriptChangedEvent(Changed.LINK);
-            parentPrim.RootPart.AddFlag(PrimFlags.CreateSelected);
+            parentPrim.RootPart.CreateSelected = true;
             parentPrim.HasGroupChanged = true;
             parentPrim.ScheduleGroupForFullUpdate();