In llRequestInventoryData() use GetInventoryItems() rather than cloning TaskInventory directory

GetInventoryItems() returns a new list and so is equivalent, and creates this list under lock whereas Clone() is not thread-safe
0.7.3-extended
Justin Clark-Casey (justincc) 2012-07-04 21:19:16 +01:00
parent 3436be2046
commit e8a0ec1287
1 changed files with 2 additions and 3 deletions

View File

@ -4009,9 +4009,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
{ {
m_host.AddScriptLPS(1); m_host.AddScriptLPS(1);
TaskInventoryDictionary itemDictionary = (TaskInventoryDictionary)m_host.TaskInventory.Clone(); foreach (TaskInventoryItem item in m_host.Inventory.GetInventoryItems())
foreach (TaskInventoryItem item in itemDictionary.Values)
{ {
if (item.Type == 3 && item.Name == name) if (item.Type == 3 && item.Name == name)
{ {
@ -4043,6 +4041,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
return tid.ToString(); return tid.ToString();
} }
} }
ScriptSleep(1000); ScriptSleep(1000);
return String.Empty; return String.Empty;
} }