OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* Fixed UDP server (again) 

* Guys, there's an endless loop there *ON PURPOSE*.  Please don't try to *fix* it.  We must continue to process the UDP stream buffer on clients that disconnected nastily until it ends or the UDP server accept thread will die a horrible death.
0.6.0-stable
Teravus Ovares 2008-10-19 17:02:39 +00:00
parent 1ee10d919a
commit ed8a20dd60
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs
View File

@ -306,7 +306,12 @@ namespace OpenSim.Region.ClientStack.LindenUDP
} }
catch (SocketException e) catch (SocketException e)
{ {
m_log.ErrorFormat("[CLIENT]: BeginRecieve threw exception " + e.Message + ": " + e.StackTrace ); // We don't need to see this error, reset connection and get next UDP packet off the buffer
// If the UDP packet is part of the same stream, this will happen several hundreds of times before
// the next set of UDP data is for a valid client.
//m_log.ErrorFormat("[CLIENT]: BeginRecieve threw exception " + e.Message + ": " + e.StackTrace );
// ENDLESS LOOP ON PURPOSE!
ResetEndPoint(); ResetEndPoint();
} }
} }
@ -322,10 +327,16 @@ namespace OpenSim.Region.ClientStack.LindenUDP
m_log.Error("[UDPSERVER]: " + a); m_log.Error("[UDPSERVER]: " + a);
} }
// ENDLESS LOOP ON PURPOSE!
// We need to purge the UDP stream of crap from the client that disconnected nastily or the UDP server will die
// The only way to do that is to beginreceive again!
BeginReceive();
try try
{ {
m_socket.BeginReceiveFrom( // m_socket.BeginReceiveFrom(
RecvBuffer, 0, RecvBuffer.Length, SocketFlags.None, ref reusedEpSender, ReceivedData, null); // RecvBuffer, 0, RecvBuffer.Length, SocketFlags.None, ref reusedEpSender, ReceivedData, null);
// Ter: For some stupid reason ConnectionReset basically kills our async event structure.. // Ter: For some stupid reason ConnectionReset basically kills our async event structure..
// so therefore.. we've got to tell the server to BeginReceiveFrom again. // so therefore.. we've got to tell the server to BeginReceiveFrom again.