OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix regression where multiple close agents could be sent to the wrong neighbour region on root agent close. 

This was introduced in git master d214e2d0 (Thu May 16 17:12:02 2013)
Caught out by the fact that value types used in iterators act like references and this was dispatched asynchronously.
Should address http://opensimulator.org/mantis/view.php?id=6658
cpu-performance
Justin Clark-Casey (justincc) 2013-06-07 19:13:24 +01:00
parent a74e65200c
commit f2a4d9b99c
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
OpenSim/Region/Framework/Scenes/SceneCommunicationService.cs
View File

@ -222,7 +222,12 @@ namespace OpenSim.Region.Framework.Scenes
public void SendCloseChildAgentConnections(UUID agentID, List<ulong> regionslst)
{
foreach (ulong handle in regionslst)
Util.FireAndForget(delegate { SendCloseChildAgent(agentID, handle); });
{
// We must take a copy here since handle is acts like a reference when used in an iterator.
// This leads to race conditions if directly passed to SendCloseChildAgent with more than one neighbour region.
ulong handleCopy = handle;
Util.FireAndForget((o) => { SendCloseChildAgent(agentID, handleCopy); });
}
}
public List<GridRegion> RequestNamedRegions(string name, int maxNumber)