diff --git a/OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs b/OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs index 19231e1943..ea7f195197 100644 --- a/OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs +++ b/OpenSim/Framework/Servers/HttpServer/BaseHttpServer.cs @@ -738,11 +738,11 @@ namespace OpenSim.Framework.Servers.HttpServer } catch (IOException e) { - m_log.Error(String.Format("[BASE HTTP SERVER]: HandleRequest() threw {0} ", e.StackTrace), e); + m_log.Error("[BASE HTTP SERVER]: HandleRequest() threw exception ", e); } catch (Exception e) { - m_log.Error(String.Format("[BASE HTTP SERVER]: HandleRequest() threw {0} ", e.StackTrace), e); + m_log.Error("[BASE HTTP SERVER]: HandleRequest() threw exception ", e); try { byte[] buffer500 = SendHTML500(response); diff --git a/OpenSim/Framework/WebUtil.cs b/OpenSim/Framework/WebUtil.cs index 7f341d2889..10a256008f 100644 --- a/OpenSim/Framework/WebUtil.cs +++ b/OpenSim/Framework/WebUtil.cs @@ -1024,8 +1024,9 @@ namespace OpenSim.Framework } catch (Exception e) { - m_log.DebugFormat( - "[FORMS]: exception occured {0} {1}: {2}{3}", verb, requestUrl, e.Message, e.StackTrace); + m_log.ErrorFormat("[FORMS]: Error sending request to {0}: {1}. Request: {2}", requestUrl, e.Message, + obj.Length > WebUtil.MaxRequestDiagLength ? obj.Remove(WebUtil.MaxRequestDiagLength) : obj); + throw e; } finally { @@ -1043,27 +1044,17 @@ namespace OpenSim.Framework { if (resp.ContentLength != 0) { - Stream respStream = null; - try - { - using (respStream = resp.GetResponseStream()) - using (StreamReader reader = new StreamReader(respStream)) - respstring = reader.ReadToEnd(); - } - catch (Exception e) - { - m_log.DebugFormat( - "[FORMS]: Exception occured on receiving {0} {1}: {2}{3}", - verb, requestUrl, e.Message, e.StackTrace); - } + using (Stream respStream = resp.GetResponseStream()) + using (StreamReader reader = new StreamReader(respStream)) + respstring = reader.ReadToEnd(); } } } - catch (System.InvalidOperationException e) + catch (Exception e) { - m_log.Debug( - string.Format( - "[FORMS]: InvalidOperationException on response from {0} {1} ", verb, requestUrl), e); + m_log.ErrorFormat("[FORMS]: Error receiving response from {0}: {1}. Request: {2}", requestUrl, e.Message, + obj.Length > WebUtil.MaxRequestDiagLength ? obj.Remove(WebUtil.MaxRequestDiagLength) : obj); + throw e; } }