* Make RegionProfileData.RequestSimProfileData static

* Minor documentation bits

OpenSim/Framework/Data/RegionProfileData.cs

@@ -182,7 +182,15 @@ namespace OpenSim.Framework.Data
             return simData;
         }
 
-        public RegionProfileData RequestSimProfileData(ulong region_handle, string gridserver_url,
+        /// <summary>
+        /// Request sim profile information from a grid server
+        /// </summary>
+        /// <param name="region_handle"></param>
+        /// <param name="gridserver_url"></param>
+        /// <param name="gridserver_sendkey"></param>
+        /// <param name="gridserver_recvkey"></param>
+        /// <returns>The sim profile.  Null if there was a request failure</returns>
+        public static RegionProfileData RequestSimProfileData(ulong region_handle, string gridserver_url,
                                                        string gridserver_sendkey, string gridserver_recvkey)
         {
             Hashtable requestData = new Hashtable();

OpenSim/Grid/GridServer/GridManager.cs

@@ -503,6 +503,11 @@ namespace OpenSim.Grid.GridServer
 
         }
 
+        /// <summary>
+        /// Returns an XML RPC response to a simulator profile request
+        /// </summary>
+        /// <param name="request"></param>
+        /// <returns></returns>
         public XmlRpcResponse XmlRpcSimulatorDataRequestMethod(XmlRpcRequest request)
         {
             Hashtable requestData = (Hashtable) request.Params[0];

OpenSim/Grid/UserServer/UserLoginService.cs

@@ -72,11 +72,12 @@ namespace OpenSim.Grid.UserServer
             bool tryDefault = false;
             //CFK: Since the try is always "tried", the "Home Location" message should always appear, so comment this one.
             //CFK: m_log.Info("[LOGIN]: Load information from the gridserver");
-            RegionProfileData SimInfo = new RegionProfileData();
+
             try
             {
-                SimInfo =
+                RegionProfileData SimInfo =
-                    SimInfo.RequestSimProfileData(theUser.currentAgent.currentHandle, m_config.GridServerURL,
+                    RegionProfileData.RequestSimProfileData(
+                        theUser.currentAgent.currentHandle, m_config.GridServerURL,
                         m_config.GridSendKey, m_config.GridRecvKey);
 
                 // Customise the response
@@ -129,7 +130,8 @@ namespace OpenSim.Grid.UserServer
                 theUser.currentAgent.currentRegion = SimInfo.UUID;
                 theUser.currentAgent.currentHandle = SimInfo.regionHandle;
 
-                m_log.Info("[LOGIN]: " + SimInfo.regionName + " @ " + SimInfo.httpServerURI + "  " +
+                m_log.Info("[LOGIN]: Sending expect user call to "
+                           + SimInfo.regionName + " @ " + SimInfo.httpServerURI + "  " +
                            SimInfo.regionLocX + "," + SimInfo.regionLocY);
 
                 XmlRpcRequest GridReq = new XmlRpcRequest("expect_user", SendParams);                
@@ -139,6 +141,7 @@ namespace OpenSim.Grid.UserServer
             {
                 tryDefault = true;
             }
+            
             if (tryDefault)
             {
                 // Send him to default region instead
@@ -149,11 +152,10 @@ namespace OpenSim.Grid.UserServer
                 m_log.Warn(
                     "[LOGIN]: Home region not available: sending to default " + defaultHandle.ToString());
 
-                SimInfo = new RegionProfileData();
                 try
                 {
-                    SimInfo =
+                    RegionProfileData SimInfo = RegionProfileData.RequestSimProfileData(
-                        SimInfo.RequestSimProfileData(defaultHandle, m_config.GridServerURL,
+                        defaultHandle, m_config.GridServerURL,
                         m_config.GridSendKey, m_config.GridRecvKey);
 
                     // Customise the response

OpenSim/Region/Communications/OGS1/OGS1GridServices.cs

@@ -75,7 +75,7 @@ namespace OpenSim.Region.Communications.OGS1
         }
 
         /// <summary>
-        /// 
+        /// Contructor.  Adds "expect_user" and "check" xmlrpc method handlers
         /// </summary>
         /// <param name="servers_info"></param>
         /// <param name="httpServe"></param>