* Change static field "initialized" in RestInterregionComms to an instance field

* This was the cause of teleport tests interfering with each other
0.6.3-post-fixes
Justin Clarke Casey 2009-02-13 20:12:11 +00:00
parent d307109e1a
commit b71d68c9bc
4 changed files with 13 additions and 18 deletions

View File

@ -45,7 +45,7 @@ namespace OpenSim.Region.CoreModules.Communications.REST
{
public class RESTInterregionComms : IRegionModule, IInterregionCommsOut
{
private static bool initialized = false;
private bool initialized = false;
private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);
protected bool m_enabled = false;
@ -78,7 +78,6 @@ namespace OpenSim.Region.CoreModules.Communications.REST
return;
InitEach(scene);
}
public virtual void PostInitialise()
@ -162,7 +161,6 @@ namespace OpenSim.Region.CoreModules.Communications.REST
//else
// m_log.Warn("[REST COMMS]: Region not found " + regionHandle);
return false;
}
public bool SendChildAgentUpdate(ulong regionHandle, AgentPosition cAgentData)
@ -180,7 +178,6 @@ namespace OpenSim.Region.CoreModules.Communications.REST
//else
// m_log.Warn("[REST COMMS]: Region not found " + regionHandle);
return false;
}
public bool SendReleaseAgent(ulong regionHandle, UUID id, string uri)

View File

@ -221,7 +221,7 @@ namespace OpenSim.Region.CoreModules.World.Archiver.Tests
[Test]
public void TestMergeOarV0p2()
{
XmlConfigurator.Configure();
//XmlConfigurator.Configure();
MemoryStream archiveWriteStream = new MemoryStream();

View File

@ -3750,7 +3750,7 @@ namespace OpenSim.Region.Framework.Scenes
SceneObjectPart jointProxyObject = GetSceneObjectPart(joint.ObjectNameInScene);
if (jointProxyObject != null)
{
SimChat(Utils.StringToBytes("[NINJA] " + message),
SimChat(Utils.StringToBytes("[NINJA]: " + message),
ChatTypeEnum.DebugChannel,
2147483647,
jointProxyObject.AbsolutePosition,
@ -3762,7 +3762,7 @@ namespace OpenSim.Region.Framework.Scenes
if (joint.ErrorMessageCount > PhysicsJoint.maxErrorMessages)
{
SimChat(Utils.StringToBytes("[NINJA] Too many messages for this joint, suppressing further messages."),
SimChat(Utils.StringToBytes("[NINJA]: Too many messages for this joint, suppressing further messages."),
ChatTypeEnum.DebugChannel,
2147483647,
jointProxyObject.AbsolutePosition,

View File

@ -51,7 +51,7 @@ namespace OpenSim.Region.Framework.Scenes.Tests
[Test]
public void TestSimpleNotNeighboursTeleport()
{
//log4net.Config.XmlConfigurator.Configure();
log4net.Config.XmlConfigurator.Configure();
UUID sceneAId = UUID.Parse("00000000-0000-0000-0000-000000000100");
UUID sceneBId = UUID.Parse("00000000-0000-0000-0000-000000000200");
@ -80,20 +80,18 @@ namespace OpenSim.Region.Framework.Scenes.Tests
// FIXME: This is a hack to get the test working - really the normal OpenSim mechanisms should be used.
client.TeleportTargetScene = sceneB;
// Commenting this out for now -- Diva
//client.Teleport(sceneB.RegionInfo.RegionHandle, new Vector3(100, 100, 100), new Vector3(40, 40, 40));
client.Teleport(sceneB.RegionInfo.RegionHandle, new Vector3(100, 100, 100), new Vector3(40, 40, 40));
//Assert.That(sceneB.GetScenePresence(agentId), Is.Not.Null, "Client does not have an agent in sceneB");
//Assert.That(sceneA.GetScenePresence(agentId), Is.Null, "Client still had an agent in sceneA");
Assert.That(sceneB.GetScenePresence(agentId), Is.Not.Null, "Client does not have an agent in sceneB");
Assert.That(sceneA.GetScenePresence(agentId), Is.Null, "Client still had an agent in sceneA");
//ICapabilitiesModule sceneBCapsModule = sceneB.RequestModuleInterface<ICapabilitiesModule>();
ICapabilitiesModule sceneBCapsModule = sceneB.RequestModuleInterface<ICapabilitiesModule>();
// Temporary assertion - caps url construction should at least be doable through a method.
//Assert.That(
// "http://" + sceneB.RegionInfo.ExternalHostName + ":" + sceneB.RegionInfo.HttpPort + "/CAPS/" + sceneBCapsModule.GetCapsPath(agentId) + "0000/",
// Is.EqualTo(client.CapsSeedUrl),
// "Incorrect caps object path set up in sceneB");
// ---- up to here -- Diva
Assert.That(
"http://" + sceneB.RegionInfo.ExternalHostName + ":" + sceneB.RegionInfo.HttpPort + "/CAPS/" + sceneBCapsModule.GetCapsPath(agentId) + "0000/",
Is.EqualTo(client.CapsSeedUrl),
"Incorrect caps object path set up in sceneB");
// This assertion will currently fail since we don't remove the caps paths when no longer needed
//Assert.That(sceneACapsModule.GetCapsPath(agentId), Is.Null, "sceneA still had a caps object path");