Justin Clark-Casey (justincc)
7a8dd539fd
minor: remove pointless comment from OdeScene.cs
2011-12-12 20:24:03 +00:00
Justin Clark-Casey (justincc)
382cda662f
minor: comment out "unpacked appearance" log mesasge for now
2011-12-12 20:23:17 +00:00
Justin Clark-Casey (justincc)
ede9aea45f
Comment out ChildAgentDataUpdate.Pack() "Pack data" message for now.
2011-12-12 20:23:07 +00:00
Justin Clark-Casey (justincc)
52b8518fc2
Do some clean up Scene.cs log messages.
...
This prints out both exception message and stacktrace (Exception.ToString()) isn't enough on Windows.
This also uses m_log.*Format() which is more efficient than string concat.
2011-12-12 20:22:57 +00:00
Justin Clark-Casey (justincc)
c3d16955a7
Get rid of IScene.PresenceChildStatus() which always had to execute a lookup in favour of IClientAPI.ISceneAgent.IsChildAgent instead.
2011-12-12 20:22:54 +00:00
Justin Clark-Casey (justincc)
61df0da7f9
remove some unused fields in ScenePresence
2011-12-12 20:18:13 +00:00
Justin Clark-Casey (justincc)
f8b0427086
Move client id check in Scene.Inventory.cs:UpdateInventoryItemAsset so that it doesn't trigger an exception if the item hasn't been found.
...
In this situation we will now put out a slightly more meaningful log error message instead.
2011-12-12 20:17:43 +00:00
Justin Clark-Casey (justincc)
5b0d0ef1e9
Don't reply with an ack packet if the client is not authorized.
2011-12-12 20:17:22 +00:00
Justin Clark-Casey (justincc)
7ca688f5c5
Extend TestAddClient() to check that the first packet received is an ack packet
2011-12-12 20:17:14 +00:00
Justin Clark-Casey (justincc)
9dc1000c27
Add OpenSim.Region.ClientStack.LindenUDP.Tests.dll back into the test suite
2011-12-12 20:15:28 +00:00
Justin Clark-Casey (justincc)
638afca5aa
Reactivate BasicCircuitTests.TestAddClient()
...
This checks that the initial UseCircuitCode packet is handled correctly for a normal client login.
2011-12-12 20:15:16 +00:00
Justin Clark-Casey (justincc)
7e415e3f85
Remove unnecessary AgentCircuitData null check from Scene.AddNewClient().
...
The only caller is the LLUDP stack and this has to validate the UDP circuit itself, so we know that it exists.
This allows us to eliminate another null check elsewhere and simplifies the method contract
2011-12-12 20:11:26 +00:00
Justin Clark-Casey (justincc)
8c4e58995d
When a client connects to a scene, send other avatar appearance data asynchronously to reduce hold up in the IN UDP packet processing loop.
...
This is already being done for the initial object data send.
2011-12-12 20:09:04 +00:00
Justin Clark-Casey (justincc)
d26ded4788
fix build
2011-12-12 20:08:49 +00:00
Justin Clark-Casey (justincc)
5268334c61
On a new client circuit, send the initial reply ack to let the client know it's live before sending other data.
...
This means that avatar/appearance data of other avatars and scene objects for a client will be sent after the ack rather than possibly before.
This may stop some avatars appearing grey on login.
This introduces a new OpenSim.Framework.ISceneAgent to accompany the existing OpenSim.Framework.ISceneObject and ISceneEntity
This allows IClientAPI to handle this as it can't reference OpenSim.Region.Framework.Interfaces
2011-12-12 20:08:02 +00:00
Justin Clark-Casey (justincc)
6ba4cbc259
Simplify Scene.AddNewClient()
...
If sp becomes null right after we've checked or created it, then behaviour down the line is going to be wrong anyway.
So instead retain the check/create ScenePresence reference and use this.
2011-12-12 20:00:15 +00:00
Melanie
ac445463e9
Remove a left over log output
2011-12-08 23:54:33 +00:00
Justin Clark-Casey (justincc)
1e83800d32
Remove warning in admin_save_oar xmlrpc method where noassets == true was comparing against an object rather than a string
2011-12-08 23:54:25 +00:00
Justin Clark-Casey (justincc)
3d94984eee
Have admin_load_heighmap and admin_save_heightmap xmlrpcadmin methods return success = true on success rather than false
2011-12-08 23:54:18 +00:00
Justin Clark-Casey (justincc)
fd8734b22c
Refactor RemoteAdminPlugin so that every xmlrpc method calls a common block of code to do password checks, etc., instead of copy/pasting this code into every method
2011-12-08 23:54:11 +00:00
Justin Clark-Casey (justincc)
9b229efdc5
Remove unused SceneManager.TryGetAvatarsScene()
...
It makes far more sense anyway to use TryGetRootScenePresence().Scene, in common with the rest of the code
This method could also return any scene for child or root agents, depending in which order the scenes happened to lie in the list
2011-12-08 23:54:04 +00:00
Justin Clark-Casey (justincc)
81daedcfe3
Implement XMLRPCAdmin command admin_teleport_agent.
...
This allows someone with access to this command on the XMLRPCAdmin interface to teleport an avatar to an arbitrary region and/or position.
2011-12-08 23:53:43 +00:00
Michelle Argus
b819771919
RemoteAdmin - Added optional terrain loading on region create using parameter heightmap_file to specify the terrain file to be loaded
2011-12-08 23:53:18 +00:00
Justin Clark-Casey (justincc)
2f536f92c0
Remove the inconsistently applied now pointless FailIfRemoteAdminDisabled() check on XMLRPC RemoteAdmin handlers.
...
If admin is disabled then the XMLRPC handlers are never registered, which means that they cannot be called anyway.
2011-12-08 23:52:04 +00:00
Justin Clark-Casey (justincc)
0b4774c50c
replace List used by m_accessIP in RemoteAdminPlugin with the more efficient HashSet
2011-12-08 23:51:58 +00:00
Justin Clark-Casey (justincc)
139b0d03b6
Improve explanation of access_ip_addresses in [RemoteAdmin] to say that there are no restrictions if not set
2011-12-08 23:51:51 +00:00
Justin Clark-Casey (justincc)
c13916d392
Add option to allow only explicitly listed IPs to access RemoteAdmin facilities.
...
Also adds password check to some functions where this was missing and fixes some parameter checking.
This is a patch from http://opensimulator.org/mantis/view.php?id=5715 with a few small unrelated spacing tweaks from me.
Thanks Michelle Argus.
2011-12-08 23:51:16 +00:00
Justin Clark-Casey (justincc)
3ebb56734d
properly lock CapsHandlers.m_capsHandlers
2011-12-08 23:47:45 +00:00
Justin Clark-Casey (justincc)
235147c857
Make "show appearance" a synonym for "appearance show"
2011-12-06 22:24:11 +00:00
Justin Clark-Casey (justincc)
ddb74bc68d
In "appearance show", if a particular avatar is specified, print out texture UUID for each bake type and whether the simulator can find it.
2011-12-06 22:23:52 +00:00
Justin Clark-Casey (justincc)
cd132966df
Actually send the avatar data if an individual avatar is specified, rather than accidentally doing nothing
2011-12-06 22:21:02 +00:00
Justin Clark-Casey (justincc)
5d4fee6eb9
conflict resolution due to drift in ValidateBakedTextureCache args
2011-12-06 22:20:44 +00:00
Justin Clark-Casey (justincc)
cc80377325
Allow "appearance show" command to take an optional avatar name
2011-12-06 22:20:01 +00:00
Justin Clark-Casey (justincc)
7dce33ce69
Make it possible to manually send appearance information via the "appearance send" command for a chosen avatar as well as all
2011-12-06 22:16:49 +00:00
Justin Clark-Casey (justincc)
0dd45f6ca4
Provide feedback as to which avatars are resending appearance informion on "appearance send" console command
2011-12-06 22:16:40 +00:00
Justin Clark-Casey (justincc)
ac3d88804f
Stop accidentally setting up the UploadTexture caps handler with the same url for all users
...
This meant that if a user exited the region, the UploadTexture handler would be effectively removed for everyone, causing subsequent failures.
This hopefully resolves the recent UploadTexture LLSD problems
This was a regression in 5640f2e (Thu Dec 1 23:24:15 2011 +0000)
2011-12-06 22:13:58 +00:00
Justin Clark-Casey (justincc)
f1698552f9
For the GetTexture capability, if a data range is requested that covers the whole asset length, return HTTP PartialContent instead of NotFound
...
NotFound is obviously wrong, and this change stops viewer 3.2.2 (and v probably earlier) complaining in the log about missing textures that are actually present.
We still return PartialContent even if the range requested is a superset of the data range as per httpd's behaviour
https://issues.apache.org/bugzilla/show_bug.cgi?id=51878
Viewer 3.2.2 and very probably earlier appear happy with this.
Whether fixing this NotFound bug has any practical effect apart from resolve viewer log messages is unknown.
2011-12-05 21:06:16 +00:00
Justin Clark-Casey (justincc)
dfeb424afd
Add "appearance send" command to allow manual sending of appearance.
2011-12-05 16:02:26 +00:00
Justin Clark-Casey (justincc)
2380980975
Stop performing the asset save part of baked texture uploading on the UploadBakedTexture cap asynchronously.
...
This prevents a possible race condition where the client would be told all baked textures had updated before they were in the asset service.
The client would then trigger a set appearance which, after a delay, would send the avatar appearance out to other clients.
The race condition seems unlikely because of this delay but it's still possible.
Might help with grey avatar appearances.
2011-12-05 16:00:36 +00:00
Justin Clark-Casey (justincc)
52ec854c42
refactor: Separate the upload baked texture handler out from BunchOfCaps
2011-12-05 16:00:27 +00:00
Justin Clark-Casey (justincc)
4dbfcc26a2
Provide more user feedback when "debug http" is set
2011-12-05 16:00:15 +00:00
Justin Clark-Casey (justincc)
a262d2492f
On "show caps", stop excluding the seed cap but do exclude it elsewhere
2011-12-05 16:00:06 +00:00
Justin Clark-Casey (justincc)
e5b7e2fd40
With "debug http 1", show the path with the query string instead of just the path.
...
Also simplifies debug levels to just 0 and 1
2011-12-05 15:59:53 +00:00
Justin Clark-Casey (justincc)
7505f23f80
Improve some of the debug help messages
2011-12-05 15:59:45 +00:00
Justin Clark-Casey (justincc)
7562e63ae6
minor: remove mono compile warning, a Vector3 can never be null since it's a struct
2011-12-05 15:59:38 +00:00
Justin Clark-Casey (justincc)
7987a6da95
tabulate "show caps" output for easier readability
2011-12-05 15:59:27 +00:00
Justin Clark-Casey (justincc)
fcd60c6b74
Correct mistake in "debug eq" help
2011-12-05 15:59:19 +00:00
Justin Clark-Casey (justincc)
1e88bf78f1
When setting packet level logging via "debug packet", apply to all clients, not just root ones.
...
Also adds scene name and client type (root|child) to logged information.
2011-12-05 15:58:24 +00:00
Justin Clark-Casey (justincc)
a819890137
Add a "debug eq" console command for debugging.
...
This will log outgoing event queue message names if turned on.
2011-12-05 15:55:32 +00:00
Justin Clark-Casey (justincc)
5c85a98f6a
Add "debug http" command for currently simple extra debug logging of non-event queue inbound http requests to a simulator
2011-12-05 15:54:10 +00:00