OpenSim
/
OpenSimMirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

On entity transfer of scene presence, replace polling sleep in SP.WaitForUpdateAgent() with a triggered event instead. 

Rapid polls are more expensive than triggered events (several polls vs one trigger) and may be problematic on heavily loaded simulators where many threads are vying for processor time.
A triggered event is also slightly quicker as there is no maximum 200ms wait between polls.
0.8-extended
Justin Clark-Casey (justincc) 2014-08-13 23:45:51 +01:00 committed by Justin Clark-Casey
parent 5360cd4247
commit bd54798923
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
OpenSim/Region/Framework/Scenes/ScenePresence.cs
View File

@ -343,6 +343,12 @@ namespace OpenSim.Region.Framework.Scenes
/// </summary> /// </summary>
private object m_originRegionIDAccessLock = new object(); private object m_originRegionIDAccessLock = new object();
/// <summary>
/// Triggered on entity transfer after to allow CompleteMovement() to proceed after we have received an
/// UpdateAgent from the originating region.ddkjjkj
/// </summary>
private AutoResetEvent m_updateAgentReceivedAfterTransferEvent = new AutoResetEvent(false);
/// <summary> /// <summary>
/// Used by the entity transfer module to signal when the presence should not be closed because a subsequent /// Used by the entity transfer module to signal when the presence should not be closed because a subsequent
/// teleport is reusing the connection. /// teleport is reusing the connection.
@ -1648,7 +1654,6 @@ namespace OpenSim.Region.Framework.Scenes
PhysicsActor.Size = size; PhysicsActor.Size = size;
// PhysicsActor.setAvatarSize(size, feetoffset); // PhysicsActor.setAvatarSize(size, feetoffset);
} }
} }
private bool WaitForUpdateAgent(IClientAPI client) private bool WaitForUpdateAgent(IClientAPI client)
@ -1657,21 +1662,13 @@ namespace OpenSim.Region.Framework.Scenes
// (which triggers Scene.IncomingUpdateChildAgent(AgentData cAgentData) here in the destination, // (which triggers Scene.IncomingUpdateChildAgent(AgentData cAgentData) here in the destination,
// m_originRegionID is UUID.Zero; after, it's non-Zero. The CompleteMovement sequence initiated from the // m_originRegionID is UUID.Zero; after, it's non-Zero. The CompleteMovement sequence initiated from the
// viewer (in turn triggered by the source region sending it a TeleportFinish event) waits until it's non-zero // viewer (in turn triggered by the source region sending it a TeleportFinish event) waits until it's non-zero
int count = 50; m_updateAgentReceivedAfterTransferEvent.WaitOne(10000);
UUID originID;
UUID originID = UUID.Zero;
lock (m_originRegionIDAccessLock) lock (m_originRegionIDAccessLock)
originID = m_originRegionID; originID = m_originRegionID;
while (originID.Equals(UUID.Zero) && count-- > 0)
{
lock (m_originRegionIDAccessLock)
originID = m_originRegionID;
m_log.DebugFormat("[SCENE PRESENCE]: Agent {0} waiting for update in {1}", client.Name, Scene.Name);
Thread.Sleep(200);
}
if (originID.Equals(UUID.Zero)) if (originID.Equals(UUID.Zero))
{ {
// Movement into region will fail // Movement into region will fail
@ -3819,6 +3816,8 @@ namespace OpenSim.Region.Framework.Scenes
return; return;
CopyFrom(cAgentData); CopyFrom(cAgentData);
m_updateAgentReceivedAfterTransferEvent.Set();
} }
private static Vector3 marker = new Vector3(-1f, -1f, -1f); private static Vector3 marker = new Vector3(-1f, -1f, -1f);