48ea503c33
Fix race condition where the appearance update timer could be stopped just after another thread had started it on QueueAppearanceSave() or *Send()
...
However, the window for this race is very small, and the next queued appearance save or send would restart the timer anyway.
2011-12-19 21:16:14 +00:00
546eb88112
addresses mantis #5827
...
RAdmin - admin_save_oar fails if noassets parameter missing
thanks Michelle Argus
2011-12-19 21:09:36 +00:00
52710b48ac
Provide user feedback on execution of "backup" region console command
2011-12-19 21:09:28 +00:00
cc5e28c1c1
Fix bug where objects couldn't be set back to the "none" group.
...
This is handled by treating UUID.Zero as a special case.
Currently, asking for the "none" group returns nothing because XMLRPC groups, at least, is not properly handling this case.
It may be better in the future to have GroupsModule return an appropriate GroupsData structure instead or require the underlying services to behave appropriately.
This is a further component of http://opensimulator.org/mantis/view.php?id=5588
2011-12-19 21:09:19 +00:00
67a2d6d855
Fix bug where objects could not be set to a new group if the group had been created in that client session, or if no other action has been performed on the object.
...
There were two problems here:
1) On object group update, we looked for the group is the IClientAPI group cache rather than in the groups service. This fails to groups created newly in that session
2) On object group update, we weren't setting the HasGroupChanged flag. This meant that the change was not persisted unless some other action set this flag.
This commit fixes these issues and hopefully addresses http://opensimulator.org/mantis/view.php?id=5588
This commit also moves HandleObjectGroupUpdate() to the GroupsModule from the Scene.PacketHandlers.cs file
2011-12-19 21:09:09 +00:00
7d426debd3
refactor: simplify methods in Scene.PacketHandlers.cs by using GetGroupByPrim() rather than retrieving GetEntities() and inspecting the entire list
2011-12-19 21:05:27 +00:00
4de98ca4c8
Add SceneViewer changes for removing unused client flags
2011-12-19 21:01:46 +00:00
deb50cd410
Stop generating client flags when we send out full object updates.
...
These were entirely unused.
2011-12-19 20:59:18 +00:00
b3cfc5b76e
Stop pointlessly setting the m_colliderarr[] to false in the ODECharacter constructor
2011-12-19 20:49:31 +00:00
27644bcce6
Stop having to call SetHeight again in ScenePresence.AddToPhysicalScene() when we've already passed size information to the avatar at PhysicsScene.AddAvatar()
...
Eliminate some copypasta for height setting in OdeCharacter
2011-12-19 20:49:09 +00:00
903da8acbd
Simplify some manipulation of _taintedActors in OdeScene
2011-12-19 20:31:57 +00:00
cfdccdd71c
Eliminate _taintedPrimsH and _taintedPrimsL (and _taintedPrimLock) in favour of just a _taintedPrims HashSet.
...
There's no point maintaining a list because any pending taint operations are all carried out in the same call anyway.
2011-12-19 20:30:52 +00:00
93e65fb9d5
In AvatarFactoryModule.SetApperance(), perform ValidateBakedTextureCache() in the same thread rather than on another one.
...
The caller is already an async thread from LLClientView so this doesn't hold up the client.
However, launching on a separate thread does remove the effect of m_setAppearanceLock
This was potentially allowing two different SetAppearance threads to interfere with each other, though this probably rarely happens, if at all.
2011-12-19 20:30:26 +00:00
af117fe4d4
Get rid of the 'lolcat' library asset.
...
This was both unused and an invalid jpeg2000 texture from way back in 2008
2011-12-19 20:26:19 +00:00
986f6b39ca
Fix build
2011-12-12 20:32:47 +00:00
7a8dd539fd
minor: remove pointless comment from OdeScene.cs
2011-12-12 20:24:03 +00:00
382cda662f
minor: comment out "unpacked appearance" log mesasge for now
2011-12-12 20:23:17 +00:00
ede9aea45f
Comment out ChildAgentDataUpdate.Pack() "Pack data" message for now.
2011-12-12 20:23:07 +00:00
52b8518fc2
Do some clean up Scene.cs log messages.
...
This prints out both exception message and stacktrace (Exception.ToString()) isn't enough on Windows.
This also uses m_log.*Format() which is more efficient than string concat.
2011-12-12 20:22:57 +00:00
c3d16955a7
Get rid of IScene.PresenceChildStatus() which always had to execute a lookup in favour of IClientAPI.ISceneAgent.IsChildAgent instead.
2011-12-12 20:22:54 +00:00
61df0da7f9
remove some unused fields in ScenePresence
2011-12-12 20:18:13 +00:00
f8b0427086
Move client id check in Scene.Inventory.cs:UpdateInventoryItemAsset so that it doesn't trigger an exception if the item hasn't been found.
...
In this situation we will now put out a slightly more meaningful log error message instead.
2011-12-12 20:17:43 +00:00
5b0d0ef1e9
Don't reply with an ack packet if the client is not authorized.
2011-12-12 20:17:22 +00:00
7ca688f5c5
Extend TestAddClient() to check that the first packet received is an ack packet
2011-12-12 20:17:14 +00:00
9dc1000c27
Add OpenSim.Region.ClientStack.LindenUDP.Tests.dll back into the test suite
2011-12-12 20:15:28 +00:00
638afca5aa
Reactivate BasicCircuitTests.TestAddClient()
...
This checks that the initial UseCircuitCode packet is handled correctly for a normal client login.
2011-12-12 20:15:16 +00:00
7e415e3f85
Remove unnecessary AgentCircuitData null check from Scene.AddNewClient().
...
The only caller is the LLUDP stack and this has to validate the UDP circuit itself, so we know that it exists.
This allows us to eliminate another null check elsewhere and simplifies the method contract
2011-12-12 20:11:26 +00:00
8c4e58995d
When a client connects to a scene, send other avatar appearance data asynchronously to reduce hold up in the IN UDP packet processing loop.
...
This is already being done for the initial object data send.
2011-12-12 20:09:04 +00:00
d26ded4788
fix build
2011-12-12 20:08:49 +00:00
5268334c61
On a new client circuit, send the initial reply ack to let the client know it's live before sending other data.
...
This means that avatar/appearance data of other avatars and scene objects for a client will be sent after the ack rather than possibly before.
This may stop some avatars appearing grey on login.
This introduces a new OpenSim.Framework.ISceneAgent to accompany the existing OpenSim.Framework.ISceneObject and ISceneEntity
This allows IClientAPI to handle this as it can't reference OpenSim.Region.Framework.Interfaces
2011-12-12 20:08:02 +00:00
6ba4cbc259
Simplify Scene.AddNewClient()
...
If sp becomes null right after we've checked or created it, then behaviour down the line is going to be wrong anyway.
So instead retain the check/create ScenePresence reference and use this.
2011-12-12 20:00:15 +00:00
ac445463e9
Remove a left over log output
2011-12-08 23:54:33 +00:00
1e83800d32
Remove warning in admin_save_oar xmlrpc method where noassets == true was comparing against an object rather than a string
2011-12-08 23:54:25 +00:00
3d94984eee
Have admin_load_heighmap and admin_save_heightmap xmlrpcadmin methods return success = true on success rather than false
2011-12-08 23:54:18 +00:00
fd8734b22c
Refactor RemoteAdminPlugin so that every xmlrpc method calls a common block of code to do password checks, etc., instead of copy/pasting this code into every method
2011-12-08 23:54:11 +00:00
9b229efdc5
Remove unused SceneManager.TryGetAvatarsScene()
...
It makes far more sense anyway to use TryGetRootScenePresence().Scene, in common with the rest of the code
This method could also return any scene for child or root agents, depending in which order the scenes happened to lie in the list
2011-12-08 23:54:04 +00:00
81daedcfe3
Implement XMLRPCAdmin command admin_teleport_agent.
...
This allows someone with access to this command on the XMLRPCAdmin interface to teleport an avatar to an arbitrary region and/or position.
2011-12-08 23:53:43 +00:00
b819771919
RemoteAdmin - Added optional terrain loading on region create using parameter heightmap_file to specify the terrain file to be loaded
2011-12-08 23:53:18 +00:00
2f536f92c0
Remove the inconsistently applied now pointless FailIfRemoteAdminDisabled() check on XMLRPC RemoteAdmin handlers.
...
If admin is disabled then the XMLRPC handlers are never registered, which means that they cannot be called anyway.
2011-12-08 23:52:04 +00:00
0b4774c50c
replace List used by m_accessIP in RemoteAdminPlugin with the more efficient HashSet
2011-12-08 23:51:58 +00:00
139b0d03b6
Improve explanation of access_ip_addresses in [RemoteAdmin] to say that there are no restrictions if not set
2011-12-08 23:51:51 +00:00
c13916d392
Add option to allow only explicitly listed IPs to access RemoteAdmin facilities.
...
Also adds password check to some functions where this was missing and fixes some parameter checking.
This is a patch from http://opensimulator.org/mantis/view.php?id=5715 with a few small unrelated spacing tweaks from me.
Thanks Michelle Argus.
2011-12-08 23:51:16 +00:00
3ebb56734d
properly lock CapsHandlers.m_capsHandlers
2011-12-08 23:47:45 +00:00
235147c857
Make "show appearance" a synonym for "appearance show"
2011-12-06 22:24:11 +00:00
ddb74bc68d
In "appearance show", if a particular avatar is specified, print out texture UUID for each bake type and whether the simulator can find it.
2011-12-06 22:23:52 +00:00
cd132966df
Actually send the avatar data if an individual avatar is specified, rather than accidentally doing nothing
2011-12-06 22:21:02 +00:00
5d4fee6eb9
conflict resolution due to drift in ValidateBakedTextureCache args
2011-12-06 22:20:44 +00:00
cc80377325
Allow "appearance show" command to take an optional avatar name
2011-12-06 22:20:01 +00:00
7dce33ce69
Make it possible to manually send appearance information via the "appearance send" command for a chosen avatar as well as all
2011-12-06 22:16:49 +00:00
0dd45f6ca4
Provide feedback as to which avatars are resending appearance informion on "appearance send" console command
2011-12-06 22:16:40 +00:00
Justin Clark-Casey (justincc)