Justin Clark-Casey (justincc)
b46be88db6
Split verbose groups messaging logging into its own setting separate from that of the groups module.
...
This is to allow us to get useful information on messaging without being overwhelmed by the rest of groups debug.
Enabled with [Groups] DebugMessagingEnabled = true in config (default false)
Or "debug groups messaging verbose true|false on the console" (similar to existing groups setting).
Done for both xmlrpc and V2 groups.
2014-05-19 22:45:17 +01:00
Justin Clark-Casey (justincc)
3a6f312484
Fix recent regression from 77e7bbc
where an attachment on a received group notice with XmlRpcGroups messaging did not appear in the user's inventory.
...
This was because the "session ID" when the message template was copied was always replaced with the group ID, whereas a notice requires this to be the notice ID.
Instead just copy the "session ID" as is - other callers already have this set properly so replacing with group ID was redundant anyway.
Relates to http://opensimulator.org/mantis/view.php?id=7037
2014-05-19 22:06:41 +01:00
Oren Hurvitz
47b84875fd
Tell QueryAccess explicitly whether the user is coming in via Teleport or Cross, because the permission checks are different.
...
Previously we used a heuristic of checking if the entry position is 0 to differentiate between Teleport and Cross, but that doesn't work anymore since we've started providing the precise entry position for cross, too. That's required in order to ensure that the user is allowed to enter the parcel that he's walking into.
2014-05-19 11:19:11 +01:00
Oren Hurvitz
78733b979f
Log the user when an inventory operation is blocked because the item/folder isn't in the Suitcase
2014-05-19 11:12:53 +01:00
Oren Hurvitz
dd30a29ba0
Return more specific error messages if an attempt to enter a region fails due to permissions (in QueryAccess and IsAuthorizedForRegion)
2014-05-19 11:11:30 +01:00
Oren Hurvitz
882af7195c
Better error-handling and logging in case User Profile requests fail
2014-05-19 11:11:06 +01:00
Oren Hurvitz
96e5836b50
When can't rez, show only one error message; not two. And show more specific error messages.
2014-05-19 10:54:27 +01:00
Diva Canto
ab1472e5b7
Don't trigger ItemUploaded when no item has been uploaded.
2014-05-18 23:01:55 -07:00
Diva Canto
922f76a3a7
Don't fetch assets from the server when doing simple inventory operations like copy-paste items in inventory.
2014-05-18 07:49:01 -07:00
Robert Adams
0be9e3b079
BulletSim: adjust avatar step up parameters to better walk up small
...
staircases. This change is required because of the change in the
avatar default shape from the capsule to the rectangle.
2014-05-17 20:11:22 -07:00
Justin Clark-Casey (justincc)
4a74c4533c
minor: eliminate now unnecessary string.Format in postgresql RetrieveGroups method
2014-05-15 22:51:47 +01:00
Justin Clark-Casey (justincc)
d2c738fc09
Don't warn on not seeing [Groups] Robust section for core groups as this does not contain any mandatory parameters and won't be present on older installations.
2014-05-15 22:48:05 +01:00
Justin Clark-Casey (justincc)
6dc1b113d0
Escape find string in PgSQL core groups plugin
2014-05-15 22:45:01 +01:00
Justin Clark-Casey (justincc)
d32d25634d
Escape find string in MySQL core groups plugin
2014-05-15 22:09:37 +01:00
Justin Clark-Casey (justincc)
7c12dfe185
On ScenePresence.MakeChildAgent(), reset the m_originRegionID as this is currently being used as a flag to orchestrate destination simulator threads on teleport.
...
If not reset, it's possible that teleports back and forth between simulators may not restart scripts in attachments.
2014-05-14 22:08:06 +01:00
Justin Clark-Casey (justincc)
2f7539a25b
Remove a race where the client's SP.CompleteMovement() thread could attempt to restart attachment scripts before the source simulator's SP.UpdateAgent() thread had added them.
...
This commit changes the order of code so that attachments are re-added before the CompleteMovement() thread is released.
Relates to http://opensimulator.org/mantis/view.php?id=7148
2014-05-14 21:49:29 +01:00
Justin Clark-Casey (justincc)
0c0ee95bd8
minor: Clean up and make consistent some log file messages in EstateManagementModule relating to RAW file uploading.
2014-05-14 19:22:55 +01:00
Justin Clark-Casey (justincc)
c23d37a509
Fix recent asset request timeout issue by commenting out (for now) the m_maxAssetRequestConcurrency mistakenly passed in as a timeout to SynchronousRestObjectRequester.MakeRequest()
...
For a long time, possibly forever, the m_maxAssetRequestConcurrency was mistakenly passed in as a 30 ms timeout rather than as a concurrent connection limiter.
This didn't come to light until the timeout was actually used in recent commit faf9ba53
Since this hasn't been operational for a long time and in release candidate phase, commenting it out for now though will need to revisit this.
Relates to http://opensimulator.org/mantis/view.php?id=7165
2014-05-14 00:11:07 +01:00
Justin Clark-Casey (justincc)
4569c595bf
Fix behaviour change in recent commit bbc1dc6
so that SynchronousRestObjectRequester.MakeRequest() calls with no timeout specified use the default HttpWebRequest timeout as previously.
...
I mistakenly thought that that default request timeout was inifite rather than 100 seconds, restoring previously behaviour.
As per http://msdn.microsoft.com/en-us/library/system.net.httpwebrequest.timeout%28v=vs.100%29.aspx
Relates to http://opensimulator.org/mantis/view.php?id=7165
2014-05-13 22:21:20 +01:00
Justin Clark-Casey (justincc)
484aa72ff8
minor: Add some method doc to IMessageTransferModule
2014-05-12 23:49:37 +01:00
Justin Clark-Casey (justincc)
8ad29fc5c8
Make offline IM delivery to URL (pre recent Addons code) have a 10 second rather than infinite timeout.
...
This both signals a problem with the URL and eventually frees the thread, rather than hanging indefinitely with no information.
2014-05-12 23:42:47 +01:00
Justin Clark-Casey (justincc)
87e2668529
For XmlRpcGroups (Flotsam) module, when MessageOnlineUsersOnly = true, handle notices to offline users directly as known undeliverable messages rather than discarding or attempting delivery.
...
Offline notices can still be controlled with the [Messaging] ForwardOfflineGroupMessages setting.
Looks to address more of http://opensimulator.org/mantis/view.php?id=7037
Only for Flotsam now for testing, but if approach works should be possible with core offline notices as well.
2014-05-12 23:38:48 +01:00
Justin Clark-Casey (justincc)
515d373a8e
Add send group notice regression test for when MessageOnlineUsersOnly=true
2014-05-12 22:54:54 +01:00
Justin Clark-Casey (justincc)
bbc1dc6bce
Replace existing 0 timeout in internal overloaded SynchronousRestObjectRequester.MakeRequest() methods with proper Timeout.Infinite (-1) instead.
...
Triggered by recent faf9ba53
though this was wrong in the code before, it's just that we didn't actually try to set the timeout given.
2014-05-12 22:37:07 +01:00
Justin Clark-Casey (justincc)
8457044b2f
Eliminate subsequently unused scene finding in UndeliveredMessage() method of xmlrpc and core offline IM modules
2014-05-12 22:23:24 +01:00
Justin Clark-Casey (justincc)
19d8f05584
minor: eliminate unused UUID in xmlrpc GroupsMessagingModule.ProcessMessageFromGroupSession()
2014-05-12 22:15:01 +01:00
Justin Clark-Casey (justincc)
7db4336f1c
minor: Add method doc to SynchronousRestObjectRequester.MakeRequest() methods
2014-05-12 22:05:02 +01:00
Justin Clark-Casey (justincc)
faf9ba53fc
In SynchronousRestObjectRequester.MakeRequest<TRequest, TResponse>(string verb, string requestUrl, TRequest obj, int pTimeout, int maxConnections) actually set timeout on WebRequest if given.
...
Previously, we were doing nothing with this parameter.
No effect on current code since none of the 6 callers attempt to use the timeout.
2014-05-12 19:20:00 +01:00
Oren Hurvitz
bf8f64e40e
Fixed error if a user didn't have a "Current Outfit" folder in their suitcase.
...
This fixes http://opensimulator.org/mantis/view.php?id=7161
2014-05-12 08:54:31 +03:00
Diva Canto
73891c7fd3
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2014-05-09 11:06:33 -07:00
Diva Canto
667a272cce
This little sucker had evaded my attention forever. As a consequence some assets associated with foreign users were being missed.
2014-05-09 11:06:03 -07:00
Justin Clark-Casey (justincc)
f41809e07d
minor: Capitalize Hypergrid help category like others
2014-05-08 22:39:52 +01:00
Diva Canto
afb938e579
Fix test breakage
2014-05-08 11:30:45 -07:00
Diva Canto
a31393ba0b
Make the URL for texture redirects match the path of the resource that we use in OpenSim.
2014-05-08 11:18:17 -07:00
Diva Canto
a845c1a893
Finished implementing redirects in GetTexture.
2014-05-07 19:38:33 -07:00
Diva Canto
093705efd1
Delete extraneous console message in the Configger.
2014-05-07 17:19:57 -07:00
Diva Canto
f4cba27105
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2014-05-07 17:00:12 -07:00
Diva Canto
3db9b847bf
Allow Tools.Configger to take -inifile as argument
2014-05-07 16:59:11 -07:00
Justin Clark-Casey (justincc)
e44450cce1
Revert "fix infinite recursion loop in SendGridInstantMessageViaXMLRPCAsync()"
...
There is a problem here with infinite recursion, but this patch loses the 'hunting' behaviour where the code will attempt multiple lookups if the avatar is teleporting rapidly around different simulators.
This patch only does a single lookup before giving up.
This reverts commit cecb446e0e
.
2014-05-06 19:53:35 +01:00
Dev Random
78015bbbdc
Console commands for Estate Mgmt
2014-05-06 18:55:42 +01:00
Matt Lehmann
9e83b43009
new version of patch to add default-user switch new version :qw :wq updated version of default user switch for load oar :q :q
2014-05-06 18:48:59 +01:00
Matt Lehmann
8b3c2f7d0c
updated version of default user switch for load oar :q :q
2014-05-06 18:48:42 +01:00
Kunta Kinte
cecb446e0e
fix infinite recursion loop in SendGridInstantMessageViaXMLRPCAsync()
2014-05-06 17:52:32 +01:00
Vegaslon
0faba7dc33
Fix avatars going to corner of region when they are sitting on a child prim and the prim is deleted.
2014-05-06 17:41:13 +01:00
Vegaslon
e245638f24
Change llUnSit to be able to unsit any avatar that is currently sat on the object, not just avatars sitting on the sittarget in the object containing the script. or when the object is owned by the parcel, land group or estate owner.
2014-05-06 17:35:34 +01:00
Talun
c9742c826d
Mantis 7146 The lsl function llGetMassMKS is not implemented
...
This patch implements llGetMassMKS as it is described in the wiki
http://wiki.secondlife.com/wiki/LlGetMassMKS
2014-05-06 17:31:21 +01:00
Justin Clark-Casey (justincc)
95eeb4dde8
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2014-05-06 17:22:47 +01:00
Oren Hurvitz
ef262799ca
Better error handling in AssetServerPostHandler. Invalid XML causes an InvalidOperationException, not an XmlException
2014-05-06 09:43:07 +03:00
Oren Hurvitz
614b9e14c4
When moving an item from a prim to a user's inventory, don't delete the item from the prim until it was successfully copied to the user
2014-05-06 07:28:46 +01:00
Oren Hurvitz
eb79c882ea
Show more meaningful error messages when failed to move an item from a prim to a user's inventory.
...
Also, actually show the error to the user in more cases. (Previously, sometimes the operation failed without telling the user anything.)
2014-05-06 07:28:45 +01:00
Oren Hurvitz
1e5cff32fc
Show more meaningful error messages when failed to give an item to another user
2014-05-06 07:28:44 +01:00
Oren Hurvitz
df49196e17
Log whenever an inventory operation is blocked because the item/folder isn't in the Suitcase
2014-05-06 07:28:43 +01:00
Oren Hurvitz
0fe08c8799
- When sending the "My Suitcase" folder to the client, always claim it has Folder Type 8. (Previously we had used Folder Type -1 in one place, and LLClientView didn't even bother changing Folder Type 100 to anything else.)
2014-05-06 07:16:37 +01:00
Oren Hurvitz
7862d1e20d
Added range-checking for the parameters to PRIM_POINT_LIGHT (used in llSetLinkPrimitiveParamsFast() )
2014-05-06 07:14:58 +01:00
Diva Canto
13b2ac1425
Makes it possible to support grids in which all the simulators share all central services of a Robust server EXCEPT assets. In other words, grids where the simulators' assets are kept in one DB and the users' inventory assets
...
are kept on another. When users rez items from inventory or take objects from world, an HG-like asset copy takes place between the 2 servers, the world asset server and the user's asset server. This makes the simulators independent of the central asset server.
Note that this an advanced configuration and requires some security strengthening coming up.
2014-05-04 20:54:42 -07:00
Diva Canto
7f570636f8
Please note: older simulators (0.7.6) still send the info about gzip in ContentType
2014-05-04 11:41:52 -07:00
Diva Canto
5a10da3ee8
Added a optional key between the group remote connectors, sim and service. This allows for more secure group services, to be used by collections of mutually-trusting grids.
2014-05-03 17:13:53 -07:00
Justin Clark-Casey (justincc)
53b72ab4b8
minor: Comment out Cacheitems debug log lines for now
2014-05-02 13:31:58 +01:00
Talun
3a2c099169
Mantis 7144 missing ATTACH_AVATAR_CENTER constant
...
This patch adds ATTACH_AVATAR_CENTER and ATTACH_NECK
2014-05-01 23:20:31 +01:00
Justin Clark-Casey (justincc)
c31d93cb6f
Fix issue where only one of multiple attachments on the same attachpoint for NPCs would be seen by other viewers.
...
It appears that at least Singularity 1.8.5 (but probably others) rely on attachment FromItemIDs being different to display more than one.
This commit resolves this by generating random IDs instead of always using UUID.Zero for NPCs.
Resolves http://opensimulator.org/mantis/view.php?id=7110
2014-05-01 22:24:21 +01:00
Justin Clark-Casey (justincc)
f0411dc128
minor: Use Vector2.Zero constant and only set in condition branch where it was missing in TryParseConsole2DVector(). xbuild still compiles.
2014-04-30 21:50:18 +01:00
Melanie
7c121a2acc
Change XEngine to call StateChange rather than RemoveScript on state changes
2014-04-30 20:56:49 +01:00
Melanie
f0eeb47262
Add the "StateChange" function to the async comand manager to differentiate
...
between state changes and script exit/reset.
2014-04-30 20:54:34 +01:00
BlueWall
44f533d95a
Assign value to 'vector' to fix building under xbuild and Monodevelop
2014-04-30 15:45:00 -04:00
Justin Clark-Casey (justincc)
7bb673a854
minor: Correct mistake in terrain flip error message from previous commit 5d01a1f
2014-04-30 19:41:11 +01:00
Justin Clark-Casey (justincc)
5d01a1ff4d
minor: Print output in response to terrain console commands on the console rather than in the log.
2014-04-30 19:24:17 +01:00
Justin Clark-Casey (justincc)
253110293a
Add "terrain show" console command which outputs terrain height for a given region co-ordinate.
...
For debug purposes.
2014-04-30 18:04:47 +01:00
Justin Clark-Casey (justincc)
5fc61942e0
minor: convert back some tabs to spaces that got into ScenePresence via recent patch bc969a6b
2014-04-29 20:15:29 +01:00
Justin Clark-Casey (justincc)
d4eee213a9
Restore terrain height and flying adjustments that were eliminated from non-megaregion paths in ScenePresence.MoveToTarget() by recent patch bc969a6b
2014-04-29 20:05:08 +01:00
Justin Clark-Casey (justincc)
2dbc18054e
Add regression test for NPC movement on a variable region.
...
Extends basic physics to allow av movement on a varregion (basic physics is only really useful for regression test purposes).
2014-04-29 19:29:16 +01:00
Oren Hurvitz
88f7a833dc
Improved HTTP logging
2014-04-29 07:59:17 +01:00
Oren Hurvitz
06e4fcd260
Fixed the UpdateAgentInformation CAP: the viewer expects the simulator to echo back the maturity that it sent
...
Without this change, attempts to change the maturity rating in the viewer's Preferences don't work.
2014-04-29 07:59:10 +01:00
Robert Adams
df89e15290
BulletSim: non-functional changes to debugging statements and formatting.
2014-04-28 18:36:50 -07:00
Robert Adams
63aea3a5f2
BUlletSim: move safeynet ground plane to lower altitude. Define new BulletSim
...
parameter 'TerrainGroundPlane' which defaults to -500.
BulletSim had assumed altitudes never went negative but that is not true. The
ground plane is just a safety net so things wouldn't fall to infinity.
2014-04-28 11:08:47 -07:00
Oren Hurvitz
cb8c3ba023
Removed dependency on Linq in OpenProfileClient
2014-04-28 16:41:02 +01:00
Justin Clark-Casey (justincc)
2e216aa056
Add missing [Test] decorator to actually get the basic scene creation test from 2227f51b
to run
2014-04-25 23:35:20 +01:00
Justin Clark-Casey (justincc)
9664273df6
Add basic regression test for creating a var region
2014-04-25 23:34:30 +01:00
Justin Clark-Casey (justincc)
2227f51b29
Add basic sanity regression test for creating a scene.
2014-04-25 23:16:07 +01:00
Justin Clark-Casey (justincc)
38acda9f29
Add regression test for terrain fill at two digit height and max ll height.
2014-04-25 23:01:24 +01:00
Justin Clark-Casey (justincc)
904baa6da6
Fix issue where terrain height values > 327 caused chaotic spiked terrain.
...
Per http://wiki.secondlife.com/wiki/Tips_for_Creating_Heightfields_and_Details_on_Terrain_RAW_Files#Notes_for_Creating_Height_Field_Maps_for_Second_Life
terrain heights up to 508 are possible on the LL grid (and were available on previous releases of OpenSimulator).
The obvious way to allow both this and equivalent -z values, is to rewiden the internal terrain height storage from short to int.
The memory tradeoff is most noticeable on the maximum 8192x8192 var region (equiv to 1024 normal regions), where it adds 128mb to resident use (128k on a normal region)
This is still better than the double used in previous releases.
This does not affect physics or data storage since they already use float and double respectively.
This may not be the final solution if we actually want to sacrifice -z, >327 or something else.
Relates to http://opensimulator.org/mantis/view.php?id=7076
2014-04-25 22:56:25 +01:00
Melanie
a108fcac95
Restore overload mode accidentally disabled in a prior commit. Add a new
...
config option, LogOverloads, to log when a thread pool overload occurs.
This option defaults to "True" because the logging data is useful for
diagnosing threading issues.
2014-04-25 21:34:29 +01:00
Melanie
2572ed9ed9
Adjust permissions to work hand in hand with what the viewer believes they are.
...
This fixes the issue of "Show in Search" seeming resetting at random.
2014-04-25 00:35:53 +01:00
Diva Canto
cf54df3ecf
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2014-04-24 14:12:04 -07:00
Diva Canto
1d9a9e6004
Fixes a long-standing bug related to god-mode change ownership of objects permissive, where the permissions of the children prims' inventory items were not changed. As a consequence, we couldn't control some of the objects imported via HG and OARs even in god mode.
2014-04-24 14:11:42 -07:00
Oren Hurvitz
0d898d8d8a
Revert "When linking a Hypergrid region, set the region's flags on the in-memory GridRegion immediately."
...
This reverts commit 463d0b2f8f
.
2014-04-24 19:08:50 +03:00
Oren Hurvitz
463d0b2f8f
When linking a Hypergrid region, set the region's flags on the in-memory GridRegion immediately.
...
(When using llTeleportAgent() this *specific* object is used for the teleport, so it should have the correct flags.)
2014-04-24 16:58:16 +01:00
Oren Hurvitz
bc06db3df4
- Created a standard function to send XML-RPC requests, which logs them like we do for other types of HTTP activity.
...
- Changed OpenProfileClient to use the new XML-RPC sending function
- Improved logging in WebUtil
2014-04-24 15:58:43 +01:00
Oren Hurvitz
e8a2eff2e8
Changed how UserProfile performs a fallback call using the OpenProfile API, because now JsonRpcRequest() returns an error result instead of throwing an exception
2014-04-24 15:58:43 +01:00
Oren Hurvitz
d62f0bc35d
Refactored: moved OpenProfileClient to a location where it can be used by both the Simulators and Robust
2014-04-24 15:58:42 +01:00
Oren Hurvitz
d15a3b10a3
When sending JSON-RPC calls (for UserProfile), use WebUtil instead of constructing the HTTP requests manually. This allows the calls to be logged when using "debug http all 6".
2014-04-24 15:58:41 +01:00
Oren Hurvitz
6efc203ce8
Fixed: hypergrid-linking stopped accepting the following format: " http://grid.example.com " (without a region name)
...
Fixes http://opensimulator.org/mantis/view.php?id=7128
2014-04-24 06:19:57 +01:00
Melanie
98c1940820
Merge branch 'master' of melanie@opensimulator.org:/var/git/opensim
2014-04-24 01:48:05 +01:00
Melanie
5dc0298f83
Apply logging flag to a spammy message that may have been overlooked.
...
No one needs to see every thread launch.....
2014-04-24 01:44:11 +01:00
Dev Random
7180690a14
Show Group name when land is group-owned
2014-04-23 23:29:17 +01:00
Justin Clark-Casey (justincc)
5092cbd77e
minor: Remove unused System.Linq reference and use ParcelFlags.None instead of 0 from previous commit cb1f28
2014-04-23 19:55:51 +01:00
Dev Random
cb1f2886cd
Prevent sending Land Properties for unprivileged users
2014-04-23 19:50:59 +01:00
Justin Clark-Casey (justincc)
7a5699224e
Fix regression test break on previous commit 328bc3b
2014-04-23 19:46:58 +01:00
Justin Clark-Casey (justincc)
328bc3b76e
Adjust avatar sit positioning on a target to pretty much exactly match that of the LL grid.
...
This uses an offset of 0.05 on the up vector of the sit orientation, after extensive analysis on
http://opensimulator.org/mantis/view.php?id=7096 and https://wiki.secondlife.com/wiki/Talk:LlSitTarget
This supersedes the previous adjustment in 5b73b9c4
which had been wrongly applied.
The maximum change is about 0.1 with a maximum height avatar.
This patch is all Aleric's work - I am applying manually in order to add these additional notes
2014-04-23 19:19:09 +01:00
Oren Hurvitz
b01e73cf27
Dynamic textures shouldn't be saved in the assets service (only in the simulator cache)
2014-04-23 14:42:40 +01:00
Oren Hurvitz
7eb12f96ec
Hypergrid: don't send Local assets to other grids
...
This commit also contains other changes, but they're all just for clarity. The only actual behavior change is to avoid Posting local assets.
2014-04-23 16:42:23 +03:00