Justin Clark-Casey (justincc)
da28fcd357
Stop flicking IsAttachment false and then true in AttachmentsModule.UpdateAttachmentPosition() in order to avoid a hud update race condition.
...
Previously, setting IsAttachment to false then true was necessary to serialize the updated attachment object information.
However, UpdateAttachmentPosition no longer does this update.
Whilst IsAttachment is set to false there is a race condition where the update thread can wrongly send hud object updates to clients that do not own the hud, resulting in screen artifacts.
2012-06-27 21:44:20 +01:00
Justin Clark-Casey (justincc)
1999338773
Fix bug where attachments would not retain position if just rotated and not moved.
...
This was because we were not setting AttachedPos in SOG.UpdateGroupPositionPR, unlike UpdateGroupPosition
2012-06-27 21:44:12 +01:00
Justin Clark-Casey (justincc)
95670d2086
refactor AttachmentsModule tests to use a common method for standard attachment item setup
2012-06-27 21:44:04 +01:00
Justin Clark-Casey (justincc)
af2c48449c
Add regression test for updating attachment position
2012-06-27 21:43:58 +01:00
Justin Clark-Casey (justincc)
ffc6110edf
Add item id, name, prim name and id to log message when state exists but loading fails.
...
Drop logging about memory limit exceeded to warn from error
2012-06-27 21:43:49 +01:00
Justin Clark-Casey (justincc)
1edd1f93c1
Retrigger build - last jenkins run was glitched
2012-06-27 21:41:49 +01:00
Justin Clark-Casey (justincc)
b6e42da21a
Add state file location to errors logged when there's some issue with retrieving state (e.g. exceeds memory limit)
2012-06-27 21:41:34 +01:00
Justin Clark-Casey (justincc)
2e0402433d
Use HasPrivateAttachmentPoint properties in SOG.DeleteGroupFromScene() instead of magic numbers
2012-06-27 21:41:24 +01:00
Justin Clark-Casey (justincc)
d19600e257
refactor: use SOG.HasPrivateAttachmentPoint in SOP.SendTerseUpdateToClient() instead of attachmentpoint magic numbers.
2012-06-27 21:41:15 +01:00
Justin Clark-Casey (justincc)
a6d97e6353
As with LLSDInventoryItem from commit 01a2b0b
, send type values in LLSDInventoryFolder for inventory CAPs as integers rather than strings.
...
Should also resolve some issues with exceptions being thrown in some inventory fetches.
2012-06-20 23:56:25 +01:00
Justin Clark-Casey (justincc)
8eb39eb3ac
Lower warn logging on not having friends/group module on permissions to debug.
...
It's a valid configuration not to have these modules, but I think it's still worth logging the fact that certain permissions won't work (always return true)
2012-06-20 23:55:58 +01:00
Justin Clark-Casey (justincc)
553ac6335d
minor: Lower flotsam asset cache warning about not having a FlotsamCache.ini to debug
...
It's perfectly okay not to have this section.
2012-06-20 23:55:51 +01:00
Justin Clark-Casey (justincc)
32a2515817
Change default logging level for XEngine to WARN instead of DEBUG.
...
This is to reduce log spam from script loading, which is especially spammy for avatar movements with scripted attachments.
All important messages are at warn or above.
If you still want/need to see these messages, set <level value="DEBUG"/> in the <logger name="OpenSim.Region.ScriptEngine.XEngine"> section of OpenSim.exe.config.
This affects no other package logs, which still output at the root configured level (currently DEBUG by default).
2012-06-20 23:55:42 +01:00
Justin Clark-Casey (justincc)
a0482bccc7
Remove STARTUP COMPLETE message from the startuplogo.txt file and into main logging
2012-06-20 23:55:36 +01:00
Justin Clark-Casey (justincc)
3291e256ba
Comment out the neighbour and land in connectors from info logging that they are starting up
2012-06-20 23:55:27 +01:00
Justin Clark-Casey (justincc)
fb7573f713
Comment out recently added log message detailing number of scripts started when compile queue empties for now
2012-06-20 23:55:16 +01:00
Justin Clark-Casey (justincc)
4684207d6e
Raise some IO associated Exception logging in XEngine to error level, in line with other similar cases.
...
Remove more unnecessary Close() calls - these are being triggered by the Dispose() called when exiting the using statement for these sdk io objects.
2012-06-20 23:55:09 +01:00
Justin Clark-Casey (justincc)
499b778391
Log how many scripts are candidates for starting and how many are actually started.
...
Adds DebugLevel infrastructure to XEngine though currently commented out and unused.
2012-06-20 23:54:16 +01:00
Justin Clark-Casey (justincc)
9779ceded5
If RegionReady is active, don't falsely say that logins are enabled in the main scene loop before RegionReady is signalled when initial script compilation finishes.
...
Also raises this logging level to Info from Debug since this information is of high importance. This matches the behaviour of the RegionReady module
2012-06-20 23:44:28 +01:00
Justin Clark-Casey (justincc)
512d0ac411
minor: If logging because mesh/sculpt data isn't present for an object, log object UUID rather than local id, since UUID doesn't potentially vary between simulator starts.
2012-06-20 23:44:16 +01:00
Justin Clark-Casey (justincc)
981c7d63a0
Like the assembly and text files, only write the c#-lsl linemap in XEngine.SetXMLState() if the trust binaries flag is set.
...
This doesn't affect other locations where the map is written, such as on script compilation.
2012-06-20 23:44:03 +01:00
Justin Clark-Casey (justincc)
7bd1601a3f
minor: Add a little more detail to IOException logging in XEngine.SetXMLState()
...
Also removes superflous Close() commands for statements taking place within using() constructs
Also adds some comment out debug log messages for future use.
2012-06-20 23:43:47 +01:00
Justin Clark-Casey (justincc)
3aef006e78
Change read config paramter from max_urls_per_simulator to max_external_urls_per_simulator, which is what it was meant to be
2012-06-20 23:33:54 +01:00
Justin Clark-Casey (justincc)
9a6aa528db
Fix bug introduced in commit c6e3752
(13 Jun 2012) where poll responses would always return OK even if some other status code had been set
2012-06-20 23:33:46 +01:00
Justin Clark-Casey (justincc)
02a163848c
Implement max_external_urls_per_simulator setting in [LL-Functions] to allow configuration of how many urls can be set up by llRequestURL()
...
Defaults remains as 100.
This setting is per simulator instead of per region due to how the url script module is structured.
2012-06-20 23:33:38 +01:00
Justin Clark-Casey (justincc)
b9f122be07
Add region name to UseCircuitCode log messages
2012-06-20 23:33:27 +01:00
Justin Clark-Casey (justincc)
e64ca361df
Put all debug console commands into a single Debug section rather than scattering them over other categories
2012-06-20 23:33:13 +01:00
Justin Clark-Casey (justincc)
8a11c4e7d4
Make the "debug http" command available for robust as well as the simulator. This allows one to see incoming requests as they happen.
...
This required making everything use the common MainServer class for registering and retrieving http servers, rather than duplicate structures.
2012-06-20 23:33:04 +01:00
Justin Clark-Casey (justincc)
584a076bec
Add main instance to internal MainServer.m_Servers list to simplify internal logic.
...
This does require the server to be added before it is set as the main Instance
2012-06-20 23:32:57 +01:00
Justin Clark-Casey (justincc)
88596d6097
minor: Tell user the current debug http level if "debug http" console command is executed without a level parameter
2012-06-20 23:32:44 +01:00
Justin Clark-Casey (justincc)
84d97b3bc0
When setting debug http level, do this for all known http servers, not just the main instance.
2012-06-20 23:32:38 +01:00
Justin Clark-Casey (justincc)
2b4e97eeaf
Make XMLRPCModule use an existing HTTP server if one already exists on the desired port.
2012-06-20 23:32:30 +01:00
Justin Clark-Casey (justincc)
a544280ef2
Get rid of some unnecessary null checks in RegionApplicationBase.StartupSpecific() - a constructor can never return null.
...
Also adds some method doc to MainServer
2012-06-20 23:32:23 +01:00
Justin Clark-Casey (justincc)
3a0f9836f3
minor: Extend 'debug http' usage statement to 0..3 from 0..2
2012-06-20 23:32:12 +01:00
Justin Clark-Casey (justincc)
4bfac5688d
Shuffle "debug http" levels so that 1 and 2 now cause different levels of warn to be logged if we receive invalid xml for xmlrpc.
2012-06-20 23:32:06 +01:00
Justin Clark-Casey (justincc)
0fb93042c6
Fix a regression in BaseHttpServer.HandleXmlRpcRequests() from recent c6e3752
...
Accidentally make responseString null by default instead of String.Empty.
It needs to be something in case the XmlRpcRequest deserialize throws an exception due to bad xml (a failure which we silently swallow!)
2012-06-20 23:31:50 +01:00
Melanie
a3586a7c4b
Fix not sending TransferInfo when an asset is not found. This clogs
...
up the sound pipeline in the viewer.
2012-06-20 23:31:02 +01:00
Justin Clark-Casey (justincc)
d4ff56710b
Don't include time to transmit response back to requester when assessing slow handling of requests.
...
This is to avoid logging a 'slow' request when the source of delay is the viewer in processing a response.
This is not something we can do much about on the server end - it's server-side delay that we're interested in.
To ensure consistency, this commit also had to refactor and simplify inbound non-poll network request handling, though there should be no functional change.
IOSHttpResponse no longer exposes the Send() method, only classes in OpenSim.Framework.Servers.HttpServer should be doing this.
Only the GetTextureHandler was sending its own response. Now it leaves this to BaseHttpServer, like all other core handlers.
2012-06-20 23:29:49 +01:00
Justin Clark-Casey (justincc)
6219c137e1
Fix very recent regression in 917d753
where I put the ++updatesThisCall outside the batching part of ProcessEntityUpdates()
...
This stopped any batching happening and since this method is called periodically updates were sent very slowly
2012-06-14 04:00:32 +01:00
Justin Clark-Casey (justincc)
da3877a77d
If we're going to discard a terse update block because it's now someone else's hud, then don't still add it to the list of blocks for the update message.
2012-06-14 04:00:22 +01:00
Justin Clark-Casey (justincc)
10ed7e3bbc
correct wrong incomplete comment from previous commit 3c3ea19
in AttachmentsModule
2012-06-14 04:00:04 +01:00
Justin Clark-Casey (justincc)
f248f8bf31
Fix a bug where scene objects attached as HUDs through scripts would not disappear for other avatars.
...
We do this by sending a kill message for that object to all other avatars apart from the one that has the hud.
2012-06-14 03:59:56 +01:00
Justin Clark-Casey (justincc)
6f2031001b
Fix a race condition where an object update for a hud could be sent to non-owner avatars if the hud was attached directly from within the region.
...
If this happens, then the non-owners would see unremovable huds that they did not own until relog, and sometimes even beyond that.
This was due to a race between the entity update and the attachment code when moving an object from within scene to a hud.
2012-06-14 03:59:46 +01:00
Justin Clark-Casey (justincc)
1c5ad8e9ab
Add SOG.HasPrivateAttachmentPoint to tell if a SOG has a private attachment point. HUDs attachment points are private.
...
Change SOP.SendFullUpdateToClient() and SoundModule.PlayAttachedSound() to use this rather than different magic number formulations.
This also corrects a bug in PlayAttachedSound() where the code assumed that all attachment points over 30 were HUDs.
It appears this is no longer true with Neck and Root (Avatar Center)
2012-06-14 03:59:39 +01:00
Justin Clark-Casey (justincc)
d8d8b8fc9b
minor: remove unnecessary IsAttachment = false setting for new object in UploadObjectAssetModule, property always starts as false
2012-06-14 03:59:09 +01:00
Justin Clark-Casey (justincc)
719efdaf1f
minor: refactor part of LLClientView.ProcessEntityUpdates() to remove duplicate code
2012-06-14 03:58:54 +01:00
Justin Clark-Casey (justincc)
6a8e3907ca
Remove long obsolete and unused IClientAPI.KillEndDone()
2012-06-14 03:18:23 +01:00
Justin Clark-Casey (justincc)
5a1b8fc6f7
Add ObjectUpdate as one of the packets that can be screened out when setting debug packet level
2012-06-14 03:18:15 +01:00
Justin Clark-Casey (justincc)
00ac962db7
In the osGetGrid functions, if the [GridInfo] section does not exist then return "Configuration Error", as already happens if there is no GridInfoURI
2012-06-14 03:18:08 +01:00
Justin Clark-Casey (justincc)
cb518ad68c
Add "deregister region" by uuid command to grid service to allow manual deregistration of simulators.
...
Useful if a simulator has crashed without removing its regions and those regions have been reconfigured differently
2012-06-14 03:18:00 +01:00