Justin Clark-Casey (justincc)
bffdf20721
Fix memory leak where removing an NPC did not remove its circuits.
...
This was because we were removing by circuitcode where NPCs have no code.
Now removing by agent ID instead.
This commit also fixes the "show circuits" console command to work properly where the circuit has no associated IP address.
2012-11-28 02:57:13 +00:00
Justin Clark-Casey (justincc)
a4b64d4854
Add "force gc" region console command which manually invokes garbage collection.
...
For debugging purposes.
2012-11-28 02:57:02 +00:00
Melanie
fe195e0a9c
Deep copy the collection of at_target objects so it can't be modified while
...
it's being iterated
2012-11-28 02:56:53 +00:00
Justin Clark-Casey (justincc)
9d70f48207
minor: Fix verbose IAR save message to make it a bit clearer that item data is being saved at that point, not asset data.
2012-11-28 02:56:44 +00:00
Justin Clark-Casey (justincc)
d83df8c1cf
Fix "save iar" hanging permanently if the asset request phase times out.
...
Unlike "save oar", this was happening on the same thread as the original request.
The timeout happens on another so the original thread is never aborted.
On "save oar" this leaves the thread hanging (still bad) but on "save iar" it left the console thread hanging.
Temporary fix is to make "save iar" do asset request on a separate thread, like "save oar".
Longer term fix will be to restructure asset save to use a ManualResetEvent rather than a separate timeout timer.
2012-11-28 02:56:34 +00:00
Justin Clark-Casey (justincc)
c7c6c12146
minor: Make the error thrown logged when a simulator in grid mode is trying to set estate owner to a user that doesn't exist a little more obvious.
2012-11-28 02:56:22 +00:00
SignpostMarv
e83a4c24ee
Formatting and casing correction in WorldCommModule, trailing new line in OSSL to get git diff to not complain
2012-11-28 02:56:09 +00:00
Justin Clark-Casey (justincc)
a1669be6c3
minor: Add comment as to why we are pulcking plain old ints out of the LSL_List when converting values from LSL for modInvoke()
2012-11-28 02:55:58 +00:00
SignpostMarv
e36799f515
system ints can end up in LSL lists, which can cause counter-intuitive unknown list element type errors in ConvertFromLSL (via modInvoke)
2012-11-28 02:55:36 +00:00
Justin Clark-Casey (justincc)
186fe5f7b0
Comment out InventoryTransferModule.NeedSceneCacheClear() and invocations since the call itself does nothing and the return value is ignored by all callers.
...
This is a very old method (+4 years) so is probably confusing code cruft.
2012-11-28 02:55:26 +00:00
Justin Clark-Casey (justincc)
27206eccef
minor: if a scene is already shutting down on Scene.Close(), warn and exit instead of attempting to run another shutdown concurrently.
...
Thanks to Oren Hurvitz for this change.
2012-11-28 02:55:15 +00:00
Oren Hurvitz
62c0d60d3e
Changed "course" to "coarse" in several places
2012-11-28 02:55:08 +00:00
Oren Hurvitz
c39342df3e
Changed duplicate Asset ID's to unique ID's in CollisionSoundsAssetSet.xml
2012-11-28 02:55:00 +00:00
Justin Clark-Casey (justincc)
458a103529
In Scene.Close(), dispose of the physics scene after base.Close() since script events can still access Physics scene until the script engine shuts down (triggered off base.Close())
...
XEngine listeners to EventManager.OnShutdown which is triggered from base.Close().
Possibly it could listen for the earlier OnSceneShuttingDown instead, but the easier solution right now is to relocate disposal of the physics scene.
This bug has existed since c150320
(Thu Jul 26 15:27:18 2012) and was in 0.7.4
2012-11-28 02:54:52 +00:00
Justin Clark-Casey (justincc)
c22a37e7a6
Fix script error messages not showing up in viewer 3 and associated viewers.
...
Viewer 3 will discard such a message if the chat message owner does not match the avatar.
We were filling the ownerID with the primID, so this never matched, hence viewer 3 did not see any script error messages.
This commit fills the ownerID in with the prim ownerID so the script owner will receive script error messages.
This does not affect viewer 1 and associated viewers which continue to process script errors as normal.
2012-11-28 02:54:31 +00:00
Justin Clark-Casey (justincc)
01a8a65d75
Get osNpcCreate() and osNpcLoadAppearance() to generate a script error if appearance notecard does not exist, rather than returning UUID.Zero or silently failing.
2012-11-28 02:54:25 +00:00
Justin Clark-Casey (justincc)
28ced402d8
When scripts generate expected exceptions (e.g. due to checked bad parameter) throw ScriptException instead of just a plain old exception.
...
This is to make it easier to distinguish these exceptions from unexpected OpenSimulator problems internally and in regression tests.
No functional changes.
2012-11-28 02:54:17 +00:00
Justin Clark-Casey (justincc)
95e35fe84a
Make osNpcCreate() return UUID.Zero instead of throwing an exception if notecard name is invalid. Make osNpcLoadAppearance() fail silently in same circumstance rather than throwing exception.
2012-11-28 02:54:05 +00:00
Justin Clark-Casey (justincc)
3692ff2bdb
Add TestOsNpcLoadAppearance()
2012-11-28 02:53:55 +00:00
Justin Clark-Casey (justincc)
7235a5fed4
Move npc creation tests involving appearance from OSSL_ApiAppearanceTest to OSSL_ApiNpcTests
...
This is a more intuitive location.
2012-11-28 02:53:46 +00:00
Justin Clark-Casey (justincc)
614e5b52b8
Allow "show object", "show part", "dump object" and "delete object" to accept a local ID as well as a UUID.
...
This means that the sub-commands are now id rather than uuid, e.g. show object id
2012-11-28 02:53:39 +00:00
Justin Clark-Casey (justincc)
35ab31fb5f
Add "dump object uuid" console command. This allows any object in the scene to be serialized and dumped to XML for debug purposes.
2012-11-28 02:53:15 +00:00
Justin Clark-Casey (justincc)
636994eea6
minor: Move co-ordinate related help to object commands to common ConsoleUtil.CoordHelp
2012-11-28 02:53:06 +00:00
Justin Clark-Casey (justincc)
146ac5ceda
Make it possible to turn the base UDP object packet pools on and off whilst running via the "debug lludp pool <on|off>" console command. For debug purposes.
...
This does not currently apply to the higher LLUDP packetpool.
2012-11-28 02:52:53 +00:00
Justin Clark-Casey (justincc)
5413bfec30
Add object count stats for new IncomingPacket and UDPPacketBuffer pools if they are enabled. Add count stats for existing LLUDP pool.
...
This introduces a pull stat type in addition to the push stat type.
A pull stat takes a method on construction which knows how to update the stat on request.
In this way, special interfaces for pull stat collection are not necessary.
2012-11-28 02:52:46 +00:00
Justin Clark-Casey (justincc)
f39c2cd714
minor: Get content type handler logger to log "unset" for the content type instead of blank if no content type was set.
2012-11-28 02:52:40 +00:00
Justin Clark-Casey (justincc)
e0ef2bdf81
minor: Use LogIncomingToContentTypeHandler() method for incoming HTTP data where this wasn't already used.
...
This allows log level 5 (log sample or large part of incoming post data) to operate and removes copy/paste.
2012-11-28 02:52:29 +00:00
PixelTomsen
efc09e8022
SQLite DB: some values of land data will be not saved / loaded
...
http://opensimulator.org/mantis/view.php?id=6370
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2012-11-28 02:52:17 +00:00
Justin Clark-Casey (justincc)
1790355f3e
minor: Rename assetCache constructor param in UUIDGatherer to assetService which is what it is.
2012-11-28 02:51:42 +00:00
Justin Clark-Casey (justincc)
d0d004c6ff
Add method doc for IPresenceService
2012-11-28 02:51:36 +00:00
Justin Clark-Casey (justincc)
ee4abb681e
Improve efficiency of friends notification by only make one PresenceService call for all friends rather than one for each friend.
...
However, large groups could still take a very long time since we still need to message each avatar on different simulators.
2012-11-28 02:51:24 +00:00
Justin Clark-Casey (justincc)
9e3605d952
Fix build break from commit e469879
2012-11-28 02:51:11 +00:00
Justin Clark-Casey (justincc)
0df4927710
Add "debug groups verbose <true|false>" region console command
...
This allows one to turn on super-verbose groups debug logging on and off whilst the region is in operation.
2012-11-28 02:51:01 +00:00
Justin Clark-Casey (justincc)
9d4415429d
minor: Increase attachment name field from 36 to 50 chars in "attachments show" report
2012-11-28 02:50:47 +00:00
SignpostMarv
c86ac36876
altering documentation for llGetLinkName, as the current documentation is rather lengthy for a "summary".
2012-11-28 02:50:23 +00:00
SignpostMarv
4a4d800523
ensuring that operand order in llGetLinkName is internally consistent
2012-11-28 02:49:44 +00:00
Justin Clark-Casey (justincc)
01c148bbce
minor: comment out currently unused logger in DynamicTextureModule
2012-11-28 02:49:28 +00:00
Justin Clark-Casey (justincc)
1cbe4363a3
Make "show part" console commands print out information about each item the part contains
2012-11-28 02:49:21 +00:00
Justin Clark-Casey (justincc)
c0254d914f
minor: Convert ad-hoc list building in ObjectCommandsModule to use ConsoleDisplayList
2012-11-28 02:49:10 +00:00
Justin Clark-Casey (justincc)
53112f1e80
Add local and UUID to information output of "show object" and "show part" region console commands
2012-11-28 02:49:02 +00:00
Justin Clark-Casey (justincc)
0f312c58ca
Add --full option to "show object name/uuid/pos" to show info on all parts of an object, not just whole object summary information.
2012-11-28 02:48:54 +00:00
Justin Clark-Casey (justincc)
2ca520c1eb
Add number of inventory items to information displayed via "show part" console command
2012-11-28 02:48:47 +00:00
Justin Clark-Casey (justincc)
c9b7ac2ae5
minor: Remove event method doc from LLClientView that I forgot in the last commit (1de80c)
2012-11-28 02:47:47 +00:00
Justin Clark-Casey (justincc)
6e2ffd7050
minor: move recent OnAgentUpdate/OnPreAgentUpdate event doc up into IClientAPI from LLClientView
2012-11-28 02:47:40 +00:00
Justin Clark-Casey (justincc)
8726748e22
Reuse the same AgentUpdateArgs object for each AgentUpdate UDP packet (of which there are 10 a second) rather than constructing a new one every time.
...
We can do this because AgentUpdate packets are handled synchronously.
2012-11-28 02:47:31 +00:00
Justin Clark-Casey (justincc)
73c2db9e8f
Explicitly return only the incoming AgentUpdate packet as this is the only one we pool atm, rather than attempting to return all incoming packets.
2012-11-28 02:47:24 +00:00
Justin Clark-Casey (justincc)
c1cab3e752
If RecycleBaseUDPPackets = true, also pool IncomingPackets to reduce memory churn
2012-11-28 02:47:15 +00:00
Justin Clark-Casey (justincc)
713fdda7f8
minor: Make BasicCircuitTests.SetUp() call overriden base method instead of ignoring it.
2012-11-28 02:47:08 +00:00
Justin Clark-Casey (justincc)
baa599e5b0
Add LastMemoryChurn stat using existing data so we can more quickly tell how memory churn changes rather than waiting for the average to move.
2012-11-28 02:47:01 +00:00
Justin Clark-Casey (justincc)
014c533ebe
Add optional pool for the UDPPacketBuffer objects that handle all incoming UDP data.
...
Even when an avatar is standing still, it's sending in a constant stream of AgentUpdate packets that the client creates new UDPPacketBuffer objects to handle.
This option pools those objects. This reduces memory churn.
Currently off by default. Works but the scope can be expanded.
2012-11-28 02:46:53 +00:00