abf1836b81
Fix OfflineIMEmail value overwriting every time its called. The request was receiving a blank user prefs object to populate but then was checking for an email address. When this failed the email address was pulled from the User Account service and the empty prefs now including the email was saved before being loaded again to be returned. This was overwriting all other settings in the prefs. This fix returns the existing prefs first before checking the email address is set, and only updates email if missing.
2015-01-21 00:57:06 +00:00
372a7bf78e
minor: Comment out log line for the SimulatorFeatures cap request for now to reduce log verbiage. Please revert if still required.
2015-01-21 00:34:51 +00:00
25dd30ddb6
minor: Fix some CR line endings in Scene.Inventory.cs
2015-01-21 00:33:54 +00:00
a846e63c70
If [Permissions] serverside_object_permissions = false or the undocumented propogate_permissions = false, don't propogate permissions of prim inventory items.
...
This was a regression from 13f31fdhttp://opensimulator.org/mantis/view.php?id=7399
2015-01-21 00:21:27 +00:00
ac93ba9f85
minor: correct SceneCommunicationService.LogHeader spelling
...
Relates to http://opensimulator.org/mantis/view.php?id=7337
2015-01-20 00:19:33 +00:00
4b8215c893
minor: comment out unusued logging objects in some pCampbot behaviour classes
2015-01-20 00:18:25 +00:00
24ef043395
Make failures in PollServiceHttpRequest.DoHTTPGruntWork() actually log the exception on error
2015-01-19 23:52:34 +00:00
1f04e1bc23
minor: In AttachmentsModule.UpdateKnownItem use the existing IInventoryAccessModule reference that other methods are already using rather than fetching its own copy.
2015-01-17 00:08:16 +00:00
2995868176
Make XEngine.SaveAllState() actually do this instead of script maintenance
2015-01-17 00:05:13 +00:00
0eb268e265
minor: remove old commented out objectRemoved bool in XEngine.OnRemoveScript()
2015-01-16 23:59:08 +00:00
58f7efc41a
Add clearqueue code adjustment that should have been in previous commit faaf47a
2015-01-16 23:57:51 +00:00
faaf47a86f
Prevent a race condition between the script engine backup thread and script removal by locking on the script's EventQueue and only proceeding if it's flagged as still running.
...
Relates to http://opensimulator.org/mantis/view.php?id=7407
2015-01-16 23:55:11 +00:00
8d724e90de
For scripts in attachments, don't save .state files apart from the initial one as these are ignored since .state is saved in the attachment's asset.
...
This eliminates pointless work and exceptions when an appdomain is unloaded whilst an attachment script state is persisted.
Adds test for this case.
Relates to http://opensimulator.org/mantis/view.php?id=7407
2015-01-16 22:46:48 +00:00
97ac80d664
minor: Suppress the log messages when user profiles data is requested for an NPC or an HG user with no set server URI to avoid log spam.
...
Messages concerning failure to contact a given user profiles service are preserved by logging within called code with the agent ID.
If the "No Presence - foreign friend" log message is important then please revert.
Relates to http://opensimulator.org/mantis/view.php?id=7414
2015-01-16 00:54:32 +00:00
b22c072c40
Fix a recent regression with HG asset posting to other grids where the assets were no longer being posted.
...
Addresses regression from 08606ae
2015-01-15 23:44:34 +00:00
beef41f24c
Stop simulators attempting to contact registered but offline regions (RegionFlags.Persistent but not RegioNFlags.RegionOnline) on startup and when an avatar completes a teleport.
...
This eliminates spurious network calls and failure reporting.
This is done by adding RegionFlags to the GridRegion returned data in a backward compatible way as an alternative to multiple IGridService.GetRegionFlags() calls
Using a simulator or a grid service older than this commit will just see previous behaviour.
2015-01-14 19:45:19 +00:00
8cc590cf80
And finally renamed the classes themselves.
2015-01-13 22:21:50 -08:00
034fc325c0
Renamed the folder too.
2015-01-13 21:25:11 -08:00
a626de696a
Renamed these 2 files, because their names are misleading. This is no longer called WebFetchInventoryDescendents, and we no longer use that cap; the viewers use FetchInvventoryDescendents2.
2015-01-13 21:24:01 -08:00
9363d4c784
Use ToString() on uuids returned in PGSQLUserProfilesData.GetUserImageAssets(). These are Guids rather than strings so casting to string generates a casting exception.
...
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-14 00:00:02 +00:00
02f2352ad5
Fix PGSQLUserProfilesData.GetUserPreferences error when no usersettings yet exist by inserting missing ID parameter.
...
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-13 23:52:52 +00:00
71d73777d9
Revert "Remove quotes from column selection in PGSQLUserProfilesData.UpdateAvatarProperties()"
...
This reverts commit fdecf4f610
2015-01-13 21:53:28 +00:00
8f37a61912
Revert "Remove quotes from column selection in PGSQLUserProfilesData.UpdateAvatarInterests()"
...
This reverts commit f31feef6c1
2015-01-13 21:53:18 +00:00
39989eda3b
Revert "Remove quotes from column selection in PGSQLUserProfilesData.GetUserImageAssets()"
...
This reverts commit bd9539c2a7
2015-01-13 21:53:04 +00:00
38f2b89248
Revert "Remove misstaken quotes from column selection in PGSQLUserProfilesData.GetUserAppData()"
...
This reverts commit 0794a40378
2015-01-13 21:52:43 +00:00
f9d2121bcf
Revert "Remove quotes from column selection in PGSQLUserProfilesData.SetUserAppData()"
...
This reverts commit 59c0df962a
2015-01-13 21:50:11 +00:00
24695dc05b
Fix PGSQLUserProfilesData.UpdateUserPreferences() imviaemail and visible casts. These should be left as bools, not converted to strings.
...
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-13 21:40:49 +00:00
46e8a99526
Change PGSQLUserProfilesData.UpdateUserPreferences() to directly pass the UUID to the uuid parameter instead of its ToString()
...
This may well be the cause behind "operator does not exist: uuid = character varying" pgsql errors.
If so, the other instances will also be changed.
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-13 21:13:57 +00:00
492d49eb08
Fix MySQL and PGSQL *UserProfilesData.GetUserAppData() calls to correctly set the UserId parameter instead of the non-existing Id parameter when writing a record because none yet exists.
...
SQLite version is already correct for this.
2015-01-13 20:33:36 +00:00
59c0df962a
Remove quotes from column selection in PGSQLUserProfilesData.SetUserAppData()
...
This may have been preventing it from working.
2015-01-13 20:27:37 +00:00
55ae9a7d10
Remove extraneous colon when setting TagId parameter in PGSQLUserProfilesData.GetUserAppData()
2015-01-13 20:15:37 +00:00
55e081548c
Fix bug where gathering the clientstack..OutgoingPacketsQueuedCount stat would fail with a casting exception for scenes with NPCs
...
Present since 51eb8fa
2015-01-13 19:27:29 +00:00
0794a40378
Remove misstaken quotes from column selection in PGSQLUserProfilesData.GetUserAppData()
2015-01-13 19:20:27 +00:00
bd9539c2a7
Remove quotes from column selection in PGSQLUserProfilesData.GetUserImageAssets()
...
This may have been preventing it from working.
2015-01-13 18:57:32 +00:00
f31feef6c1
Remove quotes from column selection in PGSQLUserProfilesData.UpdateAvatarInterests()
...
This may have been preventing it from working.
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-13 18:54:41 +00:00
fdecf4f610
Remove quotes from column selection in PGSQLUserProfilesData.UpdateAvatarProperties()
...
This may have been preventing it from working.
2015-01-13 18:52:49 +00:00
0cc75a0a3c
Remove quotes from column selection in PGSQLUserProfilesData.GetAvatarNotes()
...
This may have been preventing it from working.
2015-01-13 18:50:34 +00:00
b38a552fd6
Remove quotes from field selection in PGSQLUserProfilesData.GetAvatarPicks()
...
This may have been preventing it from working.
2015-01-13 18:47:51 +00:00
43b094f549
minor: correct two exception messages in PGSQLUserProfilesData where I copy/pasted AgentInterestsUpdate twice
2015-01-13 18:42:04 +00:00
02dcfcf537
Remove the locking in PGSQLUserProfilesData which was buggy (Lock object wasn't set!) and is unnecessary.
...
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-12 23:39:27 +00:00
0c31eb0a5d
Add the missing deleted and re-added JobEngine class from the previous commit 8e1e8a0
2015-01-12 20:59:58 +00:00
8e1e8a0920
Make the performance controlling job processing threads introduced in conference code use a generic JobEngine class rather than 4 slightly different copy/pasted versions.
2015-01-12 20:56:37 +00:00
2fd252f5a9
SimulatorFeatures: the viewer also takes GridName in OpenSim extras. Added that (plus GridURL, in case viewers want to use it too) to the GridService that gives out that info to simulators.
2015-01-10 10:32:33 -08:00
20b34135cb
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2015-01-09 08:32:40 -08:00
e2dd15625f
Added GetDisplayNames capability. For now, we don't actually use display names, and this cap returns the regular name. But this moves the server side into the newer, preferred, protocol used by the viewer for fetching the names of agents in the scene given their UUIDs. (the old protocol is via UDP). This works fine in my limited tests, but could use further testing by others.
2015-01-09 08:31:56 -08:00
38590a4fad
Get PGSQL UserProfilesData to log the exception trace for debugging rather than just the exception message.
2015-01-09 00:19:48 +00:00
dbd500db42
minor: Add event name to existing debug output when a script event fails with an exception. To aid debugging.
2015-01-08 22:59:29 +00:00
801a86ca03
When inspecting a script or notecard, also try to look up any assets embedded therein.
...
This is primarily to fix an issue where inventory items for NPC attachments would not be saved in archives as the assets referenced in the appearance notecard were not checked in this manner.
Relates to http://opensimulator.org/mantis/view.php?id=7376
2015-01-08 20:36:03 +00:00
08606ae409
Make the IteratingUuidGatherer the only UuidGatherer.
...
This UUID gatherer provides a superset of the previous gatherer's functionality
as it also allows the caller to control gathering iterations for load purposes.
2015-01-08 20:21:40 +00:00
9dc4b2c479
Commented out clear_registry_ because (1) it isn't clearing up anything anymore -- mono addins moved to suffix -002 at least since BlueWall updated it; (2) we shouldn't clear the registry, period. People who run many sims from the same bin folder need to configure each sim to use its own RegistryLocation, just like they configure them to use their own port.
2015-01-07 20:01:54 -08:00
14b3ee636d
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2015-01-07 11:09:04 -08:00
46ab59723d
Added a different/better way of specifying data services in DataSnapshot -- using DATA_SRV_ keys, one per service. This allows 3rd party modules to add data services automatically.
2015-01-07 11:04:23 -08:00
6e2b532255
BulletSim: fix line ending problems.
2015-01-07 06:46:08 -08:00
4959dbba5e
BulletSim: make computation of hole cut in hull tester explicit
...
math showing the odd PrimitiveBaseShape value rather than a constant.
2015-01-07 06:42:41 -08:00
700543b161
BulletSim: tweek step parameters and logic to make walking up steps
...
closer to SL. This change should address small floor edges acting like
walls, approaching a step at any angle (other than walking backwards)
will allow walking up, and reducing the avatar pop-up when going up
stairs.
2015-01-07 06:39:29 -08:00
8e562f04d1
Donation of robust network connectors for estate service, as promised. This allows to have one central database for estates without having to open the MySql port. This is off by default, so not to disturb everyone's existing installations. To use it, see GridCommon.ini.example [EstateDataStore] section and Robust*.ini.example's new additions.
...
Note that I also made things consistent by removing both the EstateDataService and the SimulationService into their own dlls, just like all other services. They really didn't belong in Services.Connectors, since everything in that component is about network connectors to robust backends. We may have too many dlls, and at some point it might not be a bad idea to merge all services into one single dll, since they all have more or less the same dependencies.
2015-01-06 21:24:44 -08:00
502aa7bb15
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2015-01-04 19:07:40 -08:00
ce1a87b784
Added overloaded LoadArchSpecificWindowsDll, to help addins load native libraries.
2015-01-04 19:06:49 -08:00
103aad27f2
BulletSim: comment out the reference to BSShapeHull in BulletSim tests
...
which seems to cause the tests to fail when compiled on the OpenSim
build system. It compiles and runs everywhere else. More research is needed.
2015-01-04 14:26:50 -08:00
a617159f8b
BulletSim: correct some of the debugging input and output of PrimitiveBaseShape.
...
Whoever defined that structure was really into esoteric coding.
2015-01-04 13:52:14 -08:00
53c8318124
Added utility function that simplifies configuration loading of all addins.
2015-01-03 21:53:18 -08:00
b379eaa169
Remove the extra key expansion added in commit a88bc50a16. It's not needed.
2015-01-03 07:56:00 -08:00
04e76dc5d6
Comment out the suppression of console output for mono addins in robust too. Seriously, ppl, let's not ignore important warning messages!
2015-01-02 21:47:23 -08:00
63e771b593
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2015-01-02 09:18:05 -08:00
bd2ec3edf5
Bug fix in LoadPLugin so that it can take paths to dlls that look like this "C:\foo\MyDll.dll:MyType" -- the split on : was messing things up.
2015-01-02 09:16:39 -08:00
7d1c59b8e3
Changed the Robust-as-addin version number to match OpenSim release numbers.
2015-01-02 09:15:30 -08:00
7c2aeb9e8e
Fix cut-and-paste error that made StatsManager web fetch queries
...
fail for container specification.
2015-01-01 09:39:07 -08:00
2496da2dac
BulletSim: remove compile reference error trying to figure out why mono compiling doesn't like it
2014-12-31 13:45:12 -08:00
c89d0e26b2
BulletSim: add the beginnings of hull creation unit testing.
...
Change how physics engine is created in unit tests to resolve a lib reference problem.
Add ShapeInfoInfo class to collect info about the created physical shape
for debugging and unit test testing.
2014-12-31 12:48:26 -08:00
291c7cdbcc
BulletSim: Add axis locking enabled through the ExtendedPhysics module.
...
Allows locking of prim/linkset relative moving in each of the linear
and angular axis. Limits on movement or rotation can be set.
2014-12-31 12:43:26 -08:00
b40935837c
Fixed declaration switcharoo on the region combiner dll.
2014-12-31 08:20:17 -08:00
998ef665a8
Commenting out the suppression of console warnings from Mono addins while we test this new model for the next couple of weeks.
2014-12-31 00:01:47 -08:00
3375841fee
Capitalization fail.
2014-12-30 23:47:11 -08:00
0af02efaed
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2014-12-30 20:05:33 -08:00
a88bc50a16
Add support for expansion of key values in nini config files.
...
Add loading of 3rd-party addin inis automatically.
2014-12-30 20:05:12 -08:00
bc7570e59c
Merge branch 'mb-throttle-test'
...
Merge in the new throttle code.
2014-12-30 16:26:57 -08:00
2138d5c7f8
Renamed VERSION_NUMBER to VersionNumber
2014-12-30 15:27:28 -08:00
5bb73793c7
Comment out the debugging statements added in the last commit. Keeping
...
them in the code for later use rather than just reverting them.
Fixed the throttle tests for the new algorithm used when packets
are marked as expired.
2014-12-30 14:43:42 -08:00
7466ef0525
This cleans up versioning. Specifically:
...
- It establishes 4 digits for opensim versions
- It uses the same number between opensim releases and mono addins versions
It also eliminates the last addin.xml files that were still there, for consistency.
2014-12-30 12:53:31 -08:00
58229a968b
Turn on logging of old acks, this is for debugging only, stats version coming later
2014-12-30 10:50:34 -08:00
c06100c31f
Another technique inspired by some of the newer flow control algorithms... rather
...
than drop exponentially to 0 (and then adjust up for the minimum flow), drop on
the delta between current rate and the minimum rate. This should smooth the fallback
to minimum.
2014-12-30 10:39:14 -08:00
75df04f0b3
Fix the throttle tests. Remove the hardcoded constant multipliers and
...
compute the expected values without depending on the token bucket code.
2014-12-30 10:03:37 -08:00
2506728e35
Merge branch 'master' of ssh://opensimulator.org/var/git/opensim
2014-12-30 07:59:09 -08:00
5cf6a6f830
WARNING: BREAKING CHANGES FOR REGION MODULE DEVELOPMENT.
...
This cleans up Opensim's use of mono addins. In particular, the extension points /OpenSim/RegionModules and /OpenSim/WindModule moved from OpenSim.exe to OpenSim.Region.Framework.dll. From here on, developers of region modules should declare their dlls to be dependent on OpenSim.Region.Framework, starting with version 0.8.1
Additional changes:
- Addins version uniformly updated to 0.8.1. These numbers should be compatible with the release numbers or else it becomes very confusing.
- Mono addins directives moved from files addins.xml to embedded directives in the class and assembly declarations, to make it all consistent
2014-12-30 07:58:42 -08:00
bda8f2a2c1
Change the effect of successfully acknowledged packets to bump the
...
adaptive throttle by a full MTU. This is consistent with some implementations
of congestion control algorithms and certainly has the effect of opening
the throttle window more quickly after errors. This is especially important
after initial scene load when the number and size of packets is small.
2014-12-29 23:19:10 -08:00
041a09ecb9
Enable runtime configuration of the minimum rate for adaptive
...
throttles. Setting adaptive_throttle_min_bps will change the
minimum rate that the adapative throttles will drop to in case
of network packet loss. The current rate default rate is 256kbps.
The viewer can throttle rates under that amount, but the dynamic
adaptation will not.
2014-12-29 18:46:33 -08:00
5410e4f1f9
minor: correct sent -> set in TokenBucket.RequestedDripRate method doc
2014-12-30 00:53:17 +00:00
89c1ac4cff
Updated OpenSim-as-addin version from 0.5 to 0.8.1. The addin version number doesn't need to match the release version number, but I think it's a very good idea that they do.
2014-12-29 15:05:44 -08:00
601849b4fa
Added AssemblyInfo.cs to OpenSim.exe
2014-12-29 14:13:17 -08:00
e71549a2cb
Add debugging code for simulating packet loss in outgoing UDP packets. The
...
algorithm for dropping packets is a modified two state algorithm for creating
bursts of dropped packets. As configured there is about a 1.5% drop rate.
Invocation of the packet loss code is commented out by default.
2014-12-29 12:02:36 -08:00
bb82076a4d
Allow for richer semantics of object derez. Specifically, allow the existence of region modules that do other kinds of garbage collection. Instead of placing deleted objects in the user's Trash folder, or deleting them immediately (UseTrashOnDelete = false), a module may decide to take garbage collection under its control. For example, it may place derezzed objects in a certain area inworld and delete them later.
2014-12-25 12:17:07 -08:00
fc940ab09a
If a moap entry has EnableWhiteList but WhiteList == null, then properly block the request instead of throwing an exception.
...
Normally, WhiteList is an empty list but from Mantis 7389 it looks like it might sometimes be possible for it to be null (haven't seen this up till now)
It looks like failing with an exception instead of properly replying to the request (which comes in via a cap) might be enough, surprisingly, to freeze a viewer until timeout.
Part of http://opensimulator.org/mantis/view.php?id=7389 but probably unrelated to the actual issue of that mantis.
2014-12-23 20:38:20 +00:00
7100475b90
Make sure we always dispose of disposables inside RestClient.Request()
2014-12-20 01:56:33 +00:00
9cff0bbd7c
In XBakesModule.Get() use using() to always dispose of RestClient which disposes the stream rather than disposing the stream directly
2014-12-20 01:46:32 +00:00
e3d07bd0cc
minor: Correct propery doc RestClient._resource spelling mistake
2014-12-20 01:39:31 +00:00
798074c66f
Use using() semantics in XBakesModule to ensure disposable objects are alway disposed no matter what
2014-12-20 01:38:48 +00:00
9edc5cac96
In XBakes use proper disposal semantics to always close the stream on Store() no matter what
2014-12-20 01:32:49 +00:00
e901253b49
Fix recent regression where a race condition meant SP.MakeRootAgent() would sometimes look to start attachment scripts before ETM.HandleIncomingSceneObject() had added them.
...
Probably a regression since ghosts branch merge on Nov 26 2014
2014-12-17 00:25:24 +00:00
e50aac020f
Add command to reset region's user cache
2014-12-16 12:47:02 -05:00
b39d697555
Adding command to reset user's email address
2014-12-16 12:20:56 -05:00
147d401b28
Remove XEngine.m_uniqueScripts
...
This provides no obvious benefit as far as I can tell but has a definite cost in keep script strings in memory for the entire simulator session.
2014-12-15 20:38:26 +00:00
2b9f0647de
Fix a regression where objects crossing regions in the same simulator (on their own or as attachments) with AppDomainLoading = false would create the new state in the source region area rather than the dest.
...
This was beause the code was finding the script DLL compiled for the source region as everything is in the same appdomain and using this as the location for the destination script state, etc.
This resolves the regression by passing the proper destination separately from the DLL retrieved.
Probably a regression since commit d7b92604http://opensimulator.org/mantis/view.php?id=7278
2014-12-10 00:25:27 +00:00
227d2e2b61
Avoid a possible race condition where the XEngine script compile thread could complete but see OnRezScript() insert a new job and complete before it set m_CurrentCompile = null
...
If the above happened, it would mean the new script would not compile until some script was added for compilation.
2014-12-10 00:04:10 +00:00
76722d8324
In XEngine, enqueue a script rez to the compile queue after setting m_CompileDict to avoid a rare but not impossible race condition.
2014-12-09 23:59:19 +00:00
f3ab7c0f5c
refactor: rename IteratingUuidGather.AddAssetUuidToInspect() and RecordAssetUuids() to AddForInspection() as this properly describes what both of these methods do.
2014-12-05 00:21:42 +00:00
b0ff3236be
Make "fache assets" console command more efficient by only updating access times on each cached asset once, not for every reference.
2014-12-05 00:09:01 +00:00
9208fb5d54
refactor: Make IteratingUUIDGatherer take a dictionary in its constructor like UUIDGatherer, so we can deal with future cases where the dictionary may already be pre-populated.
2014-12-04 23:55:59 +00:00
bee3f203cd
Allow scripts in attachments on an owned NPC to call NPC functions on that NPC
2014-12-04 22:52:46 +00:00
9dbe99af0f
If "fcache assets" is executed, don't stop with an exception if there's an access violation if another thread is operating on the file at the same time.
...
Resolves one issue from http://opensimulator.org/mantis/view.php?id=7271
2014-12-04 01:53:42 +00:00
ad91143880
refactor: breakout flotasm cache last file access time to separate UpdateFileLastAccessTime() method for imminent reuse.
2014-12-04 01:51:01 +00:00
c36bfdc60f
Don't worry about checking FlotsamAssetCache.m_CurrentlyWriting when updating access time.
...
The majority of updates won't be for anything currently writing and any sharing exception from an actual clash can be caught and ignored anyway.
2014-12-04 01:46:00 +00:00
5861401faa
Remove long unused region parameters from SceneBase. Some of these weren't even being set. Region parameters come from Scene.RegionInfo instead.
2014-12-03 21:44:22 +00:00
2d2aa6e076
minor: Just have one message that displays successful registration of a region with its parameters rather than 2
2014-12-03 21:40:39 +00:00
d34ad345d5
minor: If we are recompiling scripts in response to a ScriptStopStrategy config change (a rare situation), then explicitly log this for debug purposes.
2014-12-03 21:08:43 +00:00
c3c05a8693
Reintroduce general xengine extra debugging log level. This can be controlled at runtime with the command "debug xengine log <level>", as with similar commands.
...
If log level is 1 then every script load is logged.
This means the <logger name="OpenSim.Region.ScriptEngine.XEngine"> section in OpenSim.exe.config is no longer needed to avoid log spam on regions with many scripts and can be removed.
2014-12-03 20:48:17 +00:00
805b7ccb3e
minor: improve logged error in XEngine.SetXmlState if there was a problem writing the linemap.
...
The previous error report of already exists is inaccurate since existing files do get overwritten.
2014-12-03 20:35:49 +00:00
72d1d96c5c
Always close script linemap file after reading and always dispose of other streams in the script engine even if exceptions are thrown.
2014-12-03 20:31:09 +00:00
3642198838
BulletSim: move detail log of InternalScheduleRebuild to reduce log file spam
2014-11-30 19:53:00 -08:00
63d192f011
BulletSim: Remove linkset 'Incomplete' flag as its meaning couldn't be made clear. Add 'InternalScheduleRebuild() CHange rebuild code to call InternalScheduleRebuild() rather than ForceRebuild() to limit the scope of the changes made by the linkset.
2014-11-30 19:53:00 -08:00
41a943bfd0
BulletSim: add BSLinkset.AllPartsComplete that checks of all linkset members are not Incomplete and not waiting for assets. Change BSPrimLinkable to use AllPartsComplete.
2014-11-30 19:52:59 -08:00
eef954a214
BulletSim: Make BSPrimLinkable 'incomplete' if any of its children are waiting for assets to load.
2014-11-30 19:52:59 -08:00
cf85ade81e
BulletSim: add shape and linkset rebuild scheduled flags. Add BSPrim.Incomplete flag based on rebuild flags to say when an object is being rebuilt.
2014-11-30 19:52:58 -08:00
432f0e8783
Correct 690fe0c to actually log the exception reported in DoOnRezScriptQueue()(and now the scene name).
2014-11-29 15:04:16 +00:00
690fe0c5e5
If there are any exceptions in XEngine.DoOnRezScriptQueue() then log the error and always set m_CurrentCompile = null
...
Setting m_CurrentCompile = null in the finally block reduces the risk that an exception could permanently stop any future scripts compiling until the simulator is restarted.
If an exception is seen from this then please report and further changes to fix the bug or improve compiling reliability can be made.
2014-11-29 01:42:52 +00:00
55e064baf7
Remove minor race condition where two threads could race on fields such as m_ScriptFailCount as set in XEngine.DoOnRezScriptQueue()
2014-11-29 01:33:14 +00:00
79e37e5ecc
Restore zero'ing RawVelocity in BSCharacter.ZeroMotion() in favour of not calling ZeroMotion in SetPhysicalProperties() at all
...
SetPhysicalProperties is only called when adding a new character so it looks like there is no existing data to reset anyway.
2014-11-29 01:13:48 +00:00
dfab60a7fd
minor: Remove a few indenting problems introduced to recent 265fe349 and convert the m_log.DebugFormat() call back to the original DetailLog call
2014-11-29 00:53:13 +00:00
dcc36507f3
Halve the prediction lag for region crossing to improve most flying region crossings without degrading the walk cross experience (neither of which have been that great anyway).
2014-11-29 00:48:26 +00:00
39eab72d7c
When performing region cross, don't add the velocity to the new position in ETM.CrossAgentIntoNewRegionMain() since this has already been performed by SP.CheckForBorderCrossing()
2014-11-29 00:16:23 +00:00
265fe349e0
Somewhat improve avatar region crossings by properly preserving velocity when avatar enters the new region.
...
This commit addresses the following issues were causing velocity to be set to 0 on the new region, disrupting flight in particular
* Full avatar updates contained no velocity information, which does appear to have some effect in testing.
* BulletSim was always setting the velocity to 0 for the new BSCharacter. Now, physics engines take a velocity parameter when setting up characters so we can avoid this.
This patch applies to both Bullet and ODE.
2014-11-29 00:12:11 +00:00
09534f378e
Avoid repeated lag-generating continuous attempts to retrieve HG service Urls in UMM if the initial request fails, possibly due to the home URL not being present
...
Instead, the failure information is effectively added to the memory cache (so no persistence over simualtor sessions).
A future improvement may be to invalidate negative cache results after some time has passed in case the failure was transient.
Looks to resolve http://opensimulator.org/mantis/view.php?id=7382
2014-11-28 01:16:30 +00:00
d9f7aa41c1
Remove unmaintained MSSQL support.
...
This has not been maintained for more than 2 years, is unimplemented for newer features (e.g. built-in groups) and has no core developers using it.
If somebody fixes these issues then it could be reinstated.
2014-11-28 00:27:13 +00:00
73234e2098
Stop writing SizeZ config parameter for now when creating regions from console as it is unused/ignored, at least in core.
2014-11-28 00:04:10 +00:00
ee9fae23ff
Be more explicit again in UMM bad HomeURL message by logging the original creator data
2014-11-27 00:32:04 +00:00
8a27fc5d61
Make UMM.AddUser(UUID, string) log message when bad creatorData is given to reflect its location (UMM not Scene) and add the user name and ID.
2014-11-27 00:24:17 +00:00
62b778ca4d
Merge branch 'master' of /team/src/opensim
2014-11-25 19:27:28 -05:00
a76aec8467
Fix whitespace hoping to avoid a flogging
2014-11-25 19:27:15 -05:00
86367d7219
refactor: Move methods to start a monitored thread, start work in its own thread and run work in the jobengine from Watchdog to a WorkManager class.
...
This is to achieve a clean separation of concerns - the watchdog is an inappropriate place for work management.
Also adds a WorkManager.RunInThreadPool() class which feeds through to Util.FireAndForget.
Also switches around the name and obj arguments to the new RunInThread() and RunJob() methods so that the callback obj comes after the callback as seen in the SDK and elsewhere
2014-11-25 23:56:32 +00:00
20cede12a9
Fix ghosts copy of SimulatorFeatureModule to enable logging.
2014-11-25 23:28:38 +00:00
66b1c37973
Fix bug in HG attachment throttling code where attachments were never rezzed on any teleport within a foreign grid after the first.
...
Bug was introduced in ghosts branch commit 69abade
2014-11-25 23:23:12 +00:00
4b45a1b6ad
Change jobengine logging command to "debug jobengine log <int>" rather than loglevel, in common with similar commands.
2014-11-25 23:23:11 +00:00
b1fd0d35e5
Make small adjustment to JobEngine default from previous commit to enable it when [Startup] section is not present (though this is extremely unlikely).
2014-11-25 23:23:11 +00:00
59b38f842a
Add [Startup] JobEngineEnabled setting that allows the job engine to be disabled for testing purposes if necessary.
2014-11-25 23:23:11 +00:00
28d1dbfee4
Move conditionals which control whether a task is placed in the JobEngine inside Watchdog.RunJob() (renamed from RunWhenPossible) and generalize them.
2014-11-25 23:23:11 +00:00
124be38f74
Add [BulletSim] option AvatarToAvatarCollisionsByDefault to control whether avatars collide. This is true by default.
...
This is implemented with a new collision type (PhantomToOthersAvatar) to potentially allow colliding and non-colliding avatars to be present in the same scene.
So there is no provision yet for giving avatars different collision types.
This commit replaces the temporary change in commit f3eaa6d8
2014-11-25 23:23:11 +00:00
3a296a817b
Fix compile error from previous 1d56029848
2014-11-25 23:23:11 +00:00
550cf714bc
Fix issue where llRemoteLoadScriptPin() would treat 0 (the default) as a valid set pin in a destination prim rather than the unset no pin state
...
Adds regression test for this case.
2014-11-25 23:23:11 +00:00
aeae34505f
When processing incoming attachments via HG, if a request for uuid gathering or final asset import takes too long remove remaining requests from same user to prevent hold up of other user's incoming attachments.
...
This improves upon the earlier naive simply queueing immplementation.
Threshold is 30 seconds. If this happens to a user they can relog and fetch will be reattempted.
2014-11-25 23:23:11 +00:00
06a5d6e9ef
Introduce an IteratingUuidGatherer where each fetch from the asset service (iteration) can be controlled by the caller.
...
This is to enable an imminent change where incoming HG scene object fetching can assess the time taken by each request rather than being forced to perform all requests in one call.
Soon, this will replace the existing UuidGatherer since it is both simpler and more flexible.
2014-11-25 23:23:11 +00:00
d6c9705a3b
Add incoming packet async handling engine to queue some inbound udp async requests.
...
This is to reduce the potential for overload of the threadpool if there are many simultaneous requets in high concurrency situations.
Currently only applied to AvatarProperties and GenericMessage requests.
2014-11-25 23:23:11 +00:00
1c5c6af274
Add missing class from recent commit 69abade
2014-11-25 23:23:10 +00:00
f54c70741b
Add "show threadpool calls active" console debug command.
...
This shows named threadpool calls (excluding timer and network calls) that are currently queued or running.
Also shows total of labelled and any anonymous calls.
2014-11-25 23:23:10 +00:00
1d19e1bbd0
Add naive implementation of controlled incoming HG attachments to manage load.
...
Instead of processing all incoming attachment scene object concurrently, process them consecutively to eliminate potential overload from this source.
This is a naive implementation because it does not currently account for slow foreign asset services.
Although it may take longer, this approach may also improve attachment visibility for HG avatars
since the scene object is now always added to the scene after receiving assets from the foreign service and not before.
2014-11-25 23:23:10 +00:00
ec8d21c434
Label all threadpool calls being made in core OpenSimulator. This is to add problem diagnosis.
...
"show threadpool calls" now also returns named (labelled), anonymous (unlabelled) and total call stats.
2014-11-25 23:23:10 +00:00
72cb1cc7d6
Add "show threadpool calls" command to show count of all labelled smartthreadpool calls
2014-11-25 23:23:10 +00:00
8c9f82b035
Just for now, don't alert the user or log if we couldn't change their server-side preferences due to no e-mail address being sent.
...
This is to avoid user confusion in the oscc rehearsal as they are often not aware that this fails because no e-mail is set.
Also may be failing in the hypergrid case, though this may also be a config issue.
This is meant as a temporary solution.
2014-11-25 23:23:10 +00:00
5d5ea9234f
Stop Mono 3.2.8 from binding a UDP socket to a port already in use.
...
At least on Mono 3.2.8 (but not under Windows), one can bind multiple UDP sockets to the same port by default.
Different simulators cannot demultiplex each other's messages, so a set of confusing non-obvious errors arise if this occurs.
This change prevents such multiple binding.
2014-11-25 23:23:09 +00:00
b53be022f2
On pCampbot, if we add the none (n) behaviour then make it actually stop any bots in motion.
...
Previously, adding this behaviour after physics (p) would leave the bot to drift off for ever in its last movement direction.
2014-11-25 23:23:09 +00:00
3a1ce2715a
Add "wearables check" console command
...
This checks that all the wearable assets and any assets for a given logged in avatar exist in the asset service
2014-11-25 23:23:09 +00:00
9b09dd3575
Add "wearables show" console command.
...
This shows summary wearables information (shape, hair, etc.) for all avatars in the scene or specific information about a given avatar's wearables.
Similar to the existing "attachments show" command.
2014-11-25 23:23:09 +00:00
5ab5d7fe47
Fix recent regression where adaptive throttles stopped adjusting.
...
Extends regression tests to test response of adaptive throttles to ack'ed and expired packets.
2014-11-25 23:22:20 +00:00
b2e377f168
Fix setting of max scene throttle so that setting it restricts the child client throttles properly.
...
In "show throttles", also renames 'total' column to 'actual' to reflect that it is not necessarily the throttles requested for/by the client.
Also fills out 'target' in non-adapative mode to the actual throttle requested for/by the client.
2014-11-25 23:22:20 +00:00
b114f5626e
Add request drip rate to assertions for token bucket regression tests
2014-11-25 23:22:20 +00:00
8a949f0ee1
Add regression tests for token buckets on their own
2014-11-25 23:22:20 +00:00
ec3b43d28d
Make regression throttle tests consistently test target and max throttle settings.
...
As part of this also refactors code to put all throttle asserts in a single regression test method
2014-11-25 23:22:20 +00:00
548abb3b47
minor: In "show client stats" command, properly handle the case where a client has made no AgentUpdate requests (as is the case with agents that have only even been child) rather than throwing an exception
2014-11-25 23:22:20 +00:00
a9dde81753
minor: Correct letter accidentally added to copyright notice on top of Scene.cs (almost five years ago!)
2014-11-25 23:22:20 +00:00
b7ef6009a7
In Scene.AddNewAgent(), avoid a situation where an exception can result in a client being added to the manager without IClientAPI.SceneAgent being set.
...
This is done by adjusting the order of code so that SceneAgent will always be set before adding the client.
Various parts of the code (rightly) assume that a a client registered to the manager will always have a SceneAgent set no matter what.
2014-11-25 23:22:20 +00:00
e6af551007
For now, send all non-full terse updates for ones own avatar directly to the LLUDP client stack rather than queueing internally within LLClientView.
...
When an HG avatar enters a scene, it delays processing of entity updates. Could be crowding out by other updates or something else.
This delay in ones own av mvmt updates results in mvmt lag experienced on the client. Avoiding the internal LLClientView for these packets appears to resolve this issue.
Appears most noticeably for avatars with attachments, though has also been seen on those without sometimes. Hasn't been observed for non-HG avatars in general.
Will be investigating exactly what the problem is, at which point there will be a more permanent solution.
2014-11-25 23:22:20 +00:00
10095c1a58
Add "debug lludp throttles get/set request" and get current
...
This allows one to set the requested throttle (which normally comes from the client) as opposed to the max.
2014-11-25 23:22:19 +00:00
61d6bd78b3
Change the word order of some debug lludp settings for readability
...
On server, scene-throttle-max becomes max-scene-throttle and likewise max-new-client-throttle
On clients, throttle-max becomes max
2014-11-25 23:22:19 +00:00
44dc58cc7f
Add "debug lludp get/set new-client-throttle-max" to allow default new client throttle to be set separately from existing clients.
...
"debug lludp throttles get/set throttle-max" now only gets and sets current max client throttles
2014-11-25 23:22:19 +00:00
68d0c4d37b
Add "debug lludp get" command which currently just shows scene-throttle-max to mirror "debug lludp set"
...
Information is also available in "show server throttles" but that's more for non-debug info rather than attempting to get and set parameters on the fly for debug purposes.
2014-11-25 23:22:19 +00:00
336790e7b4
Add some more llGiveInventory() regression tests
2014-11-25 23:22:19 +00:00
1eb3e6cc43
When inserting missing CreatorData in the HGAssetMapper, do the rewrite on a streaming xml basis rather than loading it all into memory via XmlDocument.
...
This is because objects with lots of parts can have a lot of xml to load into memory, and this has been seen to have a noticeable performance impact.
Whereas streaming has been seen to reduce the impact in normal serialization.
Implmentation is messy but I couldn't see a better way of doing it when you can't assume that you know the exact structure of the input XML.
2014-11-25 23:21:38 +00:00
f7ab3e20bc
Add regression test TestPostAssetRewrite() to check results of HGAssetMapper.Post() object asset rewriting,
2014-11-25 23:21:38 +00:00
6c043dd6ff
If an exception makes it to the top of a JobEngine request, catch and log instead of letting it terminate the simulator...
2014-11-25 23:21:38 +00:00
16a5e15443
Allow GetMesh capability to be served directly by a server like GetTexture
...
To do this required GetMesh to be converted to a BaseStreamHandler
Unlike GetTexture connector, no redirect URL functionality yet (this wasn't present in the first place).
2014-11-25 23:21:38 +00:00
281969093f
Start JobEngine by default in simulator for now.
2014-11-25 23:21:38 +00:00
1c9529aa9e
If JobEngine is active, then use it to copy/rez attachments for an avatar entering the scene that isn't initially logging on. This will execute tasks consecutively rather than concurrently.
...
This has two aims
1) Reduce initial teleport failures when a foreign Hypergrid user enters a region by not holding up the teleport for attachment rez (this can be particularly costly when HG gets all assets in the object graph.
2) Reduce server load that may impact other simulator activities.
This complements existing JobEngine options that perform initial login attachment rez and appearance send in consecutive tasks.
2014-11-25 23:21:38 +00:00
90f9cea07b
minor: be consistent about reporting errors out of HttpServerBase
2014-11-25 23:21:38 +00:00
f4424bdfcf
If the port entry in [Network] for a server is missing, then actually tell the user that's the problem rather than simply exiting silently.
...
Also exit with Environment.Exit(), not by aborting the thread.
2014-11-25 23:21:38 +00:00
8ddcd16c69
Add an IConfigSource constructor to HGAssetBroker so that it can be instantiated directly for potentially handling some capabilities directly in services with HG active
2014-11-25 23:21:38 +00:00
d33964222a
Fix an issue where specifying both max client and server outgoing UDP throttles would cause client throttles to be lower than expected when total requests exceeded the scene limit.
...
This was because specifying a max client throttle would always request the max from the parent server throttle, no matter the actual total requests on the client throttle.
This would lead to a lower server multiplier than expected.
This change also adds a 'target' column to the "show throttles" output that shows the target rate (as set by client) if adaptive throttles is active.
This commit also re-adds the functionality lost in recent 5c1a1458
2014-11-25 23:21:38 +00:00
ead32de790
Use automatic properties for Parent and TotalDripRequest in TokenBucket to make code analysis easier. No functional change.
2014-11-25 23:21:37 +00:00
40314b56f2
Remove the unnecessary intermediate total token bucket.
...
This only had one child, which is the 'adaptive' token bucket.
So from testing and currently analysis, we can use that bucket directly which simplifies the code.
2014-11-25 23:21:37 +00:00
93f3444de1
minor: remove warnings from unused fields in LocalGridServicesConnector
2014-11-25 23:21:37 +00:00
dacd0ecfee
minor: Remove unused field from EntityTransferModule
2014-11-25 23:21:37 +00:00
a98b514184
minor: remove compiler warning from unused field in SimulatorFeaturesModule
2014-11-25 23:21:37 +00:00
0d77796584
minor: resolve warnings from unused fields in XBakesGet and Post handlers
2014-11-25 23:21:37 +00:00
d5ead532cb
Remove compiler warning from UserProfilesHandlers
2014-11-25 23:21:37 +00:00
07a7f941e5
minor: remove warning in BasicHttpAuthentication by commenting out unused remove_me parameter (which looks like it might still be potentially useful for logging)
2014-11-25 23:21:37 +00:00
df031fe8be
extend TestClientThrottleRegionLimited for 2 clients after testing 1. Renames to TestSingleClientThrottleRegionLimited()
2014-11-25 23:21:37 +00:00
dce98acb69
Add regression test TestClientThrottleRegionLimited() for testing simple behaviour of throttles where a region-wide total outbound limit is in place.
2014-11-25 23:21:37 +00:00
075f718f3f
factor out common throttle setting byte[] array construction in ThrottleTests.
2014-11-25 23:21:37 +00:00
9cdd38d0cf
Add regression test TestClientThrottleLimited() for throttle behaviour when a max client total limit is enforced server-side
2014-11-25 23:21:37 +00:00
fc878a33ed
refactor: consistently put all test classes in the OpenSim.Tests.Common package rather than some in OpenSim.Tests.Common.Mock
...
the separate mock package was not useful and was just another using line to always add
2014-11-25 23:21:37 +00:00
af0a851eba
minor: disable logging in regression test TestClientThrottleSetNoLimit
2014-11-25 23:18:40 +00:00
9934e2c545
minor: comment out unused method in regression BasicCircuitTests
2014-11-25 23:18:40 +00:00
746defa094
Add basic regression test ThrottleTests.TestClientThrottleSetNoLimit
2014-11-25 23:18:40 +00:00
AliciaRaven