Commit Graph

19176 Commits (13b1c5dfcef6e6e74709da8d588ed48d99d560d2)

Author SHA1 Message Date
Robert Adams 2e1f5bb011 Temporarily comment out OSSL enabled warning log message.
Added in wrong place. It is printed once per script rather than once per region.
2015-04-14 11:30:14 -07:00
Robert Adams e4e58fad32 Enable OSSL functions by default using the osslEnable.ini configuration file.
This changes OpenSim.ini.example to, by default, include osslEnable.ini which
turns on the OSSL functions and limits who can do which operations.
2015-04-14 07:17:54 -07:00
Robert Adams 9b337b089c Add osCheckODE() function so scripts can configure for running with legacy physics engine.
Function returns 'true' of the physics engine is configured to be 'OpenDynamicsEngine'.
  The presumption is that all other physics engines work the same (like SL) or it is a bug.
  Does not require ossl functions to be enabled.
2015-04-12 19:30:55 -07:00
AliciaRaven 1e444b1449 Change UserProfiles so that the parcel name is used for a ProfilePick and not the parcel owners name. This change also fixes a bug where if the avatar enters and does not move, creating or editing a ProfilePick would set the parcelId as an empty UUID. This is because ScenePresence.currentParcelUUID is not set until the avatar moves.
Signed-off-by: Michael Cerquoni <nebadon2025@gmail.com>
2015-04-12 15:36:22 -04:00
Magnuz Binder bdb91d0e70 Fix llTargetOmega non-physical gain.
Signed-off-by: Michael Cerquoni <nebadon2025@gmail.com>
2015-04-12 14:55:44 -04:00
Magnuz Binder beba2ce781 Fix stand position for differing seat and root rotation.
Signed-off-by: Michael Cerquoni <nebadon2025@gmail.com>
2015-04-12 12:53:47 -04:00
Robert Adams 8d66284841 BulletSim: implement VEHICLE_REFERENCE_FRAME. Thanks Vegaslon!. 2015-04-05 20:20:37 -07:00
Magnuz Binder b51e46ceb8 Parameterize sleeps in LSL functions. 2015-03-22 09:55:02 -07:00
Magnuz Binder 07a75677c3 Allow setting hollow to 99% from scripts just like from viewer. 2015-03-22 09:53:27 -07:00
Magnuz Binder f63d6ffd81 Allow setting holesize to 0.01 from scripts just like from viewer. 2015-03-22 09:53:13 -07:00
Magnuz Binder 68ed200191 Allow setting dimple diff to 0.02 from scripts just like from viewer, add clipping and fix old copy-paste error. 2015-03-22 09:53:03 -07:00
Freaky Tech 5af82df9b6 viewers can set a minimum distance 0.02 between path cut start and path cut end 2015-03-22 09:52:46 -07:00
dahlia 83e58ebc7c oops someone set individual quaternion members and forgot to normalize 2015-03-17 13:14:03 -07:00
Justin Clark-Casey (justincc) 310e44f250 Re-enabled ability for avatar to ascend and descend whilst controlling view with lmb held down on avatar (in most viewers).
This had been disabled by 30b7863 (Fri Feb 27 2015).
Relates to http://opensimulator.org/mantis/view.php?id=6835
2015-03-17 18:55:33 +00:00
Justin Clark-Casey (justincc) 5b31bb9cb9 Don't log http auth details by default.
This is a security risk when people distribute logs for debug purposes.
If necessary the information can be retrieved via config console commands.
Relates to http://opensimulator.org/mantis/view.php?id=7501
2015-03-16 23:48:16 +00:00
Justin Clark-Casey (justincc) eda09d8763 Fix XBakes simulator-side authentication regression failure
Unlike the other connectors, XBakes uses a service auth retrieved from ServiceAuth.Create() and not code inherited from BaseServiceConnector.
Fixes regression from 7d3bafd5 (Wed 4 Mar 2015) where the new CompoundAuthenticator did not implement IServiceAuth.AddAuthorization()
2015-03-16 23:40:34 +00:00
Justin Clark-Casey (justincc) e6889a6023 Update version info to 0.8.2.0 2015-03-16 21:53:31 +00:00
dahlia 8b13e4e731 Revert "Allow a console command to give blank arguments ("") without the parser failing, e.g. login text """
This reverts commit 129cc49eb4.
It was causing the "alert" console command to fail.
2015-03-14 14:24:55 -07:00
Justin Clark-Casey (justincc) fec2527e6c minor: fix compiler warnings in EstateDataRobustConnector 2015-03-14 00:18:35 +00:00
Justin Clark-Casey (justincc) 45dd0cc363 Actually start a region created via the "create region" console command.
Addresses http://opensimulator.org/mantis/view.php?id=7478
2015-03-13 23:50:00 +00:00
Justin Clark-Casey (justincc) caa0e2a732 Don't try to write region size and MapfileStaticFile Nini settings that are not set up when invoking the RemoteAdmin create region facility.
Changes by MarcelEdward from http://opensimulator.org/mantis/view.php?id=7497.  Thanks.
2015-03-13 23:30:31 +00:00
Justin Clark-Casey (justincc) 0aeea89258 Fix script state not being preserved in objects sent via Hypergrid.
This was because attributes were not being included in the transformation, hence losing the script state identity.
Symptoms are messages like "[SCENE OBJECT GROUP]: SavedScriptState element had no UUID in object test box"
Regression since the conference code merge.  Regression test extended for this case.
Relates to http://opensimulator.org/mantis/view.php?id=7439
2015-03-13 20:09:29 +00:00
Justin Clark-Casey (justincc) 3a7d42378f Move state change in progress in ScriptInstance.PostEvent() to the top of the EventQueue lock to avoid some flags possibly being wrongly set (m_LastControlLevel, etc.) 2015-03-12 00:14:30 +00:00
Justin Clark-Casey (justincc) 7410924de0 Lock around EventQueue manipulation in ScriptInstance.SetState() as queues are not thread-safe structures.
This should also make it less likely that an event will be erroneously posted during a state change by precluding a race condition with a thread calling ScriptInstance.PostEvent()
2015-03-12 00:07:01 +00:00
Bob Shaffer II b4b13510e8 A workaround for the state change problem described best here http://opensimulator.org/mantis/view.php?id=6960 which should make state changes behave more like is described here http://wiki.secondlife.com/wiki/State 2015-03-12 00:01:30 +00:00
Shy Robbiani 78258a0fa1 help restart message corrected
The "restart" console command restarts the currently selected region or
all regions in this instance if root is selected. Changed the message
accordingly.
2015-03-11 23:30:05 +00:00
Justin Clark-Casey (justincc) b267c238fb minor: Remove windows build warning about CompressionLevel package ambiguity.
Relates to http://opensimulator.org/mantis/view.php?id=7442
Thanks Fly-Man-
2015-03-11 22:53:32 +00:00
Justin Clark-Casey (justincc) 129cc49eb4 Allow a console command to give blank arguments ("") without the parser failing, e.g. login text ""
Relates to http://opensimulator.org/mantis/view.php?id=7489
2015-03-11 22:42:14 +00:00
Robert Adams 00b5b915c7 BulletSim: add VEHICLE_ more parameter value limit checking.
This only bounds passed parameters as there is no good way of refusing
the parameter setting. This mostly means that passing NaN's won't
crash the simulator.
2015-03-07 17:47:40 -08:00
BlueWall f6168ded47 Remove references to MAX_ASSET_DESC from the dynamic texture module, hardcode to 128 as in other inventory modules. 2015-03-06 21:10:45 -05:00
Freaky Tech 4de10a45e9 revised GetMesh to not use intermediate base64 coding scheme
it delivers binary and has binary as input.
base64 intermediate coding makes no sense.

Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-05 18:15:42 -05:00
Freaky Tech 5a413c1b2f adjusted new UserManagementModule to accept the HG UUI test harness
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-05 17:19:39 -05:00
BlueWall 375f8cce34 Give llGiveInventory a way to querry Hypergrid visitors so network vendors are able to give items to Hg visitors 2015-03-05 16:58:02 -05:00
Freaky Tech 0ea6977013 solving HG IM, HGFriends issues based on falsified GridUser data
it does not consider GridUser as a viable source for residents' data.
it does not consider Friends, Inventory Creators to be trusted at all. There are lots of broken entries in existence.

There are lots of broken creator data fields in assets.

The following issues arise from the broken data in the old User Management Module:

failing HG IM
failing HGFriends Requests

Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-05 16:17:12 -05:00
BlueWall 7adeb43a88 Merge branch 'master' of /team/src/opensim 2015-03-04 19:40:31 -05:00
BlueWall d7b45a3ed2 Alter the migrations so that it is a no-op as the columns are unused and the operation is very expensive 2015-03-04 19:27:34 -05:00
BlueWall 08637727dc Merge branch 'master' of /team/src/opensim 2015-03-04 14:58:08 -05:00
BlueWall 96b87407f1 Revert "removed replacement texture in UDP Texture code. The replacement texture introduces false data into viewer cache. Removing that decreases the necessity for clearing the viewer cache. The viewer knows with ImageNotInDatabase that it is missing and can therefore know what to do about it a lot better than the sim does."
This reverts commit 4d749d8c69.

Re-open mantis 0007474 for further work before final commit.
2015-03-04 14:36:26 -05:00
BlueWall 369ccaf1eb Merge branch 'master' of ssh://opensimulator.org/var/git/opensim 2015-03-04 14:02:35 -05:00
Cinder 9921c24c8f One more migration fix
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-04 13:47:15 -05:00
Cinder 56ae3da291 Chase latest change to asset description length with an update to XAssetStore db tables
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-04 13:47:15 -05:00
BlueWall 11a24d04b6 Revert "Chase latest change to asset description length with an update to XAssetStore db tables"
This reverts commit e520364f65.
2015-03-04 13:47:02 -05:00
Justin Clark-Casey (justincc) 3255335c42 Make private services forbid llHTTPRequest() calls by rejecting those that have the X-SecondLife-Shard header.
If you need to enable this, set AllowHttpRequestIn = true in [Network] for all private services or individual [*Service] sections.
2015-03-04 18:27:51 +00:00
Justin Clark-Casey (justincc) 7d3bafd5ab Add outbound URL filter to llHttpRequest() and osSetDynamicTextureURL*() script functions.
This is to address an issue where HTTP script functions could make calls to localhost and other endpoints inside the simulator's LAN.
By default, calls to all private addresses are now blocked as per http://en.wikipedia.org/wiki/Reserved_IP_addresses
If you require exceptions to this, configure [Network] OutboundDisallowForUserScriptsExcept in OpenSim.ini
2015-03-04 18:27:50 +00:00
Freaky Tech 2d8c1806ca usability fixes for LSL API
exception based error messages were cryptic for casual users

Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-04 12:45:37 -05:00
Freaky Tech eacdad8405 simplify llStringToBase64 and llBase64ToString
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-04 12:41:49 -05:00
Freaky Tech 061dd3385c usability fixes for LightShare API
exception based error messages were cryptic for casual users

Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-04 12:36:02 -05:00
Cinder e520364f65 Chase latest change to asset description length with an update to XAssetStore db tables
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-04 12:10:41 -05:00
Cinder e5c0b68849 Follow up to last commit, fix field length
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 22:50:12 -05:00
Cinder 7913417683 As per http://wiki.secondlife.com/wiki/Limits Prim description should be 128 bytes (127 + null terminator)
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 22:42:31 -05:00
Freaky Tech 53100b93c7 corrected bug that viewer cannot correctly fetch ItemData when being a HG visitor
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 19:09:30 -05:00
Freaky Tech 773df94665 corrected osMakeNotecard(string data) text length was calculated wrong. The Linden text format defines a byte count in that format.
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 19:06:52 -05:00
ft@noemail fb48ee1cb6 corrected script notecard parser. It now handles notecards with inventory as well.
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 18:39:49 -05:00
BlueWall c02636b6f3 Revert "corrected osMakeNotecard(string data) text length was calculated wrong. The Linden text format defines a byte count in that format."
This reverts commit b519a5e62a.

The function works ok in-world but tests are failing. will revert for now.
2015-03-03 17:42:02 -05:00
BlueWall b6b1e11238 Pickup our version number for the function 2015-03-03 16:42:42 -05:00
Freaky Tech 7f0995ae31 added llGetEnv() implementation
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 16:39:00 -05:00
Freaky Tech b519a5e62a corrected osMakeNotecard(string data) text length was calculated wrong. The Linden text format defines a byte count in that format.
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 16:10:09 -05:00
Freaky Tech 4d749d8c69 removed replacement texture in UDP Texture code. The replacement texture introduces false data into viewer cache. Removing that decreases the necessity for clearing the viewer cache. The viewer knows with ImageNotInDatabase that it is missing and can therefore know what to do about it a lot better than the sim does.
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 16:09:57 -05:00
Freaky Tech 0f72773017 changed llGetMemoryLimit to return 65536 as for Mono LSL
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 16:09:49 -05:00
Freaky Tech af2bf397b1 corrected memory info for scripts
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 16:09:41 -05:00
Freaky Tech 25901a703a corrected llGetStartParameter according to http://wiki.secondlife.com/wiki/LlGetStartParameter
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 15:35:23 -05:00
Freaky Tech 6161817f72 corrected handling when XML parsing in Presence Connector fails
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 15:35:16 -05:00
Freaky Tech f68a1a2218 XML should not contain any BOM. Disabled BOM generation in BaseHttpServer
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 15:35:09 -05:00
Freaky Tech b8157174ca corrected llResetScript according to description within LSL wiki
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 15:35:00 -05:00
Freaky Tech bf96f06d1e corrected response when a not existing folder is requested by a viewer in that case the response has to report it as bad_folders with uuid instead of returning some dummy
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 15:34:47 -05:00
Freaky Tech c6731c73fb increased IPv4 TTL of LLUDP Sockets
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-03 15:34:34 -05:00
BlueWall 7e8bad05ec Fix erratic Npc movement 2015-03-02 20:09:22 -05:00
Freaky Tech 2482d567cf added missing senderId in GiveInventoryFolder this little mistake prevented passing on folders for HG visitors
Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
2015-03-02 15:59:49 -05:00
BlueWall cfa4e6642e Handle kick user from estate management tools 2015-03-01 20:48:51 -05:00
Justin Clark-Casey (justincc) 6da356a7e4 minor: Remove mono compiler warnings from EstateDataConnector 2015-02-28 00:54:23 +00:00
Magnuz Binder 158c3f82f1 Correct PRIM_TEXT return value from trans to alpha. 2015-02-28 00:46:12 +00:00
Justin Clark-Casey (justincc) 4717132b82 Use using constructs on disposable io objects in LLRaw to ensure they are always closed even if an exception is thrown. 2015-02-28 00:41:11 +00:00
Justin Clark-Casey (justincc) 3c92a8e765 Add OpenSim.Framework using statement necessary to get previous fad4d4dc to compile. 2015-02-28 00:34:07 +00:00
Magnuz Binder fad4d4dc55 Permit loading of LLRAW files bigger than 256x256 by calculating size based on file size rather than assuming 256x256, same as for RAW32. 2015-02-28 00:26:58 +00:00
Justin Clark-Casey (justincc) 59d6d03909 Comment out now unused and not properly working private SP.m_leftButtonDown with a comment on how probably to implement it properly if it is needed in the future 2015-02-27 23:48:05 +00:00
Justin Clark-Casey (justincc) 30b786351e Don't slow down avatar walk speed if camera is changed (e.g. by holding down lmb on an avatar and moving the mouse).
Does this by not applying unwanted direction components to the avatar self movement calculation (exception is flying in mouse look).
Matches behaviuor on linden lab grid
Addresses http://opensimulator.org/mantis/view.php?id=6835
2015-02-27 23:43:12 +00:00
Justin Clark-Casey (justincc) ca7cc9b2e2 Don't slide crouching avatar when camera is panned around them with left mouse button
This matches linden lab grid behaviour
2015-02-27 19:43:31 +00:00
BlueWall aeb8a4bf85 Revert "Adding dynamic ossl permission control"
This reverts commit a3681f3052 until
further testing. Jenkins now fails ossl tests.
2015-02-27 12:27:10 -05:00
BlueWall a3681f3052 Adding dynamic ossl permission control
Add permission by identifying uuid (owner/creator/group) and function. Revoke
permission in the same manner. Permission adjustments immediately effect
running scripts ability to call os functions.

osGrantScriptPermissions(UUID key,string function) Threat Level Severe
osRevokeScriptPermissions(UUID key,string function) Threat Level Severe

work sponsored by: Rage
2015-02-27 11:05:15 -05:00
Justin Clark-Casey (justincc) 412dd7dfc5 When an avatar is walking across a region border, force the first AgentUpdate received on the new root agent to update movement parameters.
This prevents the avatar from drifting in its last direction of travel if a movement key was released at certain moments in the cross.
Relates to http://opensimulator.org/mantis/view.php?id=7435
2015-02-26 00:48:51 +00:00
Justin Clark-Casey (justincc) 5fa651c529 minor: In HGAssetMapper, don't complain on seeing an XmlDeclaration as we know that we not using those in transformation.
Relates to http://opensimulator.org/mantis/view.php?id=7447
2015-02-25 21:42:07 +00:00
Justin Clark-Casey (justincc) a03d893f2c Fix bug where the uuid gatherer was not inspecting UUIDs for items in an embedded object's inventory.
Added regression test for this case.
Likely a regression since 08606ae4 (Thu Jan 8 2015)
Relates to Mantises 7439, 7450 and possibly others.
2015-02-25 21:12:46 +00:00
Justin Clark-Casey (justincc) b1b72d7c2f Reduce coupling in regression test task inventory creation methods to make them usable in tests with no scene present 2015-02-25 20:30:03 +00:00
Justin Clark-Casey (justincc) 686b22da6e On shutdown (job engine stop), don't allow the ObjectDisposedException on BlockingCollection.Take() to propogate if the running thread checked IsRunning before the stop thread set it and disposed of the canellation source.
Looks to address http://opensimulator.org/mantis/view.php?id=7453
2015-02-25 20:04:53 +00:00
dahlia 8333dcf388 llLookAt(): use non-physical rotation if host prim is a physical attachment 2015-02-24 17:16:30 -08:00
BlueWall 023fd71ce5 Fix cross-grid inventory delivery notifications, fixes http://opensimulator.org/mantis/view.php?id=7113 2015-02-21 14:29:31 -05:00
Justin Clark-Casey (justincc) c67b3407d4 In HGAssetMapper.RewriteSOP(), don't explicitly end the document.
The document here has no <?xml declaration.  Though ideally it may be present, in practice it has not been added as the data here is embedded within an asset
On Mono 3.2.8 and probably other versions, calling WriteEndDocument() without a declaration does nothing.
On Windows .NET, the same operation throws a "Document does not have a root element" exception which may be contributing to Mantis 7397 and possibly 7439
2015-02-21 00:08:49 +00:00
Justin Clark-Casey (justincc) c90c22ed28 If HGAssetMapper.PostAsset fails then be more explicit about the uuid, type, size and base asset uuid of the failure for debugging purposes. 2015-02-19 23:50:25 +00:00
Justin Clark-Casey (justincc) 7a86b01226 Make any exception that gets to LLClientView.ProcessSpecificPacketAsync() tells us the exception type as well as the message and stacktrace details. 2015-02-19 23:09:43 +00:00
Justin Clark-Casey (justincc) 264047dba0 Add the type of the unrecognized node to the HG asset mapping error message in TransformXml() 2015-02-19 22:39:22 +00:00
dahlia e4f0cdd263 Comment out unnecessary "Region Found!" alert message when searching map 2015-02-18 12:52:16 -08:00
dahlia 8b2af1071f Add NaN and Infinity tests for SOP Velocity and Acceleration setters. 2015-02-16 23:51:37 -08:00
dahlia 78814a1533 Use a boolean flag to signal lookat is running instead of Quaternion.Identity so it can be a valid target orientation 2015-02-16 19:42:36 -08:00
dahlia 2700b096bc Filter NaN and Infinity values at SOP AngularVelocity setter 2015-02-16 19:06:01 -08:00
Justin Clark-Casey (justincc) 85f3380480 Add missing BSD headers to files in OpenSim/Framework/ServiceAuth 2015-02-13 21:00:10 +00:00
Justin Clark-Casey (justincc) dd6f560c05 If serialized scene object XML has a SavedScriptState with no UUID, then read past the innerXML instead of wrongly continously looping on the same element.
Addresses http://opensimulator.org/mantis/view.php?id=7437
2015-02-11 00:53:56 +00:00
dahlia 53b23a9adc Somewhat naive implementation of RotationalVelocity setter for ODE. Enables llSetRotationalVelocity(), llTargetOmega(), llLookAt(), and probably a few more LSL features for physical objects in ODE. 2015-02-07 22:52:12 -08:00
dahlia 12119a9d7d llLookAt() strength parameter should slow rotation as it is increased. Thanks Vegaslan for pointing this out. 2015-02-07 17:39:46 -08:00
dahlia 2ed1afd32b llLookAt(): reduce and clamp strengh to reduce probability of overshoot 2015-02-07 14:17:37 -08:00
dahlia 506e62f815 llLookAt() and llRotLookAt(): all orientation updates now done via angular velocity manipulation. Also correct some orientation glitches during interpolation. 2015-02-06 22:36:26 -08:00
dahlia 3b7c3378f1 Manage Angular Velocity during llLookAt() rotation of physical objects 2015-02-05 23:13:06 -08:00
dahlia ee810a2cb5 Set angular velocity in physics actor in SceneObjectPart.AngularVelocity setter. Enables llSetAngularVelocity() 2015-02-05 14:29:51 -08:00
dahlia 95a0f0d47b replace accidently deleted line from last commit 2015-02-05 13:44:39 -08:00
dahlia bde7b2a7b5 Allow MaterialsModule to be enabled by default if [Materials] is absent from OpenSim.ini 2015-02-05 13:17:31 -08:00
Justin Clark-Casey (justincc) 765fd02418 For built-in groups, if a delegate throws an exception (e.g. due to network failure), always remove its request from the m_ActiveRequests list.
If this is not done, all subsequent calls for the same data see that a request is apparantly already in progress and so wait for the result indefinitely.
2015-02-04 17:04:59 +00:00
Justin Clark-Casey (justincc) 6834393821 Fix bug in JobEngine where an attempt to restart after stop would trigger an exception because the cancellation source was not recreated. 2015-02-04 00:10:44 +00:00
Justin Clark-Casey (justincc) 1d2616e7a2 If the owner of an object is taking a copy from the scene (e.g. via the "take copy" option on a viewer) then only require owner copy perms, not copy and transfer.
This matches Linden Lab behaviour and what was already possible via shift-copy.
Transfer would not apply here as the owner and copier are the same.
This is the only functional change, all other current take copy logic remains the same.
Adds regression tests around relevant take copy cases.
2015-02-03 23:43:30 +00:00
dahlia 39754b2dca correct some minor comment misspellings in last commit 2015-02-02 04:03:04 -08:00
dahlia 1eedc2b4af Compute rotation for llLookAt() with local positive X axis pointing down 2015-02-02 02:47:47 -08:00
AliciaRaven bee3933e57 Prevent null entries being treated as URI's when DataSnapshot service splits service string. The new config format for services to notify in the DataSnapshot module appends entries to the existing single string and always leaves a deliminator on the end of the string. This is causing it to split with a null string in the resulting array, which is treated as another service to notify and throws a URI format exception on start up. 2015-02-01 10:29:47 -08:00
Justin Clark-Casey (justincc) 87936947ab As per advice from Singularity devs, set is_display_name_default = true in GetDisplayName cap return data to make the single name appear.
This is still always your avatar name - code to set a different display is not yet implemented.
This works from my testing with current Firestorm and Singuarity releases.
2015-01-31 00:17:59 +00:00
Justin Clark-Casey (justincc) c5c1b7c61a Revert "Stop currently unsettable display names from appearing when [ClientStack.LindenCaps] Cap_GetDisplayNames = "localhost" is set by never passing the username."
This reverts commit 2d574c3036.
2015-01-31 00:17:36 +00:00
Justin Clark-Casey (justincc) 557b0fae85 minor: correct log message when script with non-config stop strategy is detected to log actual strategy rather than true/false 2015-01-29 18:28:17 +00:00
Justin Clark-Casey (justincc) b4e955d1c1 Avoid a possible race condition by serializing plugin data outside the EventQueue lock in ScriptInstance.SaveState()
This takes the AsyncCommandHandler.staticLock.
However, AsyncCommandHandler.DoOneCmdHandlerPass() already holds staticLock and may attempt to take the EventQueue lock via ScriptInstance.PostEvent() in XEngine.CheckListeners()
This is a regression from faaf47a (Fri Jan 16 2015) but not simply reverting that commit since it will reintroduce a race between script removal, backup and event queue manipulating code.
2015-01-29 17:55:08 +00:00
Justin Clark-Casey (justincc) cf0087e87c Correct typo in raw default script stop strategy 2015-01-27 21:04:11 +00:00
Justin Clark-Casey (justincc) e0a3440263 If [XEngine] ScriptStopStrategy is different from a compiled script strategy, ask user to manually set DeleteScriptsOnStartup = true for at least one simuator session rather than auto-recompiling.
This does not work on Windows since the VM retains a handle to the DLL even if class instantiation was unsuccessful.
Which causes deletion of the old DLL to fail with access sharing violations.
Instead, log a warning in this situation asking the user to manually set DeleteScriptsOnStartup = true for a session (or one could separately delete the DLLs in the relevant bin/scriptengines/<region-uuid> dir
For the current session, the script engine will continue using the script compiled stop strategy as before.
Relates to http://opensimulator.org/mantis/view.php?id=7278
2015-01-27 19:07:20 +00:00
Justin Clark-Casey (justincc) 13ba2f2d83 If an exception comes out of DoOnRezScript in DoOnRezScriptQueue(), then only fail a single script rather than halting the exntire script startup process. 2015-01-26 23:32:51 +00:00
Justin Clark-Casey (justincc) 1bed3aff0b On a multi-region simulator when AppDomain = true, make sure the DLL from the appropriate script engines subdir is loaded rather than always that of the first engine to load the DLL.
This resolves a DLL load failure on my Linux box when an attachment script was present on another region before the avatar arrived.
2015-01-26 23:31:46 +00:00
Robert Adams de76116624 BulletSim: add parameters and parameter definitions for VHACD
addition coming.
2015-01-25 13:24:09 -08:00
Justin Clark-Casey (justincc) 3289aa3bcd Revert "In GetDisplayNames, if user last name is Resident then only send first name for display."
Reverting at this point since it may not work well with all viewers.
Requires further investigation.

This reverts commit a29d53986a.
2015-01-24 00:51:45 +00:00
Justin Clark-Casey (justincc) a29d53986a In GetDisplayNames, if user last name is Resident then only send first name for display.
This is to match existing behaviour with UDP behaviour where this is masked out.
And to make it consistent with other places where viewers mask this out themselves.
Relates to http://opensimulator.org/mantis/view.php?id=7408
2015-01-23 23:17:49 +00:00
Justin Clark-Casey (justincc) 840e440541 When deleting an assembly before re-compile, make sure its attributes allow deletion.
This is to see if this helps with the problem in http://opensimulator.org/mantis/view.php?id=7278 where some DLLs are not allowing this.
Since OpenSim created the file it should always be allowed to delete it.
2015-01-23 00:45:51 +00:00
Justin Clark-Casey (justincc) d0a2ea0857 Fix regression where the stored state of every second script in an object rezzed from inventory (e.g. attachments) was no longer loaded.
Likely a regression since f132f642 (2014-08-28)
Relates to http://opensimulator.org/mantis/view.php?id=7278
2015-01-23 00:27:57 +00:00
Diva Canto edc155c636 Merge branch 'master' of ssh://opensimulator.org/var/git/opensim 2015-01-22 10:45:46 -08:00
Diva Canto 185e7048c8 On the GridService, the central simulator features: ensure that the map tile url ends with '/' because the viewer is dumb and just appends to it. 2015-01-22 10:45:07 -08:00
Justin Clark-Casey (justincc) 2d574c3036 Stop currently unsettable display names from appearing when [ClientStack.LindenCaps] Cap_GetDisplayNames = "localhost" is set by never passing the username.
Unexpectedly, not setting user name achieves this whereas one might have expected it to be done by not setting display_name in the cap OSD.
Emulates LL behaviour when no display name is set.
Relates to http://opensimulator.org/mantis/view.php?id=7408
2015-01-21 22:26:35 +00:00
Justin Clark-Casey (justincc) aef6fd6927 If the SnedInventoryAync() method receives an exception log this but make sure it does not terminate the process.
Relates to http://opensimulator.org/mantis/view.php?id=7421
2015-01-21 20:54:23 +00:00
Justin Clark-Casey (justincc) ed8d0fbea4 Don't allow a failure in create a request in HeloService.Connector.Helo() to propogate up the stack.
Relates to http://opensimulator.org/mantis/view.php?id=7421
2015-01-21 20:46:29 +00:00
Justin Clark-Casey (justincc) 155da5aad2 Add debug ability to ignore reliably sent packets that are not acknowledged.
This is controlled via the console command "debug lludp client set process-unacked-sends true [<avatar-first-name> <avatar-last-name>]"
For debug purposes to see if this process for very bad connections is causing general outbound udp processing delays.
Relates to http://opensimulator.org/mantis/view.php?id=7393
2015-01-21 20:31:42 +00:00
AliciaRaven abf1836b81 Fix OfflineIMEmail value overwriting every time its called. The request was receiving a blank user prefs object to populate but then was checking for an email address. When this failed the email address was pulled from the User Account service and the empty prefs now including the email was saved before being loaded again to be returned. This was overwriting all other settings in the prefs. This fix returns the existing prefs first before checking the email address is set, and only updates email if missing. 2015-01-21 00:57:06 +00:00
Justin Clark-Casey (justincc) 372a7bf78e minor: Comment out log line for the SimulatorFeatures cap request for now to reduce log verbiage. Please revert if still required. 2015-01-21 00:34:51 +00:00
Justin Clark-Casey (justincc) 25dd30ddb6 minor: Fix some CR line endings in Scene.Inventory.cs 2015-01-21 00:33:54 +00:00
Justin Clark-Casey (justincc) a846e63c70 If [Permissions] serverside_object_permissions = false or the undocumented propogate_permissions = false, don't propogate permissions of prim inventory items.
This was a regression from 13f31fd (4 Nov 2013)
Relates to http://opensimulator.org/mantis/view.php?id=7399
2015-01-21 00:21:27 +00:00
Justin Clark-Casey (justincc) ac93ba9f85 minor: correct SceneCommunicationService.LogHeader spelling
Relates to http://opensimulator.org/mantis/view.php?id=7337
2015-01-20 00:19:33 +00:00
Justin Clark-Casey (justincc) 4b8215c893 minor: comment out unusued logging objects in some pCampbot behaviour classes 2015-01-20 00:18:25 +00:00
Justin Clark-Casey (justincc) 24ef043395 Make failures in PollServiceHttpRequest.DoHTTPGruntWork() actually log the exception on error 2015-01-19 23:52:34 +00:00
Justin Clark-Casey (justincc) 1f04e1bc23 minor: In AttachmentsModule.UpdateKnownItem use the existing IInventoryAccessModule reference that other methods are already using rather than fetching its own copy. 2015-01-17 00:08:16 +00:00
Justin Clark-Casey (justincc) 2995868176 Make XEngine.SaveAllState() actually do this instead of script maintenance 2015-01-17 00:05:13 +00:00
Justin Clark-Casey (justincc) 0eb268e265 minor: remove old commented out objectRemoved bool in XEngine.OnRemoveScript() 2015-01-16 23:59:08 +00:00
Justin Clark-Casey (justincc) 58f7efc41a Add clearqueue code adjustment that should have been in previous commit faaf47a 2015-01-16 23:57:51 +00:00
Justin Clark-Casey (justincc) faaf47a86f Prevent a race condition between the script engine backup thread and script removal by locking on the script's EventQueue and only proceeding if it's flagged as still running.
Relates to http://opensimulator.org/mantis/view.php?id=7407
2015-01-16 23:55:11 +00:00
Justin Clark-Casey (justincc) 8d724e90de For scripts in attachments, don't save .state files apart from the initial one as these are ignored since .state is saved in the attachment's asset.
This eliminates pointless work and exceptions when an appdomain is unloaded whilst an attachment script state is persisted.
Adds test for this case.
Relates to http://opensimulator.org/mantis/view.php?id=7407
2015-01-16 22:46:48 +00:00
Justin Clark-Casey (justincc) 97ac80d664 minor: Suppress the log messages when user profiles data is requested for an NPC or an HG user with no set server URI to avoid log spam.
Messages concerning failure to contact a given user profiles service are preserved by logging within called code with the agent ID.
If the "No Presence - foreign friend" log message is important then please revert.
Relates to http://opensimulator.org/mantis/view.php?id=7414
2015-01-16 00:54:32 +00:00
Justin Clark-Casey (justincc) b22c072c40 Fix a recent regression with HG asset posting to other grids where the assets were no longer being posted.
Addresses regression from 08606ae (Thu Jan 8 2015)
2015-01-15 23:44:34 +00:00
Justin Clark-Casey (justincc) beef41f24c Stop simulators attempting to contact registered but offline regions (RegionFlags.Persistent but not RegioNFlags.RegionOnline) on startup and when an avatar completes a teleport.
This eliminates spurious network calls and failure reporting.
This is done by adding RegionFlags to the GridRegion returned data in a backward compatible way as an alternative to multiple IGridService.GetRegionFlags() calls
Using a simulator or a grid service older than this commit will just see previous behaviour.
2015-01-14 19:45:19 +00:00
Diva Canto 8cc590cf80 And finally renamed the classes themselves. 2015-01-13 22:21:50 -08:00
Diva Canto 034fc325c0 Renamed the folder too. 2015-01-13 21:25:11 -08:00
Diva Canto a626de696a Renamed these 2 files, because their names are misleading. This is no longer called WebFetchInventoryDescendents, and we no longer use that cap; the viewers use FetchInvventoryDescendents2. 2015-01-13 21:24:01 -08:00
Justin Clark-Casey (justincc) 9363d4c784 Use ToString() on uuids returned in PGSQLUserProfilesData.GetUserImageAssets(). These are Guids rather than strings so casting to string generates a casting exception.
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-14 00:00:02 +00:00
Justin Clark-Casey (justincc) 02f2352ad5 Fix PGSQLUserProfilesData.GetUserPreferences error when no usersettings yet exist by inserting missing ID parameter.
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-13 23:52:52 +00:00
Justin Clark-Casey (justincc) 71d73777d9 Revert "Remove quotes from column selection in PGSQLUserProfilesData.UpdateAvatarProperties()"
This reverts commit fdecf4f610.
2015-01-13 21:53:28 +00:00
Justin Clark-Casey (justincc) 8f37a61912 Revert "Remove quotes from column selection in PGSQLUserProfilesData.UpdateAvatarInterests()"
This reverts commit f31feef6c1.
2015-01-13 21:53:18 +00:00
Justin Clark-Casey (justincc) 39989eda3b Revert "Remove quotes from column selection in PGSQLUserProfilesData.GetUserImageAssets()"
This reverts commit bd9539c2a7.
2015-01-13 21:53:04 +00:00
Justin Clark-Casey (justincc) 38f2b89248 Revert "Remove misstaken quotes from column selection in PGSQLUserProfilesData.GetUserAppData()"
This reverts commit 0794a40378.
2015-01-13 21:52:43 +00:00
Justin Clark-Casey (justincc) f9d2121bcf Revert "Remove quotes from column selection in PGSQLUserProfilesData.SetUserAppData()"
This reverts commit 59c0df962a.
This is necessary to preserve the casing of column names, otherwise pgsql converts everything to lowercase.
TIL, Unlike mysql, a quoted column still refers to the column itself...
2015-01-13 21:50:11 +00:00
Justin Clark-Casey (justincc) 24695dc05b Fix PGSQLUserProfilesData.UpdateUserPreferences() imviaemail and visible casts. These should be left as bools, not converted to strings.
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-13 21:40:49 +00:00
Justin Clark-Casey (justincc) 46e8a99526 Change PGSQLUserProfilesData.UpdateUserPreferences() to directly pass the UUID to the uuid parameter instead of its ToString()
This may well be the cause behind "operator does not exist: uuid = character varying" pgsql errors.
If so, the other instances will also be changed.
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-13 21:13:57 +00:00
Justin Clark-Casey (justincc) 492d49eb08 Fix MySQL and PGSQL *UserProfilesData.GetUserAppData() calls to correctly set the UserId parameter instead of the non-existing Id parameter when writing a record because none yet exists.
SQLite version is already correct for this.
2015-01-13 20:33:36 +00:00
Justin Clark-Casey (justincc) 59c0df962a Remove quotes from column selection in PGSQLUserProfilesData.SetUserAppData()
This may have been preventing it from working.
2015-01-13 20:27:37 +00:00
Justin Clark-Casey (justincc) 55ae9a7d10 Remove extraneous colon when setting TagId parameter in PGSQLUserProfilesData.GetUserAppData() 2015-01-13 20:15:37 +00:00
Justin Clark-Casey (justincc) 55e081548c Fix bug where gathering the clientstack..OutgoingPacketsQueuedCount stat would fail with a casting exception for scenes with NPCs
Present since 51eb8fa (Oct 2 2014)
2015-01-13 19:27:29 +00:00
Justin Clark-Casey (justincc) 0794a40378 Remove misstaken quotes from column selection in PGSQLUserProfilesData.GetUserAppData() 2015-01-13 19:20:27 +00:00
Justin Clark-Casey (justincc) bd9539c2a7 Remove quotes from column selection in PGSQLUserProfilesData.GetUserImageAssets()
This may have been preventing it from working.
2015-01-13 18:57:32 +00:00
Justin Clark-Casey (justincc) f31feef6c1 Remove quotes from column selection in PGSQLUserProfilesData.UpdateAvatarInterests()
This may have been preventing it from working.
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-13 18:54:41 +00:00
Justin Clark-Casey (justincc) fdecf4f610 Remove quotes from column selection in PGSQLUserProfilesData.UpdateAvatarProperties()
This may have been preventing it from working.
2015-01-13 18:52:49 +00:00
Justin Clark-Casey (justincc) 0cc75a0a3c Remove quotes from column selection in PGSQLUserProfilesData.GetAvatarNotes()
This may have been preventing it from working.
2015-01-13 18:50:34 +00:00
Justin Clark-Casey (justincc) b38a552fd6 Remove quotes from field selection in PGSQLUserProfilesData.GetAvatarPicks()
This may have been preventing it from working.
2015-01-13 18:47:51 +00:00
Justin Clark-Casey (justincc) 43b094f549 minor: correct two exception messages in PGSQLUserProfilesData where I copy/pasted AgentInterestsUpdate twice 2015-01-13 18:42:04 +00:00
Justin Clark-Casey (justincc) 02dcfcf537 Remove the locking in PGSQLUserProfilesData which was buggy (Lock object wasn't set!) and is unnecessary.
Relates to http://opensimulator.org/mantis/view.php?id=7398
2015-01-12 23:39:27 +00:00
Justin Clark-Casey (justincc) 0c31eb0a5d Add the missing deleted and re-added JobEngine class from the previous commit 8e1e8a0 2015-01-12 20:59:58 +00:00
Justin Clark-Casey (justincc) 8e1e8a0920 Make the performance controlling job processing threads introduced in conference code use a generic JobEngine class rather than 4 slightly different copy/pasted versions. 2015-01-12 20:56:37 +00:00
Diva Canto 2fd252f5a9 SimulatorFeatures: the viewer also takes GridName in OpenSim extras. Added that (plus GridURL, in case viewers want to use it too) to the GridService that gives out that info to simulators. 2015-01-10 10:32:33 -08:00
Diva Canto 20b34135cb Merge branch 'master' of ssh://opensimulator.org/var/git/opensim 2015-01-09 08:32:40 -08:00
Diva Canto e2dd15625f Added GetDisplayNames capability. For now, we don't actually use display names, and this cap returns the regular name. But this moves the server side into the newer, preferred, protocol used by the viewer for fetching the names of agents in the scene given their UUIDs. (the old protocol is via UDP). This works fine in my limited tests, but could use further testing by others. 2015-01-09 08:31:56 -08:00
Justin Clark-Casey (justincc) 38590a4fad Get PGSQL UserProfilesData to log the exception trace for debugging rather than just the exception message. 2015-01-09 00:19:48 +00:00
Justin Clark-Casey (justincc) dbd500db42 minor: Add event name to existing debug output when a script event fails with an exception. To aid debugging. 2015-01-08 22:59:29 +00:00
Justin Clark-Casey (justincc) 801a86ca03 When inspecting a script or notecard, also try to look up any assets embedded therein.
This is primarily to fix an issue where inventory items for NPC attachments would not be saved in archives as the assets referenced in the appearance notecard were not checked in this manner.
Relates to http://opensimulator.org/mantis/view.php?id=7376
2015-01-08 20:36:03 +00:00
Justin Clark-Casey (justincc) 08606ae409 Make the IteratingUuidGatherer the only UuidGatherer.
This UUID gatherer provides a superset of the previous gatherer's functionality
as it also allows the caller to control gathering iterations for load purposes.
2015-01-08 20:21:40 +00:00
Diva Canto 9dc4b2c479 Commented out clear_registry_ because (1) it isn't clearing up anything anymore -- mono addins moved to suffix -002 at least since BlueWall updated it; (2) we shouldn't clear the registry, period. People who run many sims from the same bin folder need to configure each sim to use its own RegistryLocation, just like they configure them to use their own port. 2015-01-07 20:01:54 -08:00
Diva Canto 14b3ee636d Merge branch 'master' of ssh://opensimulator.org/var/git/opensim 2015-01-07 11:09:04 -08:00
Diva Canto 46ab59723d Added a different/better way of specifying data services in DataSnapshot -- using DATA_SRV_ keys, one per service. This allows 3rd party modules to add data services automatically. 2015-01-07 11:04:23 -08:00
Robert Adams 6e2b532255 BulletSim: fix line ending problems. 2015-01-07 06:46:08 -08:00
Robert Adams 4959dbba5e BulletSim: make computation of hole cut in hull tester explicit
math showing the odd PrimitiveBaseShape value rather than a constant.
2015-01-07 06:42:41 -08:00
Robert Adams 700543b161 BulletSim: tweek step parameters and logic to make walking up steps
closer to SL. This change should address small floor edges acting like
walls, approaching a step at any angle (other than walking backwards)
will allow walking up, and reducing the avatar pop-up when going up
stairs.
2015-01-07 06:39:29 -08:00
Diva Canto 8e562f04d1 Donation of robust network connectors for estate service, as promised. This allows to have one central database for estates without having to open the MySql port. This is off by default, so not to disturb everyone's existing installations. To use it, see GridCommon.ini.example [EstateDataStore] section and Robust*.ini.example's new additions.
Note that I also made things consistent by removing both the EstateDataService and the SimulationService into their own dlls, just like all other services. They really didn't belong in Services.Connectors, since everything in that component is about network connectors to robust backends. We may have too many dlls, and at some point it might not be a bad idea to merge all services into one single dll, since they all have more or less the same dependencies.
2015-01-06 21:24:44 -08:00
Diva Canto 502aa7bb15 Merge branch 'master' of ssh://opensimulator.org/var/git/opensim 2015-01-04 19:07:40 -08:00
Diva Canto ce1a87b784 Added overloaded LoadArchSpecificWindowsDll, to help addins load native libraries. 2015-01-04 19:06:49 -08:00
Robert Adams 103aad27f2 BulletSim: comment out the reference to BSShapeHull in BulletSim tests
which seems to cause the tests to fail when compiled on the OpenSim
   build system. It compiles and runs everywhere else. More research is needed.
2015-01-04 14:26:50 -08:00
Robert Adams a617159f8b BulletSim: correct some of the debugging input and output of PrimitiveBaseShape.
Whoever defined that structure was really into esoteric coding.
2015-01-04 13:52:14 -08:00
Diva Canto 53c8318124 Added utility function that simplifies configuration loading of all addins. 2015-01-03 21:53:18 -08:00
Diva Canto b379eaa169 Remove the extra key expansion added in commit a88bc50a16. It's not needed. 2015-01-03 07:56:00 -08:00
Diva Canto 04e76dc5d6 Comment out the suppression of console output for mono addins in robust too. Seriously, ppl, let's not ignore important warning messages! 2015-01-02 21:47:23 -08:00
Diva Canto 63e771b593 Merge branch 'master' of ssh://opensimulator.org/var/git/opensim 2015-01-02 09:18:05 -08:00
Diva Canto bd2ec3edf5 Bug fix in LoadPLugin so that it can take paths to dlls that look like this "C:\foo\MyDll.dll:MyType" -- the split on : was messing things up. 2015-01-02 09:16:39 -08:00
Diva Canto 7d1c59b8e3 Changed the Robust-as-addin version number to match OpenSim release numbers. 2015-01-02 09:15:30 -08:00
Robert Adams 7c2aeb9e8e Fix cut-and-paste error that made StatsManager web fetch queries
fail for container specification.
2015-01-01 09:39:07 -08:00
Robert Adams 2496da2dac BulletSim: remove compile reference error trying to figure out why mono compiling doesn't like it 2014-12-31 13:45:12 -08:00
Robert Adams c89d0e26b2 BulletSim: add the beginnings of hull creation unit testing.
Change how physics engine is created in unit tests to resolve a lib reference problem.
Add ShapeInfoInfo class to collect info about the created physical shape
   for debugging and unit test testing.
2014-12-31 12:48:26 -08:00
Robert Adams 291c7cdbcc BulletSim: Add axis locking enabled through the ExtendedPhysics module.
Allows locking of prim/linkset relative moving in each of the linear
and angular axis. Limits on movement or rotation can be set.
2014-12-31 12:43:26 -08:00
Diva Canto b40935837c Fixed declaration switcharoo on the region combiner dll. 2014-12-31 08:20:17 -08:00
Diva Canto 998ef665a8 Commenting out the suppression of console warnings from Mono addins while we test this new model for the next couple of weeks. 2014-12-31 00:01:47 -08:00
Diva Canto 3375841fee Capitalization fail. 2014-12-30 23:47:11 -08:00
Diva Canto 0af02efaed Merge branch 'master' of ssh://opensimulator.org/var/git/opensim 2014-12-30 20:05:33 -08:00
Diva Canto a88bc50a16 Add support for expansion of key values in nini config files.
Add loading of 3rd-party addin inis automatically.
2014-12-30 20:05:12 -08:00
Mic Bowman bc7570e59c Merge branch 'mb-throttle-test'
Merge in the new throttle code.
2014-12-30 16:26:57 -08:00
Diva Canto 2138d5c7f8 Renamed VERSION_NUMBER to VersionNumber 2014-12-30 15:27:28 -08:00
Mic Bowman 5bb73793c7 Comment out the debugging statements added in the last commit. Keeping
them in the code for later use rather than just reverting them.

Fixed the throttle tests for the new algorithm used when packets
are marked as expired.
2014-12-30 14:43:42 -08:00
Diva Canto 7466ef0525 This cleans up versioning. Specifically:
- It establishes 4 digits for opensim versions
- It uses the same number between opensim releases and mono addins versions

It also eliminates the last addin.xml files that were still there, for consistency.
2014-12-30 12:53:31 -08:00
Mic Bowman 58229a968b Turn on logging of old acks, this is for debugging only, stats version coming later 2014-12-30 10:50:34 -08:00
Mic Bowman c06100c31f Another technique inspired by some of the newer flow control algorithms... rather
than drop exponentially to 0 (and then adjust up for the minimum flow), drop on
the delta between current rate and the minimum rate. This should smooth the fallback
to minimum.
2014-12-30 10:39:14 -08:00
Mic Bowman 75df04f0b3 Fix the throttle tests. Remove the hardcoded constant multipliers and
compute the expected values without depending on the token bucket code.
2014-12-30 10:03:37 -08:00
Diva Canto 2506728e35 Merge branch 'master' of ssh://opensimulator.org/var/git/opensim 2014-12-30 07:59:09 -08:00
Diva Canto 5cf6a6f830 WARNING: BREAKING CHANGES FOR REGION MODULE DEVELOPMENT.
This cleans up Opensim's use of mono addins. In particular, the extension points /OpenSim/RegionModules and /OpenSim/WindModule moved from OpenSim.exe to OpenSim.Region.Framework.dll. From here on, developers of region modules should declare their dlls to be dependent on OpenSim.Region.Framework, starting with version 0.8.1
Additional changes:
- Addins version uniformly updated to 0.8.1. These numbers should be compatible with the release numbers or else it becomes very confusing.
- Mono addins directives moved from files addins.xml to embedded directives in the class and assembly declarations, to make it all consistent
2014-12-30 07:58:42 -08:00
Mic Bowman bda8f2a2c1 Change the effect of successfully acknowledged packets to bump the
adaptive throttle by a full MTU. This is consistent with some implementations
of congestion control algorithms and certainly has the effect of opening
the throttle window more quickly after errors. This is especially important
after initial scene load when the number and size of packets is small.
2014-12-29 23:19:10 -08:00
Mic Bowman 041a09ecb9 Enable runtime configuration of the minimum rate for adaptive
throttles. Setting adaptive_throttle_min_bps will change the
minimum rate that the adapative throttles will drop to in case
of network packet loss. The current rate default rate is 256kbps.
The viewer can throttle rates under that amount, but the dynamic
adaptation will not.
2014-12-29 18:46:33 -08:00
Justin Clark-Casey (justincc) 5410e4f1f9 minor: correct sent -> set in TokenBucket.RequestedDripRate method doc 2014-12-30 00:53:17 +00:00
Diva Canto 89c1ac4cff Updated OpenSim-as-addin version from 0.5 to 0.8.1. The addin version number doesn't need to match the release version number, but I think it's a very good idea that they do. 2014-12-29 15:05:44 -08:00
Diva Canto 601849b4fa Added AssemblyInfo.cs to OpenSim.exe 2014-12-29 14:13:17 -08:00
Mic Bowman e71549a2cb Add debugging code for simulating packet loss in outgoing UDP packets. The
algorithm for dropping packets is a modified two state algorithm for creating
bursts of dropped packets. As configured there is about a 1.5% drop rate.

Invocation of the packet loss code is commented out by default.
2014-12-29 12:02:36 -08:00
Diva Canto bb82076a4d Allow for richer semantics of object derez. Specifically, allow the existence of region modules that do other kinds of garbage collection. Instead of placing deleted objects in the user's Trash folder, or deleting them immediately (UseTrashOnDelete = false), a module may decide to take garbage collection under its control. For example, it may place derezzed objects in a certain area inworld and delete them later. 2014-12-25 12:17:07 -08:00
Justin Clark-Casey (justincc) fc940ab09a If a moap entry has EnableWhiteList but WhiteList == null, then properly block the request instead of throwing an exception.
Normally, WhiteList is an empty list but from Mantis 7389 it looks like it might sometimes be possible for it to be null (haven't seen this up till now)
It looks like failing with an exception instead of properly replying to the request (which comes in via a cap) might be enough, surprisingly, to freeze a viewer until timeout.
Part of http://opensimulator.org/mantis/view.php?id=7389 but probably unrelated to the actual issue of that mantis.
2014-12-23 20:38:20 +00:00
Justin Clark-Casey (justincc) 7100475b90 Make sure we always dispose of disposables inside RestClient.Request() 2014-12-20 01:56:33 +00:00
Justin Clark-Casey (justincc) 9cff0bbd7c In XBakesModule.Get() use using() to always dispose of RestClient which disposes the stream rather than disposing the stream directly 2014-12-20 01:46:32 +00:00
Justin Clark-Casey (justincc) e3d07bd0cc minor: Correct propery doc RestClient._resource spelling mistake 2014-12-20 01:39:31 +00:00
Justin Clark-Casey (justincc) 798074c66f Use using() semantics in XBakesModule to ensure disposable objects are alway disposed no matter what 2014-12-20 01:38:48 +00:00
Justin Clark-Casey (justincc) 9edc5cac96 In XBakes use proper disposal semantics to always close the stream on Store() no matter what 2014-12-20 01:32:49 +00:00
Justin Clark-Casey (justincc) e901253b49 Fix recent regression where a race condition meant SP.MakeRootAgent() would sometimes look to start attachment scripts before ETM.HandleIncomingSceneObject() had added them.
Probably a regression since ghosts branch merge on Nov 26 2014
2014-12-17 00:25:24 +00:00
BlueWall e50aac020f Add command to reset region's user cache 2014-12-16 12:47:02 -05:00
BlueWall b39d697555 Adding command to reset user's email address 2014-12-16 12:20:56 -05:00
Justin Clark-Casey (justincc) 147d401b28 Remove XEngine.m_uniqueScripts
This provides no obvious benefit as far as I can tell but has a definite cost in keep script strings in memory for the entire simulator session.
2014-12-15 20:38:26 +00:00
Justin Clark-Casey (justincc) 2b9f0647de Fix a regression where objects crossing regions in the same simulator (on their own or as attachments) with AppDomainLoading = false would create the new state in the source region area rather than the dest.
This was beause the code was finding the script DLL compiled for the source region as everything is in the same appdomain and using this as the location for the destination script state, etc.
This resolves the regression by passing the proper destination separately from the DLL retrieved.
Probably a regression since commit d7b92604 (11 July 2014).
Added regression test for this case.
At least partly addresses http://opensimulator.org/mantis/view.php?id=7278
2014-12-10 00:25:27 +00:00
Justin Clark-Casey (justincc) 227d2e2b61 Avoid a possible race condition where the XEngine script compile thread could complete but see OnRezScript() insert a new job and complete before it set m_CurrentCompile = null
If the above happened, it would mean the new script would not compile until some  script was added for compilation.
2014-12-10 00:04:10 +00:00
Justin Clark-Casey (justincc) 76722d8324 In XEngine, enqueue a script rez to the compile queue after setting m_CompileDict to avoid a rare but not impossible race condition. 2014-12-09 23:59:19 +00:00
Justin Clark-Casey (justincc) f3ab7c0f5c refactor: rename IteratingUuidGather.AddAssetUuidToInspect() and RecordAssetUuids() to AddForInspection() as this properly describes what both of these methods do. 2014-12-05 00:21:42 +00:00
Justin Clark-Casey (justincc) b0ff3236be Make "fache assets" console command more efficient by only updating access times on each cached asset once, not for every reference. 2014-12-05 00:09:01 +00:00
Justin Clark-Casey (justincc) 9208fb5d54 refactor: Make IteratingUUIDGatherer take a dictionary in its constructor like UUIDGatherer, so we can deal with future cases where the dictionary may already be pre-populated. 2014-12-04 23:55:59 +00:00
Justin Clark-Casey (justincc) bee3f203cd Allow scripts in attachments on an owned NPC to call NPC functions on that NPC 2014-12-04 22:52:46 +00:00
Justin Clark-Casey (justincc) 9dbe99af0f If "fcache assets" is executed, don't stop with an exception if there's an access violation if another thread is operating on the file at the same time.
Resolves one issue from http://opensimulator.org/mantis/view.php?id=7271
2014-12-04 01:53:42 +00:00
Justin Clark-Casey (justincc) ad91143880 refactor: breakout flotasm cache last file access time to separate UpdateFileLastAccessTime() method for imminent reuse. 2014-12-04 01:51:01 +00:00
Justin Clark-Casey (justincc) c36bfdc60f Don't worry about checking FlotsamAssetCache.m_CurrentlyWriting when updating access time.
The majority of updates won't be for anything currently writing and any sharing exception from an actual clash can be caught and ignored anyway.
2014-12-04 01:46:00 +00:00
Justin Clark-Casey (justincc) 5861401faa Remove long unused region parameters from SceneBase. Some of these weren't even being set. Region parameters come from Scene.RegionInfo instead. 2014-12-03 21:44:22 +00:00
Justin Clark-Casey (justincc) 2d2aa6e076 minor: Just have one message that displays successful registration of a region with its parameters rather than 2 2014-12-03 21:40:39 +00:00
Justin Clark-Casey (justincc) d34ad345d5 minor: If we are recompiling scripts in response to a ScriptStopStrategy config change (a rare situation), then explicitly log this for debug purposes. 2014-12-03 21:08:43 +00:00
Justin Clark-Casey (justincc) c3c05a8693 Reintroduce general xengine extra debugging log level. This can be controlled at runtime with the command "debug xengine log <level>", as with similar commands.
If log level is 1 then every script load is logged.
This means the <logger name="OpenSim.Region.ScriptEngine.XEngine"> section in OpenSim.exe.config is no longer needed to avoid log spam on regions with many scripts and can be removed.
2014-12-03 20:48:17 +00:00
Justin Clark-Casey (justincc) 805b7ccb3e minor: improve logged error in XEngine.SetXmlState if there was a problem writing the linemap.
The previous error report of already exists is inaccurate since existing files do get overwritten.
2014-12-03 20:35:49 +00:00
Justin Clark-Casey (justincc) 72d1d96c5c Always close script linemap file after reading and always dispose of other streams in the script engine even if exceptions are thrown. 2014-12-03 20:31:09 +00:00
Robert Adams 3642198838 BulletSim: move detail log of InternalScheduleRebuild to reduce log file spam 2014-11-30 19:53:00 -08:00
Robert Adams 63d192f011 BulletSim: Remove linkset 'Incomplete' flag as its meaning couldn't be made clear. Add 'InternalScheduleRebuild() CHange rebuild code to call InternalScheduleRebuild() rather than ForceRebuild() to limit the scope of the changes made by the linkset. 2014-11-30 19:53:00 -08:00
Robert Adams 41a943bfd0 BulletSim: add BSLinkset.AllPartsComplete that checks of all linkset members are not Incomplete and not waiting for assets. Change BSPrimLinkable to use AllPartsComplete. 2014-11-30 19:52:59 -08:00
Robert Adams eef954a214 BulletSim: Make BSPrimLinkable 'incomplete' if any of its children are waiting for assets to load. 2014-11-30 19:52:59 -08:00
Robert Adams cf85ade81e BulletSim: add shape and linkset rebuild scheduled flags. Add BSPrim.Incomplete flag based on rebuild flags to say when an object is being rebuilt. 2014-11-30 19:52:58 -08:00
Justin Clark-Casey (justincc) 432f0e8783 Correct 690fe0c to actually log the exception reported in DoOnRezScriptQueue()(and now the scene name). 2014-11-29 15:04:16 +00:00
Justin Clark-Casey (justincc) 690fe0c5e5 If there are any exceptions in XEngine.DoOnRezScriptQueue() then log the error and always set m_CurrentCompile = null
Setting m_CurrentCompile = null in the finally block reduces the risk that an exception could permanently stop any future scripts compiling until the simulator is restarted.
If an exception is seen from this then please report and further changes to fix the bug or improve compiling reliability can be made.
2014-11-29 01:42:52 +00:00
Justin Clark-Casey (justincc) 55e064baf7 Remove minor race condition where two threads could race on fields such as m_ScriptFailCount as set in XEngine.DoOnRezScriptQueue() 2014-11-29 01:33:14 +00:00
Justin Clark-Casey (justincc) 79e37e5ecc Restore zero'ing RawVelocity in BSCharacter.ZeroMotion() in favour of not calling ZeroMotion in SetPhysicalProperties() at all
SetPhysicalProperties is only called when adding a new character so it looks like there is no existing data to reset anyway.
2014-11-29 01:13:48 +00:00
Justin Clark-Casey (justincc) dfab60a7fd minor: Remove a few indenting problems introduced to recent 265fe349 and convert the m_log.DebugFormat() call back to the original DetailLog call 2014-11-29 00:53:13 +00:00
Justin Clark-Casey (justincc) dcc36507f3 Halve the prediction lag for region crossing to improve most flying region crossings without degrading the walk cross experience (neither of which have been that great anyway). 2014-11-29 00:48:26 +00:00
Justin Clark-Casey (justincc) 39eab72d7c When performing region cross, don't add the velocity to the new position in ETM.CrossAgentIntoNewRegionMain() since this has already been performed by SP.CheckForBorderCrossing() 2014-11-29 00:16:23 +00:00
Justin Clark-Casey (justincc) 265fe349e0 Somewhat improve avatar region crossings by properly preserving velocity when avatar enters the new region.
This commit addresses the following issues were causing velocity to be set to 0 on the new region, disrupting flight in particular
* Full avatar updates contained no velocity information, which does appear to have some effect in testing.
* BulletSim was always setting the velocity to 0 for the new BSCharacter.  Now, physics engines take a velocity parameter when setting up characters so we can avoid this.
This patch applies to both Bullet and ODE.
2014-11-29 00:12:11 +00:00
Justin Clark-Casey (justincc) 09534f378e Avoid repeated lag-generating continuous attempts to retrieve HG service Urls in UMM if the initial request fails, possibly due to the home URL not being present
Instead, the failure information is effectively added to the memory cache (so no persistence over simualtor sessions).
A future improvement may be to invalidate negative cache results after some time has passed in case the failure was transient.
Looks to resolve http://opensimulator.org/mantis/view.php?id=7382
2014-11-28 01:16:30 +00:00
Justin Clark-Casey (justincc) d9f7aa41c1 Remove unmaintained MSSQL support.
This has not been maintained for more than 2 years, is unimplemented for newer features (e.g. built-in groups) and has no core developers using it.
If somebody fixes these issues then it could be reinstated.
2014-11-28 00:27:13 +00:00
Justin Clark-Casey (justincc) 73234e2098 Stop writing SizeZ config parameter for now when creating regions from console as it is unused/ignored, at least in core. 2014-11-28 00:04:10 +00:00
Justin Clark-Casey (justincc) ee9fae23ff Be more explicit again in UMM bad HomeURL message by logging the original creator data 2014-11-27 00:32:04 +00:00
Justin Clark-Casey (justincc) 8a27fc5d61 Make UMM.AddUser(UUID, string) log message when bad creatorData is given to reflect its location (UMM not Scene) and add the user name and ID. 2014-11-27 00:24:17 +00:00
BlueWall 62b778ca4d Merge branch 'master' of /team/src/opensim 2014-11-25 19:27:28 -05:00
BlueWall a76aec8467 Fix whitespace hoping to avoid a flogging 2014-11-25 19:27:15 -05:00
Justin Clark-Casey (justincc) 86367d7219 refactor: Move methods to start a monitored thread, start work in its own thread and run work in the jobengine from Watchdog to a WorkManager class.
This is to achieve a clean separation of concerns - the watchdog is an inappropriate place for work management.
Also adds a WorkManager.RunInThreadPool() class which feeds through to Util.FireAndForget.
Also switches around the name and obj arguments to the new RunInThread() and RunJob() methods so that the callback obj comes after the callback as seen in the SDK and elsewhere
2014-11-25 23:56:32 +00:00
Justin Clark-Casey (justincc) 20cede12a9 Fix ghosts copy of SimulatorFeatureModule to enable logging. 2014-11-25 23:28:38 +00:00
Justin Clark-Casey (justincc) 66b1c37973 Fix bug in HG attachment throttling code where attachments were never rezzed on any teleport within a foreign grid after the first.
Bug was introduced in ghosts branch commit 69abade
2014-11-25 23:23:12 +00:00
Justin Clark-Casey (justincc) 4b45a1b6ad Change jobengine logging command to "debug jobengine log <int>" rather than loglevel, in common with similar commands. 2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) b1fd0d35e5 Make small adjustment to JobEngine default from previous commit to enable it when [Startup] section is not present (though this is extremely unlikely). 2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) 59b38f842a Add [Startup] JobEngineEnabled setting that allows the job engine to be disabled for testing purposes if necessary. 2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) 28d1dbfee4 Move conditionals which control whether a task is placed in the JobEngine inside Watchdog.RunJob() (renamed from RunWhenPossible) and generalize them. 2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) 124be38f74 Add [BulletSim] option AvatarToAvatarCollisionsByDefault to control whether avatars collide. This is true by default.
This is implemented with a new collision type (PhantomToOthersAvatar) to potentially allow colliding and non-colliding avatars to be present in the same scene.
So there is no provision yet for giving avatars different collision types.
This commit replaces the temporary change in commit f3eaa6d8 where avatars would never collide when using BulletSim
This is equivalent to the av_av_collisions_off option in ODE.
2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) 3a296a817b Fix compile error from previous 1d56029848 2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) 550cf714bc Fix issue where llRemoteLoadScriptPin() would treat 0 (the default) as a valid set pin in a destination prim rather than the unset no pin state
Adds regression test for this case.
2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) aeae34505f When processing incoming attachments via HG, if a request for uuid gathering or final asset import takes too long remove remaining requests from same user to prevent hold up of other user's incoming attachments.
This improves upon the earlier naive simply queueing immplementation.
Threshold is 30 seconds.  If this happens to a user they can relog and fetch will be reattempted.
2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) 06a5d6e9ef Introduce an IteratingUuidGatherer where each fetch from the asset service (iteration) can be controlled by the caller.
This is to enable an imminent change where incoming HG scene object fetching can assess the time taken by each request rather than being forced to perform all requests in one call.
Soon, this will replace the existing UuidGatherer since it is both simpler and more flexible.
2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) d6c9705a3b Add incoming packet async handling engine to queue some inbound udp async requests.
This is to reduce the potential for overload of the threadpool if there are many simultaneous requets in high concurrency situations.
Currently only applied to AvatarProperties and GenericMessage requests.
2014-11-25 23:23:11 +00:00
Justin Clark-Casey (justincc) 1c5c6af274 Add missing class from recent commit 69abade 2014-11-25 23:23:10 +00:00
Justin Clark-Casey (justincc) f54c70741b Add "show threadpool calls active" console debug command.
This shows named threadpool calls (excluding timer and network calls) that are currently queued or running.
Also shows total of labelled and any anonymous calls.
2014-11-25 23:23:10 +00:00
Justin Clark-Casey (justincc) 1d19e1bbd0 Add naive implementation of controlled incoming HG attachments to manage load.
Instead of processing all incoming attachment scene object concurrently, process them consecutively to eliminate potential overload from this source.
This is a naive implementation because it does not currently account for slow foreign asset services.
Although it may take longer, this approach may also improve attachment visibility for HG avatars
since the scene object is now always added to the scene after receiving assets from the foreign service and not before.
2014-11-25 23:23:10 +00:00
Justin Clark-Casey (justincc) ec8d21c434 Label all threadpool calls being made in core OpenSimulator. This is to add problem diagnosis.
"show threadpool calls" now also returns named (labelled), anonymous (unlabelled) and total call stats.
2014-11-25 23:23:10 +00:00
Justin Clark-Casey (justincc) 72cb1cc7d6 Add "show threadpool calls" command to show count of all labelled smartthreadpool calls 2014-11-25 23:23:10 +00:00
Justin Clark-Casey (justincc) 8c9f82b035 Just for now, don't alert the user or log if we couldn't change their server-side preferences due to no e-mail address being sent.
This is to avoid user confusion in the oscc rehearsal as they are often not aware that this fails because no e-mail is set.
Also may be failing in the hypergrid case, though this may also be a config issue.
This is meant as a temporary solution.
2014-11-25 23:23:10 +00:00
Justin Clark-Casey (justincc) 5d5ea9234f Stop Mono 3.2.8 from binding a UDP socket to a port already in use.
At least on Mono 3.2.8 (but not under Windows), one can bind multiple UDP sockets to the same port by default.
Different simulators cannot demultiplex each other's messages, so a set of confusing non-obvious errors arise if this occurs.
This change prevents such multiple binding.
2014-11-25 23:23:09 +00:00
Justin Clark-Casey (justincc) b53be022f2 On pCampbot, if we add the none (n) behaviour then make it actually stop any bots in motion.
Previously, adding this behaviour after physics (p) would leave the bot to drift off for ever in its last movement direction.
2014-11-25 23:23:09 +00:00
Justin Clark-Casey (justincc) 3a1ce2715a Add "wearables check" console command
This checks that all the wearable assets and any assets for a given logged in avatar exist in the asset service
2014-11-25 23:23:09 +00:00
Justin Clark-Casey (justincc) 9b09dd3575 Add "wearables show" console command.
This shows summary wearables information (shape, hair, etc.) for all avatars in the scene or specific information about a given avatar's wearables.
Similar to the existing "attachments show" command.
2014-11-25 23:23:09 +00:00
Justin Clark-Casey (justincc) 5ab5d7fe47 Fix recent regression where adaptive throttles stopped adjusting.
Extends regression tests to test response of adaptive throttles to ack'ed and expired packets.
2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) b2e377f168 Fix setting of max scene throttle so that setting it restricts the child client throttles properly.
In "show throttles", also renames 'total' column to 'actual' to reflect that it is not necessarily the throttles requested for/by the client.
Also fills out 'target' in non-adapative mode to the actual throttle requested for/by the client.
2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) b114f5626e Add request drip rate to assertions for token bucket regression tests 2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) 8a949f0ee1 Add regression tests for token buckets on their own 2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) ec3b43d28d Make regression throttle tests consistently test target and max throttle settings.
As part of this also refactors code to put all throttle asserts in a single regression test method
2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) 548abb3b47 minor: In "show client stats" command, properly handle the case where a client has made no AgentUpdate requests (as is the case with agents that have only even been child) rather than throwing an exception 2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) a9dde81753 minor: Correct letter accidentally added to copyright notice on top of Scene.cs (almost five years ago!) 2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) b7ef6009a7 In Scene.AddNewAgent(), avoid a situation where an exception can result in a client being added to the manager without IClientAPI.SceneAgent being set.
This is done by adjusting the order of code so that SceneAgent will always be set before adding the client.
Various parts of the code (rightly) assume that a a client registered to the manager will always have a SceneAgent set no matter what.
2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) e6af551007 For now, send all non-full terse updates for ones own avatar directly to the LLUDP client stack rather than queueing internally within LLClientView.
When an HG avatar enters a scene, it delays processing of entity updates.  Could be crowding out by other updates or something else.
This delay in ones own av mvmt updates results in mvmt lag experienced on the client.  Avoiding the internal LLClientView for these packets appears to resolve this issue.
Appears most noticeably for avatars with attachments, though has also been seen on those without sometimes.  Hasn't been observed for non-HG avatars in general.
Will be investigating exactly what the problem is, at which point there will be a more permanent solution.
2014-11-25 23:22:20 +00:00
Justin Clark-Casey (justincc) 10095c1a58 Add "debug lludp throttles get/set request" and get current
This allows one to set the requested throttle (which normally comes from the client) as opposed to the max.
2014-11-25 23:22:19 +00:00
Justin Clark-Casey (justincc) 61d6bd78b3 Change the word order of some debug lludp settings for readability
On server, scene-throttle-max becomes max-scene-throttle and likewise max-new-client-throttle
On clients, throttle-max becomes max
2014-11-25 23:22:19 +00:00